public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: John Pittman <jpittman@redhat.com>
To: shinichiro.kawasaki@wdc.com
Cc: linux-block@vger.kernel.org, John Pittman <jpittman@redhat.com>
Subject: [PATCH blktests v2 2/2] block/042: check sysfs values prior to running
Date: Thu, 22 Jan 2026 14:31:33 -0500	[thread overview]
Message-ID: <20260122193133.3087906-3-jpittman@redhat.com> (raw)
In-Reply-To: <20260122193133.3087906-1-jpittman@redhat.com>

In testing some older kernels recently, block/042 has failed due
to dma_alignment and virt_boundary_mask not being present.

   Running block/042
   +cat: '.../queue/dma_alignment': No such file or directory
   +cat: '.../queue/virt_boundary_mask': No such file or directory
   +dio-offsets: test_dma_aligned: failed to write buf: Invalid argument

To ensure we skip if this is the case, check all sysfs values prior
to run. Also, change the spaces to tabs before _require_test_dev_sysfs
for consistency with the rest of blktests.

Signed-off-by: John Pittman <jpittman@redhat.com>
---
 tests/block/042 | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/block/042 b/tests/block/042
index 28ac4a2..8a31149 100644
--- a/tests/block/042
+++ b/tests/block/042
@@ -11,7 +11,9 @@ DESCRIPTION="Test unusual direct-io offsets"
 QUICK=1
 
 device_requires() {
-        _require_test_dev_sysfs
+	_require_test_dev_sysfs "queue/max_segments" "queue/dma_alignment" \
+		"queue/virt_boundary_mask" "queue/logical_block_size" \
+		"queue/max_sectors_kb"
 }
 
 test_device() {
-- 
2.51.1


  parent reply	other threads:[~2026-01-22 19:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-22 19:31 [PATCH blktests v2 0/2] blktests: add ability for multiple dev sysfs checks John Pittman
2026-01-22 19:31 ` [PATCH blktests v2 1/2] common/rc: support multiple arguments for _require_test_dev_sysfs() John Pittman
2026-01-22 19:31 ` John Pittman [this message]
2026-01-25  7:17 ` [PATCH blktests v2 0/2] blktests: add ability for multiple dev sysfs checks Shinichiro Kawasaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260122193133.3087906-3-jpittman@redhat.com \
    --to=jpittman@redhat.com \
    --cc=linux-block@vger.kernel.org \
    --cc=shinichiro.kawasaki@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox