public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Yaxiong Tian <tianyaxiong@kylinos.cn>
Cc: Jens Axboe <axboe@kernel.dk>,
	mhiramat@kernel.org, mathieu.desnoyers@efficios.com,
	corbet@lwn.net, skhan@linuxfoundation.org,
	linux-trace-kernel@vger.kernel.org, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v4 5/5] blktrace: Make init_blk_tracer() asynchronous when trace_async_init set
Date: Thu, 29 Jan 2026 22:26:08 -0500	[thread overview]
Message-ID: <20260129222608.7000bffd@robin> (raw)
In-Reply-To: <a61e6bc0-58d1-46f0-8a4f-17f02503fe17@kylinos.cn>

On Fri, 30 Jan 2026 11:09:26 +0800
Yaxiong Tian <tianyaxiong@kylinos.cn> wrote:

> > thought|trace_eval_sync()|'s|destroy_workqueue()|would wait for all 
> > tasks to complete, but it seems that might not be the case. From this, 
> > if the above conclusion is true, then strictly speaking, tasks 
> > using|queue_work(xx)|cannot be guaranteed to finish before the init 
> > process executes. If it's necessary to strictly ensure initialization 
> > completes before user space starts, 
> > using|async_synchronize_full()|or|async_synchronize_full_domain()|would 
> > be better in such scenarios.  
> I need to double-check this issue—theoretically, it shouldn't exist. But 
> I'm not sure why the print appeared at the 14-second mark.

Use trace_printk() instead. printk now has a "deferred" output. I'm not
sure if the timestamps of when it prints is when the print took place
or when it got to the console :-/

-- Steve


> >
> > Of course, the situation described above is an extreme case. I don't 
> > oppose this approach; I only hope to make the startup faster for 
> > ordinary users who don’t use trace, while minimizing the impact on 
> > others as much as possible.
> >  

  reply	other threads:[~2026-01-30  3:26 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-28 12:51 [PATCH v4 0/5] Tracing: Accelerate Kernel Boot by Asynchronizing Yaxiong Tian
2026-01-28 12:53 ` [PATCH v4 1/5] tracing: Rename `eval_map_wq` and allow other parts of tracing use it Yaxiong Tian
2026-01-28 12:54 ` [PATCH v4 2/5] tracing: add trace_async_init boot parameter Yaxiong Tian
2026-01-28 12:55 ` [PATCH v4 3/5] tracing/kprobes: Skip setup_boot_kprobe_events() when no cmdline event Yaxiong Tian
2026-01-28 12:55 ` [PATCH v4 4/5] tracing/kprobes: Make setup_boot_kprobe_events() asynchronous when trace_async_init set Yaxiong Tian
2026-01-28 12:55 ` [PATCH v4 5/5] blktrace: Make init_blk_tracer() " Yaxiong Tian
2026-01-29  0:41   ` Steven Rostedt
2026-01-29  2:25     ` Jens Axboe
2026-01-29 20:29       ` Steven Rostedt
2026-01-30  1:35         ` Yaxiong Tian
2026-01-30  3:09           ` Yaxiong Tian
2026-01-30  3:26             ` Steven Rostedt [this message]
2026-01-30  3:31               ` Steven Rostedt
2026-01-30  3:45                 ` Steven Rostedt
2026-01-30  4:10                   ` Yaxiong Tian
2026-01-30  9:30         ` Masami Hiramatsu
2026-01-30  9:59           ` Yaxiong Tian
2026-02-02  3:36         ` Yaxiong Tian
2026-01-28 23:38 ` [PATCH v4 0/5] Tracing: Accelerate Kernel Boot by Asynchronizing Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260129222608.7000bffd@robin \
    --to=rostedt@goodmis.org \
    --cc=axboe@kernel.dk \
    --cc=corbet@lwn.net \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=tianyaxiong@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox