From: kernel test robot <lkp@intel.com>
To: Yu Kuai <yukuai@fnnas.com>,
tj@kernel.org, josef@toxicpanda.com, axboe@kernel.dk
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, yukuai@fnnas.com,
zhengqixing@huawei.com, mkoutny@suse.com, hch@infradead.org,
ming.lei@redhat.com, nilay@linux.ibm.com
Subject: Re: [PATCH v2 2/7] bfq: protect q->blkg_list iteration in bfq_end_wr_async() with blkcg_mutex
Date: Tue, 3 Feb 2026 21:36:52 +0800 [thread overview]
Message-ID: <202602032109.oYgANNeZ-lkp@intel.com> (raw)
In-Reply-To: <20260203080602.726505-3-yukuai@fnnas.com>
Hi Yu,
kernel test robot noticed the following build errors:
[auto build test ERROR on axboe/for-next]
[also build test ERROR on linus/master v6.19-rc8 next-20260202]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Yu-Kuai/blk-cgroup-protect-q-blkg_list-iteration-in-blkg_destroy_all-with-blkcg_mutex/20260203-161356
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux.git for-next
patch link: https://lore.kernel.org/r/20260203080602.726505-3-yukuai%40fnnas.com
patch subject: [PATCH v2 2/7] bfq: protect q->blkg_list iteration in bfq_end_wr_async() with blkcg_mutex
config: s390-randconfig-002-20260203 (https://download.01.org/0day-ci/archive/20260203/202602032109.oYgANNeZ-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 9b8addffa70cee5b2acc5454712d9cf78ce45710)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260203/202602032109.oYgANNeZ-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202602032109.oYgANNeZ-lkp@intel.com/
All errors (new ones prefixed by >>):
>> block/bfq-iosched.c:2648:27: error: no member named 'blkcg_mutex' in 'struct request_queue'
2648 | mutex_lock(&bfqd->queue->blkcg_mutex);
| ~~~~~~~~~~~ ^
include/linux/mutex.h:193:44: note: expanded from macro 'mutex_lock'
193 | #define mutex_lock(lock) mutex_lock_nested(lock, 0)
| ^~~~
block/bfq-iosched.c:2660:29: error: no member named 'blkcg_mutex' in 'struct request_queue'
2660 | mutex_unlock(&bfqd->queue->blkcg_mutex);
| ~~~~~~~~~~~ ^
2 errors generated.
vim +2648 block/bfq-iosched.c
2642
2643 static void bfq_end_wr(struct bfq_data *bfqd)
2644 {
2645 struct bfq_queue *bfqq;
2646 int i;
2647
> 2648 mutex_lock(&bfqd->queue->blkcg_mutex);
2649 spin_lock_irq(&bfqd->lock);
2650
2651 for (i = 0; i < bfqd->num_actuators; i++) {
2652 list_for_each_entry(bfqq, &bfqd->active_list[i], bfqq_list)
2653 bfq_bfqq_end_wr(bfqq);
2654 }
2655 list_for_each_entry(bfqq, &bfqd->idle_list, bfqq_list)
2656 bfq_bfqq_end_wr(bfqq);
2657 bfq_end_wr_async(bfqd);
2658
2659 spin_unlock_irq(&bfqd->lock);
2660 mutex_unlock(&bfqd->queue->blkcg_mutex);
2661 }
2662
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2026-02-03 13:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 8:05 [PATCH v2 0/7] blk-cgroup: fix races and deadlocks Yu Kuai
2026-02-03 8:05 ` [PATCH v2 1/7] blk-cgroup: protect q->blkg_list iteration in blkg_destroy_all() with blkcg_mutex Yu Kuai
2026-02-03 8:05 ` [PATCH v2 2/7] bfq: protect q->blkg_list iteration in bfq_end_wr_async() " Yu Kuai
2026-02-03 12:54 ` kernel test robot
2026-02-03 13:07 ` Yu Kuai
2026-02-03 13:36 ` kernel test robot [this message]
2026-02-03 8:05 ` [PATCH v2 3/7] blk-cgroup: fix race between policy activation and blkg destruction Yu Kuai
2026-02-03 8:05 ` [PATCH v2 4/7] blk-cgroup: skip dying blkg in blkcg_activate_policy() Yu Kuai
2026-02-03 8:06 ` [PATCH v2 5/7] blk-cgroup: factor policy pd teardown loop into helper Yu Kuai
2026-02-03 8:06 ` [PATCH v2 6/7] blk-cgroup: allocate pds before freezing queue in blkcg_activate_policy() Yu Kuai
2026-02-03 9:06 ` Michal Koutný
2026-02-04 6:44 ` Yu Kuai
2026-02-03 8:06 ` [PATCH v2 7/7] blk-rq-qos: move rq_qos_mutex acquisition inside rq_qos_add/del Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202602032109.oYgANNeZ-lkp@intel.com \
--to=lkp@intel.com \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=hch@infradead.org \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=ming.lei@redhat.com \
--cc=mkoutny@suse.com \
--cc=nilay@linux.ibm.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=tj@kernel.org \
--cc=yukuai@fnnas.com \
--cc=zhengqixing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox