From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from BL0PR03CU003.outbound.protection.outlook.com (mail-eastusazon11012054.outbound.protection.outlook.com [52.101.53.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 150B627456; Wed, 11 Feb 2026 20:45:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.53.54 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770842728; cv=fail; b=qVkgddwhiSm686W8DjEMfw40BuxBEQtb8DjMvVKPU0DN+5YzdJGC2sREzgh4JHWkYlJ2MkQUFI4s1Gt4SQDxkN+2IJX2KQxYTBsaC+ecgcUw/9gG9eAx4rALlFWzRNiX+3mGYKfW1cNDRsHaivsxyW6AfBc8iN1nhrv5w9AIyW0= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770842728; c=relaxed/simple; bh=xOAfqjLi0gxtKGQp5GBJL33Z1brl1pOebysGscjrhYc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lEHtuXV/70hrQSDjIgsNHueVMwuuO+35NHrV+NcK4Y00bD07c146AcbYj5j8GSqO5XMDDCJLR4Peu5JdRAihLjRWljEtOezvQYYYgYIb4or0kYEwXfgmo/JNamnZv3SCPiq804hJgsDtHEgYXRw/FIaWUPK55JfiDIUJEsFgDbQ= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=tW+BaS46; arc=fail smtp.client-ip=52.101.53.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="tW+BaS46" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ra6lMuqNQ+pR1hT+bUAojJxUBxOvntWY/eh0yse6AxFFZ3yqY4vveE9mAIZ57ZqSJF7QW9MmNnQel5TgBnju8qe5/qkNsGY9AJzXpBMpA6vkH0DahSZcF8XWSXnONGr/PfHuR05yQ2zVqUOpGHZgqDJysUVgTa2PpFgEBFEPLG6vnf7elMpVxn3wUhYJHkOQiRu6fhMwKw1fJZbsLTm6tfLIf7UY5dXJG6PpsF1ICH1PYEAJl+QBLw01AFWZeYySqnqWigsQVSa2Fjom9P5m/cv9o4fk3W4u8OnP8tC5pyZiVhwjKj9//Udvo+tgBFwFgU1BHPmRSezWc3MA/Z9VQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2LndKb2jFGYiU8UOEQgxz4saC3GC50432Z0R5ExY5ss=; b=MCu+z4o2MigTu49ovwna5UNNDPcBLGucF6xpfbdJp2gwUhjsMHFmkcha2yHZTR7uwq+FyktF+qnsL6IuPCqBKH2ZYg9252mpkcVbb0mIQu14nyrp2FWgGTJFR5c/fyFmBhwF2lG4RLAgEYZ5/+RWr7VEDRAj/s8oa8G6ITVe2S/Wewoew+5nOdqusNJBuMA8AjSNinerYm/WvUDGLT3p4o4KoMmVMpBzYxO+Q1FXWMbIs6lF5Eji69szvnJPrtmT17CRPySc4mjCZXD2aQrx+bgmPecpgyHBBp1WYsorIYxE0U4ob3BAROAlpazlratIrNBjipUryfEIzNuItrLcYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=huawei.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2LndKb2jFGYiU8UOEQgxz4saC3GC50432Z0R5ExY5ss=; b=tW+BaS46PxbDzHA9Sy8bqQJfwEI1LQ+0Khw2GEkbrSOB92A3VtSeBlewxq9ur9cdDorh0/YD0mzCXechRH1i1rdo0V/qFzi2ev6qEUVvfd207E/NVZBbF+E5XdUxu6ov2sUN9v4ulcw7v9JJHSio67QIAsYQ1PCF1mDUZeiUT9XdYarOB7m4QzWyzO+mSh8EqGL/Rq1ZIoL37mvTp/ig/nxRMkkZYHUWhUGhs0aZIv66PcocmWWm3WKEH5aiJpbDVItEXvrvqRSGUtw+J8TXl5LP+4SxyaAySTCahkp4SyTP+muXF9zt6prYRAzYekh5888iEW/NS2n2Us+fEFA6Eg== Received: from BYAPR21CA0010.namprd21.prod.outlook.com (2603:10b6:a03:114::20) by CH2PR12MB9459.namprd12.prod.outlook.com (2603:10b6:610:27d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.10; Wed, 11 Feb 2026 20:45:19 +0000 Received: from CO1PEPF000075F4.namprd03.prod.outlook.com (2603:10b6:a03:114:cafe::16) by BYAPR21CA0010.outlook.office365.com (2603:10b6:a03:114::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9632.4 via Frontend Transport; Wed, 11 Feb 2026 20:45:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1PEPF000075F4.mail.protection.outlook.com (10.167.249.43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.8 via Frontend Transport; Wed, 11 Feb 2026 20:45:17 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Wed, 11 Feb 2026 12:44:57 -0800 Received: from dev.nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Wed, 11 Feb 2026 12:44:56 -0800 From: Chaitanya Kulkarni To: , , , , , CC: , , , Chaitanya Kulkarni , "Martin K . Petersen" , Johannes Thumshirn Subject: [PATCH V4 1/3] md: ignore discard return value Date: Wed, 11 Feb 2026 12:44:36 -0800 Message-ID: <20260211204438.22568-2-kch@nvidia.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260211204438.22568-1-kch@nvidia.com> References: <20260211204438.22568-1-kch@nvidia.com> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000075F4:EE_|CH2PR12MB9459:EE_ X-MS-Office365-Filtering-Correlation-Id: ccbeead2-e302-4827-0c83-08de69ae775d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|36860700013|82310400026|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?4QbGyiWvo3eyqnzHQuanIRPMaAR7ZowCbePnNDhtLTpZCWQcQ8S58IFpv3X2?= =?us-ascii?Q?xhETl812HsvWuBYNIc+G1f9IaMcJ+rXUP6fJ7zuxiknlc+RreOELNXvoqtrI?= =?us-ascii?Q?BRmgsFaxidnmUNQaW76BlSchaPrKu+oXXhx6kVjRspyBWtBYvhKbZ+R29GBM?= =?us-ascii?Q?Kjr+y0vZnT3miOdXv4lV23Y6+jzlkeihoXaEQPglhwISY3GBScUbq70QIFzS?= =?us-ascii?Q?9P15utk0/swy1cz7kozk+vnDRcwPRQ01B+g3MR2DFIbOV57c5QHZ6Wx3ebrm?= =?us-ascii?Q?Rn8YzfhFtLT4iOV96iC1QawHMGNjXqpHPzLhygAjjF6ctT5IlMHEZm3I42Xi?= =?us-ascii?Q?14JQYB954lOcyxukwba2W2B5qZ3BMcXNDh4BWqVvBT6mCvI5OQRjU4NDTh3i?= =?us-ascii?Q?o+zkrzff0PeJy28JqzcpU2aRHNf/tuxY4h+mMTjxcIjZ9ybrGYLSZBbKnR/g?= =?us-ascii?Q?xbeeS5+7cnHNtnPkjz7pBhSthV3fPxI4f5czkl9kpXm85LG69CtIGfNCFeeF?= =?us-ascii?Q?6AuwdZwbyS7TrjHpsMCdExuKMuDZvFdCIEFa/Yi8qxrZHsDbaPu+MRUru275?= =?us-ascii?Q?9vAzaaKhJED/c3ifOeN6UtTQYBkYrClClpF+b6sq+zvdxFDrjS1NsvNBRGhG?= =?us-ascii?Q?D7G49H9Fj/Pmi01VhjsRcQFtMMhEbHt0ANU0KTOiWEU9oU9HJC14NDWPeYqn?= =?us-ascii?Q?gHQXM3daG/JRx9xOitRI7YZjKv9l7O3N0jy4j8ctf6UsWd6eKgSXOy61IZCG?= =?us-ascii?Q?OLJYtHsdPqDlCoU6aFv7HGQZN3OKnQ93tKPi/yxRATjG4tzBOwixvYo6qai7?= =?us-ascii?Q?kISLtvRfCC7+ShBaRyFU5baP6I4KjrvqHlEyvySqV+HpUzsKEEQS1IVzFQMM?= =?us-ascii?Q?b/4ruGKiqjcQERnwjvgLc39TvbLrghoK4MfY7LY4exCaEQdS3mxYN3s6j8xd?= =?us-ascii?Q?zrJeFWrEO+VefRV6EmNg3nV3KuP9rCqGPvzkk4S7hJChyuw1LVyQ8/l+Rut1?= =?us-ascii?Q?7IC9kAX4537/yW/Gsm2xhavIUMTCiBQfI/ubCfn+UCooNxzGXsXTMvvSj82O?= =?us-ascii?Q?bQkvlSji05mh2EdUxbP22fShLM66JOpi22jRbLZpuEHTyqkLUKnsVTh3LB5j?= =?us-ascii?Q?Zn5Thi/ytCthh7hGqlaTl2XxWQvoxpZy0Speox5qRz6zv8qB/ZUySRknBvcL?= =?us-ascii?Q?t9hVVxr9hE3Ojy8Z2Y8o1xXto+ByLyOzjuY49Y6c4yCqJljgRpREPcRgDAXW?= =?us-ascii?Q?Ws3YDpALDEUY6PvhgsHrRsrq6VJpPV/+1CTWjhHYyK+7JcwQyYRhZuHJtZH+?= =?us-ascii?Q?8R5o6CJL30K9lp7fN2kLeoqoYkbWzUulIvkRtCnrEcEDOUDRWSkF5vkTBb9d?= =?us-ascii?Q?//z+qUN7myaqpxqotIFcVEizSZ8mkgQOfbgpHQVGR5+7V+U3t6X0tNOBgyj/?= =?us-ascii?Q?bQMWSlL2saM4KOo6MG4tORzEAdsEK5Q+aeWvf6FifGJf8PdOdqwdVkoqNvGf?= =?us-ascii?Q?OrGyILlkZhT5iZEPyWGIw9XVwptpc2cbAEto0BpowsW7g40Nh9JzDGI+zxvs?= =?us-ascii?Q?v0yBrzQgaG8J9u1MWTR+FQK55n2fd7W7QBxp7l+EAzBTIf1tNIFqjIqfOdf6?= =?us-ascii?Q?+bt1mBAgD7Kcu/oFFQD6X9Gp82sS8eOtgrL2hq4332ymtgigugRX+xyqYJAR?= =?us-ascii?Q?CVQTTw=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(7416014)(376014)(36860700013)(82310400026)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 8Ko+vMRIlkUF/AsSGgBPKoDBDk1ZFcie57qjNnyOahG2oYmn0WAd9JIOYcD/00z0FxJV55GeWa1BpPx+Y9qr8fe3gwwD0o3sWiC0y8QRO+tHDPzPW7xnK7V2ax8rFZ+mTsk6HzfICk+Qd9JRnhPld4e13HLs9ejWsLF4tnyDES8fhOgNmrButgVmn3ZRMeh/ArBrQv5b7iailjL4cJ96iUwuwd388Bu/OkrC87OQ6WKAM1ZbFth9xDjdcovdd8uBo8ESjl4sfd3NTeT9ca+1/BcIx/GrAEDVCvuM/iv+D6TTxMDH69SfMvXtC8poBNnnlr0H3c34h0Ncr+yxsW2q5X5adDO7p8CpFnOjX6TSZz95f99OWYgDo7hDB0ho5KLKCOSQ4gdWWkb20rWw4CUIDUZQFBLwq1J/gBGN3ntxm7I44rsb06TWbMFKjxTwc5NB X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2026 20:45:17.9448 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ccbeead2-e302-4827-0c83-08de69ae775d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000075F4.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB9459 __blkdev_issue_discard() always returns 0, making all error checking at call sites dead code. Simplify md to only check !discard_bio by ignoring the __blkdev_issue_discard() value. Reviewed-by: Martin K. Petersen Reviewed-by: Johannes Thumshirn Reviewed-by: Christoph Hellwig Signed-off-by: Chaitanya Kulkarni --- drivers/md/md.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/md/md.c b/drivers/md/md.c index 59cd303548de..89c9e63a9139 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -9179,8 +9179,8 @@ void md_submit_discard_bio(struct mddev *mddev, struct md_rdev *rdev, { struct bio *discard_bio = NULL; - if (__blkdev_issue_discard(rdev->bdev, start, size, GFP_NOIO, - &discard_bio) || !discard_bio) + __blkdev_issue_discard(rdev->bdev, start, size, GFP_NOIO, &discard_bio); + if (!discard_bio) return; bio_chain(discard_bio, bio); -- 2.39.5