From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.g.garry@oracle.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org, hch@lst.de
Subject: Re: [PATCH] block: Correct comment on bio_alloc_clone()
Date: Fri, 20 Feb 2026 16:10:19 +0100 [thread overview]
Message-ID: <20260220151019.GA14027@lst.de> (raw)
In-Reply-To: <20260220143233.3500551-1-john.g.garry@oracle.com>
On Fri, Feb 20, 2026 at 02:32:33PM +0000, John Garry wrote:
> Correct the comment that the source bio must not be freed before the clone.
Note that while this version is better, it's not actually true either.
The bi_io_vec used by the clone must be freed after the clone, but it
might might not be owned by the passed in bio_src.
next prev parent reply other threads:[~2026-02-20 15:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 14:32 [PATCH] block: Correct comment on bio_alloc_clone() John Garry
2026-02-20 15:10 ` Christoph Hellwig [this message]
2026-02-20 15:36 ` John Garry
2026-02-20 15:43 ` Christoph Hellwig
2026-02-20 15:55 ` John Garry
2026-02-20 15:57 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260220151019.GA14027@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=john.g.garry@oracle.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox