public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Damien Le Moal <dlemoal@kernel.org>
To: Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org
Subject: [PATCH v4 4/8] block: remove disk_zone_is_full()
Date: Fri, 27 Feb 2026 22:19:47 +0900	[thread overview]
Message-ID: <20260227131951.2464150-5-dlemoal@kernel.org> (raw)
In-Reply-To: <20260227131951.2464150-1-dlemoal@kernel.org>

The helper function disk_zone_is_full() is only used in
disk_zone_wplug_is_full(). So remove it and open code it directly in
this single caller.

Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
---
 block/blk-zoned.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/block/blk-zoned.c b/block/blk-zoned.c
index 185651a0d617..26c2aa79faf6 100644
--- a/block/blk-zoned.c
+++ b/block/blk-zoned.c
@@ -492,18 +492,12 @@ static bool disk_zone_is_last(struct gendisk *disk, struct blk_zone *zone)
 	return zone->start + zone->len >= get_capacity(disk);
 }
 
-static bool disk_zone_is_full(struct gendisk *disk,
-			      unsigned int zno, unsigned int offset_in_zone)
-{
-	if (zno < disk->nr_zones - 1)
-		return offset_in_zone >= disk->zone_capacity;
-	return offset_in_zone >= disk->last_zone_capacity;
-}
-
 static bool disk_zone_wplug_is_full(struct gendisk *disk,
 				    struct blk_zone_wplug *zwplug)
 {
-	return disk_zone_is_full(disk, zwplug->zone_no, zwplug->wp_offset);
+	if (zwplug->zone_no < disk->nr_zones - 1)
+		return zwplug->wp_offset >= disk->zone_capacity;
+	return zwplug->wp_offset >= disk->last_zone_capacity;
 }
 
 static bool disk_insert_zone_wplug(struct gendisk *disk,
-- 
2.53.0


  parent reply	other threads:[~2026-02-27 13:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-27 13:19 [PATCH v4 0/8] Improve zoned (SMR) HDD write throughput Damien Le Moal
2026-02-27 13:19 ` [PATCH v4 1/8] block: fix zone write plug removal Damien Le Moal
2026-02-27 13:44   ` Johannes Thumshirn
2026-02-27 13:50   ` Christoph Hellwig
2026-02-27 16:44     ` Jens Axboe
2026-02-27 13:19 ` [PATCH v4 2/8] block: fix zone write plugs refcount handling in disk_zone_wplug_schedule_bio_work() Damien Le Moal
2026-02-27 13:19 ` [PATCH v4 3/8] block: rename and simplify disk_get_and_lock_zone_wplug() Damien Le Moal
2026-02-27 13:50   ` Christoph Hellwig
2026-02-27 13:19 ` Damien Le Moal [this message]
2026-02-27 13:19 ` [PATCH v4 5/8] block: rename struct gendisk zone_wplugs_lock field Damien Le Moal
2026-02-27 13:19 ` [PATCH v4 6/8] block: allow submitting all zone writes from a single context Damien Le Moal
2026-02-27 13:45   ` Johannes Thumshirn
2026-02-27 13:19 ` [PATCH v4 7/8] block: default to QD=1 writes for blk-mq rotational zoned devices Damien Le Moal
2026-02-27 13:19 ` [PATCH v4 8/8] Documentation: ABI: stable: document the zoned_qd1_writes attribute Damien Le Moal
2026-02-27 16:45 ` [PATCH v4 0/8] Improve zoned (SMR) HDD write throughput Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260227131951.2464150-5-dlemoal@kernel.org \
    --to=dlemoal@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox