public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Yuto Ohnuki <ytohnuki@amazon.com>
To: <yukuai@fnnas.com>
Cc: <axboe@kernel.dk>, <linux-block@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <ming.lei@redhat.com>,
	<nilay@linux.ibm.com>,
	<syzbot+71fcf20f7c1e5043d78c@syzkaller.appspotmail.com>,
	<ytohnuki@amazon.com>
Subject: Re: [PATCH] blk-wbt: remove WARN_ON_ONCE from wbt_init_enable_default()
Date: Mon, 16 Mar 2026 06:53:38 +0000	[thread overview]
Message-ID: <20260316065337.60071-2-ytohnuki@amazon.com> (raw)
In-Reply-To: <cd42b95b-58de-4d47-9895-f1b5ac7d499e@fnnas.com>

On Mon, Mar 16, 2026 at 01:03:17AM +0800, Yu Kuai wrote:
> Can you also add a warning message that disk failed to enable wbt?
> 
> Otherwise this patch looks good to me.

Hi Kuai,

Thanks for the review. That makes sense, and I'll add a pr_warn()
for the wbt_init() failure path.

For wbt_alloc(), I kept it silent since its failure can be caused
by e.g. memory pressure, which doesn't require diagnostic
information.

If I'm missing your point, please let me know.

I'll send a v2. Thanks again.

Yuto



Amazon Web Services EMEA SARL, 38 avenue John F. Kennedy, L-1855 Luxembourg, R.C.S. Luxembourg B186284

Amazon Web Services EMEA SARL, Irish Branch, One Burlington Plaza, Burlington Road, Dublin 4, Ireland, branch registration number 908705




      reply	other threads:[~2026-03-16  6:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-15 14:31 [PATCH] blk-wbt: remove WARN_ON_ONCE from wbt_init_enable_default() Yuto Ohnuki
2026-03-15 17:03 ` Yu Kuai
2026-03-16  6:53   ` Yuto Ohnuki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260316065337.60071-2-ytohnuki@amazon.com \
    --to=ytohnuki@amazon.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=nilay@linux.ibm.com \
    --cc=syzbot+71fcf20f7c1e5043d78c@syzkaller.appspotmail.com \
    --cc=yukuai@fnnas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox