public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	Damien Le Moal <dlemoal@kernel.org>,
	Bart Van Assche <bvanassche@acm.org>,
	"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
	Madhavan Srinivasan <maddy@linux.ibm.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@kernel.org>,
	Kees Cook <kees@kernel.org>
Subject: [PATCH v2] powerpc/powermac: Remove pmac_low_i2c_{lock,unlock}()
Date: Mon, 16 Mar 2026 13:08:38 -0700	[thread overview]
Message-ID: <20260316200901.4111651-3-bvanassche@acm.org> (raw)
In-Reply-To: <20260316200901.4111651-1-bvanassche@acm.org>

Commit a28d3af2a26c ("[PATCH] 2/5 powerpc: Rework PowerMac i2c part 2")
removed the last calls to the pmac_low_i2c_{lock,unlock}() functions.
Hence, remove these two functions.

Reviewed-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---

Changes compared to v1: corrected the description of the history of the removed
  functions and added Christophe's Reviewed-by tag.

 arch/powerpc/include/asm/pmac_low_i2c.h   |  4 ---
 arch/powerpc/platforms/powermac/low_i2c.c | 34 -----------------------
 2 files changed, 38 deletions(-)

diff --git a/arch/powerpc/include/asm/pmac_low_i2c.h b/arch/powerpc/include/asm/pmac_low_i2c.h
index 21bd7297c87f..fead8fae08ab 100644
--- a/arch/powerpc/include/asm/pmac_low_i2c.h
+++ b/arch/powerpc/include/asm/pmac_low_i2c.h
@@ -79,10 +79,6 @@ extern int pmac_i2c_match_adapter(struct device_node *dev,
 				  struct i2c_adapter *adapter);
 
 
-/* (legacy) Locking functions exposed to i2c-keywest */
-extern int pmac_low_i2c_lock(struct device_node *np);
-extern int pmac_low_i2c_unlock(struct device_node *np);
-
 /* Access functions for platform code */
 extern int pmac_i2c_open(struct pmac_i2c_bus *bus, int polled);
 extern void pmac_i2c_close(struct pmac_i2c_bus *bus);
diff --git a/arch/powerpc/platforms/powermac/low_i2c.c b/arch/powerpc/platforms/powermac/low_i2c.c
index 73b7f4e8c047..da72a30ab865 100644
--- a/arch/powerpc/platforms/powermac/low_i2c.c
+++ b/arch/powerpc/platforms/powermac/low_i2c.c
@@ -1058,40 +1058,6 @@ int pmac_i2c_match_adapter(struct device_node *dev, struct i2c_adapter *adapter)
 }
 EXPORT_SYMBOL_GPL(pmac_i2c_match_adapter);
 
-int pmac_low_i2c_lock(struct device_node *np)
-{
-	struct pmac_i2c_bus *bus, *found = NULL;
-
-	list_for_each_entry(bus, &pmac_i2c_busses, link) {
-		if (np == bus->controller) {
-			found = bus;
-			break;
-		}
-	}
-	if (!found)
-		return -ENODEV;
-	return pmac_i2c_open(bus, 0);
-}
-EXPORT_SYMBOL_GPL(pmac_low_i2c_lock);
-
-int pmac_low_i2c_unlock(struct device_node *np)
-{
-	struct pmac_i2c_bus *bus, *found = NULL;
-
-	list_for_each_entry(bus, &pmac_i2c_busses, link) {
-		if (np == bus->controller) {
-			found = bus;
-			break;
-		}
-	}
-	if (!found)
-		return -ENODEV;
-	pmac_i2c_close(bus);
-	return 0;
-}
-EXPORT_SYMBOL_GPL(pmac_low_i2c_unlock);
-
-
 int pmac_i2c_open(struct pmac_i2c_bus *bus, int polled)
 {
 	int rc;

  parent reply	other threads:[~2026-03-16 20:09 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-16 20:08 [PATCH v2 00/12] Enable lock context analysis Bart Van Assche
2026-03-16 20:08 ` [PATCH v2 01/12] drbd: Balance RCU calls in drbd_adm_dump_devices() Bart Van Assche
2026-03-16 20:08 ` Bart Van Assche [this message]
2026-03-16 20:12   ` [PATCH v2] powerpc/powermac: Remove pmac_low_i2c_{lock,unlock}() Bart Van Assche
2026-03-16 20:08 ` [PATCH v2 02/12] block: Make the lock context annotations compatible with Clang Bart Van Assche
2026-03-17 14:04   ` Christoph Hellwig
2026-03-17 16:36     ` Bart Van Assche
2026-03-16 20:08 ` [PATCH v2 03/12] aoe: Add a lock context annotation Bart Van Assche
2026-03-16 20:08 ` [PATCH v2 04/12] drbd: Make the lock context annotations compatible with Clang Bart Van Assche
2026-03-16 20:08 ` [PATCH v2 05/12] loop: Add lock context annotations Bart Van Assche
2026-03-17 14:05   ` Christoph Hellwig
2026-03-16 20:08 ` [PATCH v2 06/12] nbd: " Bart Van Assche
2026-03-16 20:08 ` [PATCH v2 07/12] null_blk: Add more " Bart Van Assche
2026-03-16 20:08 ` [PATCH v2 08/12] rbd: Add " Bart Van Assche
2026-03-16 20:08 ` [PATCH v2 09/12] ublk: Fix the " Bart Van Assche
2026-03-16 20:08 ` [PATCH v2 10/12] zloop: Add a " Bart Van Assche
2026-03-17 14:07   ` Christoph Hellwig
2026-03-16 20:08 ` [PATCH v2 11/12] zram: Add " Bart Van Assche
2026-03-17 14:08   ` Christoph Hellwig
2026-03-17 16:24     ` Bart Van Assche
2026-03-16 20:08 ` [PATCH v2 12/12] block: Enable lock context analysis for all block drivers Bart Van Assche
2026-03-17 14:08   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260316200901.4111651-3-bvanassche@acm.org \
    --to=bvanassche@acm.org \
    --cc=axboe@kernel.dk \
    --cc=chleroy@kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=hch@lst.de \
    --cc=kees@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=maddy@linux.ibm.com \
    --cc=mingo@kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=tglx@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox