From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A56863BE625 for ; Fri, 20 Mar 2026 13:43:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774014238; cv=none; b=BU+pM6qMteQJhWUME5Y/fWVmbQZj1bAYWb3h46SAgY2pN328QXHOAr/e3Wz9lkHnGXeDXSy2Ldw/TN19HMgaMBWenxra60+s1pvF8AJlDiM7sdyJQFqr7VVsyLydOivjjuqTe9qn7zFbZh8ZtYklBN1fi5ZtpYdjBBYUjenB7RE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774014238; c=relaxed/simple; bh=+gI0d7ZrtcYpFe/TC2/HuBnlqIdH/Oa/KzrJSvIm3yQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rs1mmRvY10huLL2xvIS+wRxZXlHlzSFY6DPiyH59CMU8+6iqVGH60IJinHtPMxcJX3cEm53OBYdKg/I8PgqAJHKxhsYwOXCJzl6nFONGRv0y9TRTY0Wj2ygDfekZoqJx6dzEcDKbc3SWat8vdd+wXOHw6a63v9hDKC9AJggPenY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=B3H+34OR; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=8NMPmkdz; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=B3H+34OR; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=8NMPmkdz; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="B3H+34OR"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="8NMPmkdz"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="B3H+34OR"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="8NMPmkdz" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DD0994D42F; Fri, 20 Mar 2026 13:41:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1774014105; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9N+7lwH2O29FCtDOcIXWRdMiWLy2V1231o6QfK0KGUE=; b=B3H+34ORny/VVsDdq8Hr62tOD3TnB05ou7dq3kq7LNbLASIjTFCdRxBQNcu2Pa8RHshM+q TyvQP5xnk4t0aptuHnqnTCcO9no0olVm366n8MnzI6lGP+jJVAGfTzd+p09bjSCwKI3/5k m+N050d5p527ntCrlprIYFtsh9cjyTg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1774014105; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9N+7lwH2O29FCtDOcIXWRdMiWLy2V1231o6QfK0KGUE=; b=8NMPmkdz0WLinFHfZNQJiWxpyJdx2WXgfJRzXVkTTx+49ftxttZwgSP+bPWH1gUYtaJIvE NrueAE3gP6yUVtDw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1774014105; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9N+7lwH2O29FCtDOcIXWRdMiWLy2V1231o6QfK0KGUE=; b=B3H+34ORny/VVsDdq8Hr62tOD3TnB05ou7dq3kq7LNbLASIjTFCdRxBQNcu2Pa8RHshM+q TyvQP5xnk4t0aptuHnqnTCcO9no0olVm366n8MnzI6lGP+jJVAGfTzd+p09bjSCwKI3/5k m+N050d5p527ntCrlprIYFtsh9cjyTg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1774014105; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9N+7lwH2O29FCtDOcIXWRdMiWLy2V1231o6QfK0KGUE=; b=8NMPmkdz0WLinFHfZNQJiWxpyJdx2WXgfJRzXVkTTx+49ftxttZwgSP+bPWH1gUYtaJIvE NrueAE3gP6yUVtDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C6E884281B; Fri, 20 Mar 2026 13:41:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Q2iOMJlOvWmYCQAAD6G6ig (envelope-from ); Fri, 20 Mar 2026 13:41:45 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 93760A0B4A; Fri, 20 Mar 2026 14:41:45 +0100 (CET) From: Jan Kara To: Cc: , Christian Brauner , Al Viro , , Ted Tso , "Tigran A. Aivazian" , David Sterba , OGAWA Hirofumi , Muchun Song , Oscar Salvador , David Hildenbrand , linux-mm@kvack.org, linux-aio@kvack.org, Benjamin LaHaise , Jan Kara Subject: [PATCH 37/41] minix: Track metadata bhs in fs-private inode part Date: Fri, 20 Mar 2026 14:41:32 +0100 Message-ID: <20260320134100.20731-78-jack@suse.cz> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260320131728.6449-1-jack@suse.cz> References: <20260320131728.6449-1-jack@suse.cz> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=4755; i=jack@suse.cz; h=from:subject; bh=+gI0d7ZrtcYpFe/TC2/HuBnlqIdH/Oa/KzrJSvIm3yQ=; b=owEBbQGS/pANAwAIAZydqgc/ZEDZAcsmYgBpvU6MP3cCFiT/aLD5vOor13PcWVO8kCRuMRMaX zt7IMI92lWJATMEAAEIAB0WIQSrWdEr1p4yirVVKBycnaoHP2RA2QUCab1OjAAKCRCcnaoHP2RA 2QR8CAClXg3d+N3/bqNiRRpe2IrNUXfjQdOVc7lGcDotv64qqab3rTiKZdlmdv8Bd2KcoRnaomQ Myg7leYfa2Nvnic5ekMzWTGqL9RLKhGSRJzI49lITxoSrnS9lrifmtbZe9pvWIOa70EvsU9vh+W fEhXM65Ol7LLcCo4roNxXflza9tT6vBfa91zvXlYSTjT7kmttW7Dzd5UIJY25KGOqydR1MLP9Xn EAvZ0wvTq/gvje2MjjL70nwEfNY51q+eNMkHYnvT3vdFHvLD3677QT8X8U4w0TO6XwxIhNBW4D1 YbqRl1TQno6ZT9HAR5QEqXW3ZDMOeiK1jjpgUQ0o/UsnAkoy X-Developer-Key: i=jack@suse.cz; a=openpgp; fpr=93C6099A142276A28BBE35D815BC833443038D8C Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-5.30 / 50.00]; REPLY(-4.00)[]; BAYES_HAM(-3.00)[100.00%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-0.998]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_CC(0.00)[vger.kernel.org,kernel.org,ZenIV.linux.org.uk,mit.edu,gmail.com,suse.com,mail.parknet.co.jp,linux.dev,suse.de,kvack.org,suse.cz]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; RCPT_COUNT_TWELVE(0.00)[16]; FROM_HAS_DN(0.00)[]; TAGGED_RCPT(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.cz:mid,suse.cz:email]; FROM_EQ_ENVFROM(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; RCVD_COUNT_THREE(0.00)[3]; R_RATELIMIT(0.00)[to_ip_from(RLck8brw5hxmszoarioc7838it),to(RLpnp1psq57oqao6ocwdpbxen9)]; FREEMAIL_ENVRCPT(0.00)[gmail.com] X-Spam-Flag: NO X-Spam-Score: -5.30 X-Spam-Level: Track metadata bhs for an inode in fs-private part of the inode. Signed-off-by: Jan Kara --- fs/minix/dir.c | 2 +- fs/minix/file.c | 10 +++++++++- fs/minix/inode.c | 6 ++++-- fs/minix/itree_common.c | 11 +++++++---- fs/minix/minix.h | 3 +++ 5 files changed, 24 insertions(+), 8 deletions(-) diff --git a/fs/minix/dir.c b/fs/minix/dir.c index a74d000327fa..361d26d87d2e 100644 --- a/fs/minix/dir.c +++ b/fs/minix/dir.c @@ -23,7 +23,7 @@ const struct file_operations minix_dir_operations = { .llseek = generic_file_llseek, .read = generic_read_dir, .iterate_shared = minix_readdir, - .fsync = generic_buffers_fsync, + .fsync = minix_fsync, }; /* diff --git a/fs/minix/file.c b/fs/minix/file.c index 282b3cd1fea3..bc0be789343a 100644 --- a/fs/minix/file.c +++ b/fs/minix/file.c @@ -7,8 +7,16 @@ * minix regular file handling primitives */ +#include #include "minix.h" +int minix_fsync(struct file *file, loff_t start, loff_t end, int datasync) +{ + return generic_mmb_fsync(file, + &minix_i(file->f_mapping->host)->i_metadata_bhs, + start, end, datasync); +} + /* * We have mostly NULLs here: the current defaults are OK for * the minix filesystem. @@ -18,7 +26,7 @@ const struct file_operations minix_file_operations = { .read_iter = generic_file_read_iter, .write_iter = generic_file_write_iter, .mmap_prepare = generic_file_mmap_prepare, - .fsync = generic_buffers_fsync, + .fsync = minix_fsync, .splice_read = filemap_splice_read, }; diff --git a/fs/minix/inode.c b/fs/minix/inode.c index ab7c06efb139..adba14628d1b 100644 --- a/fs/minix/inode.c +++ b/fs/minix/inode.c @@ -49,9 +49,9 @@ static void minix_evict_inode(struct inode *inode) inode->i_size = 0; minix_truncate(inode); } else { - sync_mapping_buffers(&inode->i_data); + mmb_sync_buffers(&minix_i(inode)->i_metadata_bhs); } - invalidate_inode_buffers(inode); + mmb_invalidate_buffers(&minix_i(inode)->i_metadata_bhs); clear_inode(inode); if (!inode->i_nlink) minix_free_inode(inode); @@ -85,6 +85,8 @@ static struct inode *minix_alloc_inode(struct super_block *sb) ei = alloc_inode_sb(sb, minix_inode_cachep, GFP_KERNEL); if (!ei) return NULL; + mmb_init(&ei->i_metadata_bhs, &ei->vfs_inode.i_data); + return &ei->vfs_inode; } diff --git a/fs/minix/itree_common.c b/fs/minix/itree_common.c index dad131e30c05..c3cd2c75af9c 100644 --- a/fs/minix/itree_common.c +++ b/fs/minix/itree_common.c @@ -98,7 +98,7 @@ static int alloc_branch(struct inode *inode, *branch[n].p = branch[n].key; set_buffer_uptodate(bh); unlock_buffer(bh); - mark_buffer_dirty_inode(bh, inode); + mmb_mark_buffer_dirty(bh, &minix_i(inode)->i_metadata_bhs); parent = nr; } if (n == num) @@ -135,7 +135,8 @@ static inline int splice_branch(struct inode *inode, /* had we spliced it onto indirect block? */ if (where->bh) - mark_buffer_dirty_inode(where->bh, inode); + mmb_mark_buffer_dirty(where->bh, + &minix_i(inode)->i_metadata_bhs); mark_inode_dirty(inode); return 0; @@ -328,14 +329,16 @@ static inline void truncate (struct inode * inode) if (partial == chain) mark_inode_dirty(inode); else - mark_buffer_dirty_inode(partial->bh, inode); + mmb_mark_buffer_dirty(partial->bh, + &minix_i(inode)->i_metadata_bhs); free_branches(inode, &nr, &nr+1, (chain+n-1) - partial); } /* Clear the ends of indirect blocks on the shared branch */ while (partial > chain) { free_branches(inode, partial->p + 1, block_end(partial->bh), (chain+n-1) - partial); - mark_buffer_dirty_inode(partial->bh, inode); + mmb_mark_buffer_dirty(partial->bh, + &minix_i(inode)->i_metadata_bhs); brelse (partial->bh); partial--; } diff --git a/fs/minix/minix.h b/fs/minix/minix.h index 7e1f652f16d3..f2025c9b5825 100644 --- a/fs/minix/minix.h +++ b/fs/minix/minix.h @@ -19,6 +19,7 @@ struct minix_inode_info { __u16 i1_data[16]; __u32 i2_data[16]; } u; + struct mapping_metadata_bhs i_metadata_bhs; struct inode vfs_inode; }; @@ -57,6 +58,8 @@ unsigned long minix_count_free_blocks(struct super_block *sb); int minix_getattr(struct mnt_idmap *, const struct path *, struct kstat *, u32, unsigned int); int minix_prepare_chunk(struct folio *folio, loff_t pos, unsigned len); +struct mapping_metadata_bhs *minix_get_metadata_bhs(struct inode *inode); +int minix_fsync(struct file *file, loff_t start, loff_t end, int datasync); extern void V1_minix_truncate(struct inode *); extern void V2_minix_truncate(struct inode *); -- 2.51.0