From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Zorro Lang <zlang@redhat.com>,
linux-xfs@vger.kernel.org, Tal Zussman <tz2294@columbia.edu>,
axboe@kernel.dk, linux-block@vger.kernel.org
Subject: Re: [Bug][xfstests xfs/556] inconsistent {HARDIRQ-ON-W} -> {IN-HARDIRQ-W} usage
Date: Mon, 23 Mar 2026 08:22:31 -0700 [thread overview]
Message-ID: <20260323152231.GG6223@frogsfrogsfrogs> (raw)
In-Reply-To: <acDbFtQw0mom798e@infradead.org>
On Sun, Mar 22, 2026 at 11:17:58PM -0700, Christoph Hellwig wrote:
> On Fri, Mar 20, 2026 at 09:34:44AM -0700, Darrick J. Wong wrote:
> > --- a/fs/iomap/bio.c
> > +++ b/fs/iomap/bio.c
> > @@ -8,7 +8,15 @@
> > #include "internal.h"
> > #include "trace.h"
> >
> > -static void iomap_read_end_io(struct bio *bio)
> > +struct iomap_failed_bio {
> > + struct list_head io_list;
> > + struct bio *bio;
> > +};
>
> Between this and the blockdev dontcache work I really wish we could
> have a generic offload using a percpu lit and workqueue.
<shrug> For IO errors I don't think it's urgent, but yes it would be
very nice to have a single mechanism for "kick IO completion to a
workqueue" type things.
> Also I don't think we need the separate list here, a linked list using
> bi_next should be sufficient and avoid the allocation in the failure
> path.
For now, I'll change this patch to use a bio_list.
--D
next prev parent reply other threads:[~2026-03-23 15:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260319194303.efw4wcu7c4idhthz@doltdoltdolt>
[not found] ` <20260320163444.GE6223@frogsfrogsfrogs>
2026-03-23 6:17 ` [Bug][xfstests xfs/556] inconsistent {HARDIRQ-ON-W} -> {IN-HARDIRQ-W} usage Christoph Hellwig
2026-03-23 15:22 ` Darrick J. Wong [this message]
2026-03-23 21:00 ` [PATCH] iomap: fix lockdep complaint when reads fail Darrick J. Wong
2026-03-24 6:14 ` Christoph Hellwig
2026-03-25 0:16 ` Jens Axboe
2026-03-24 8:15 ` Christian Brauner
2026-03-24 17:06 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260323152231.GG6223@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tz2294@columbia.edu \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox