From: "Theodore Tso" <tytso@mit.edu>
To: Christoph Hellwig <hch@infradead.org>
Cc: Deepanshu Kartikey <kartikey406@gmail.com>,
axboe@kernel.dk, dvyukov@google.com, adilger.kernel@dilger.ca,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+fb32afec111a7d61b939@syzkaller.appspotmail.com
Subject: Re: [PATCH v2] loop: block changing lo_offset/lo_sizelimit on mounted device
Date: Tue, 31 Mar 2026 08:24:08 -0400 [thread overview]
Message-ID: <20260331122408.GB74409@macsyma-wired.lan> (raw)
In-Reply-To: <act2Kh8u2I5HPVlv@infradead.org>
On Tue, Mar 31, 2026 at 12:22:18AM -0700, Christoph Hellwig wrote:
>
> And I would not be surprised if this breaks something in blktests or
> xfstests as they heavily rely on resizing block devices. Did you
> do full runs of those? Especially with xfs and btrfs for xfstests
> as they do a lot more loop based tests?
Do we expect people to seriously be running with
!CONFIG_BLK_DEV_WRITE_MOUNTED? I view this as a syzkaller noise
suppression only. As I mentioned earlier this option will very likely
break grub.
I do think that we need to have a way of disabling write access on a
per-super or per-file system type basis, eventually. Perhaps we need
to get there sooner rather than later? Would that make you happier?
- Ted
next prev parent reply other threads:[~2026-03-31 12:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 5:46 [PATCH v2] loop: block changing lo_offset/lo_sizelimit on mounted device Deepanshu Kartikey
2026-03-31 7:22 ` Christoph Hellwig
2026-03-31 12:24 ` Theodore Tso [this message]
2026-03-31 15:02 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260331122408.GB74409@macsyma-wired.lan \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=axboe@kernel.dk \
--cc=dvyukov@google.com \
--cc=hch@infradead.org \
--cc=kartikey406@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+fb32afec111a7d61b939@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox