public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Jackie Liu <liu.yun@linux.dev>
To: axboe@kernel.dk, yukuai@fnnas.com
Cc: linux-block@vger.kernel.org
Subject: [PATCH 08/10] block: use kstrtol() instead of sscanf() in disk_events_poll_msecs_store()
Date: Wed,  1 Apr 2026 15:07:14 +0800	[thread overview]
Message-ID: <20260401070716.991-9-liu.yun@linux.dev> (raw)
In-Reply-To: <20260401070716.991-1-liu.yun@linux.dev>

From: Jackie Liu <liuyun01@kylinos.cn>

kstrtol() is the preferred way to parse a single integer from sysfs
input. It also makes the !count check unnecessary since kstrtol()
returns -EINVAL on empty or malformed strings.

Signed-off-by: Jackie Liu <liuyun01@kylinos.cn>
---
 block/disk-events.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/disk-events.c b/block/disk-events.c
index b1680d6a1027..b6233b0d5575 100644
--- a/block/disk-events.c
+++ b/block/disk-events.c
@@ -372,7 +372,7 @@ static ssize_t disk_events_poll_msecs_store(struct device *dev,
 	struct gendisk *disk = dev_to_disk(dev);
 	long intv;
 
-	if (!count || !sscanf(buf, "%ld", &intv))
+	if (kstrtol(buf, 10, &intv))
 		return -EINVAL;
 
 	if (intv < 0 && intv != -1)
-- 
2.51.1


  parent reply	other threads:[~2026-04-01  7:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-01  7:07 [PATCH 00/10] block: sysfs cleanup for deprecated API usage Jackie Liu
2026-04-01  7:07 ` [PATCH 01/10] block: convert to sysfs_emit() in blk_ia_range show() Jackie Liu
2026-04-01  7:07 ` [PATCH 02/10] block: convert blk-mq hw sysfs show to sysfs_emit/sysfs_emit_at Jackie Liu
2026-04-01  7:07 ` [PATCH 03/10] block: convert disk events " Jackie Liu
2026-04-01  7:07 ` [PATCH 04/10] block: convert partition sysfs show to sysfs_emit() Jackie Liu
2026-04-01  7:07 ` [PATCH 05/10] block: convert part_timeout_show() " Jackie Liu
2026-04-01  7:07 ` [PATCH 06/10] block: convert kyber latency show " Jackie Liu
2026-04-01  7:07 ` [PATCH 07/10] block: convert bfq_var_show() " Jackie Liu
2026-04-01  7:07 ` Jackie Liu [this message]
2026-04-01  7:07 ` [PATCH 09/10] block: replace simple_strtoul() with kstrtoint() in part_timeout_store() Jackie Liu
2026-04-01  7:07 ` [PATCH 10/10] block: replace sscanf() with kstrtoint() in part_fail_store() Jackie Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260401070716.991-9-liu.yun@linux.dev \
    --to=liu.yun@linux.dev \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=yukuai@fnnas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox