public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] blk-crypto: fix name of the bio completion callback
@ 2026-04-01 13:58 Christoph Hellwig
  2026-04-01 20:19 ` Eric Biggers
  2026-04-02 13:09 ` Jens Axboe
  0 siblings, 2 replies; 3+ messages in thread
From: Christoph Hellwig @ 2026-04-01 13:58 UTC (permalink / raw)
  To: axboe; +Cc: linux-block, ebiggers

Fix a simple naming issue in the documentation: the completion
routine is called bi_end_io and not bi_complete.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 Documentation/block/inline-encryption.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/block/inline-encryption.rst b/Documentation/block/inline-encryption.rst
index 7e0703a12dfb..cae23949a626 100644
--- a/Documentation/block/inline-encryption.rst
+++ b/Documentation/block/inline-encryption.rst
@@ -153,7 +153,7 @@ blk-crypto-fallback completes the original bio.  If the original bio is too
 large, multiple bounce bios may be required; see the code for details.
 
 For decryption, blk-crypto-fallback "wraps" the bio's completion callback
-(``bi_complete``) and private data (``bi_private``) with its own, unsets the
+(``bi_end_io``) and private data (``bi_private``) with its own, unsets the
 bio's encryption context, then submits the bio.  If the read completes
 successfully, blk-crypto-fallback restores the bio's original completion
 callback and private data, then decrypts the bio's data in-place using the
-- 
2.47.3


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] blk-crypto: fix name of the bio completion callback
  2026-04-01 13:58 [PATCH] blk-crypto: fix name of the bio completion callback Christoph Hellwig
@ 2026-04-01 20:19 ` Eric Biggers
  2026-04-02 13:09 ` Jens Axboe
  1 sibling, 0 replies; 3+ messages in thread
From: Eric Biggers @ 2026-04-01 20:19 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: axboe, linux-block

On Wed, Apr 01, 2026 at 03:58:51PM +0200, Christoph Hellwig wrote:
> Fix a simple naming issue in the documentation: the completion
> routine is called bi_end_io and not bi_complete.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  Documentation/block/inline-encryption.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Biggers <ebiggers@kernel.org>

- Eric

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] blk-crypto: fix name of the bio completion callback
  2026-04-01 13:58 [PATCH] blk-crypto: fix name of the bio completion callback Christoph Hellwig
  2026-04-01 20:19 ` Eric Biggers
@ 2026-04-02 13:09 ` Jens Axboe
  1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2026-04-02 13:09 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: linux-block, ebiggers


On Wed, 01 Apr 2026 15:58:51 +0200, Christoph Hellwig wrote:
> Fix a simple naming issue in the documentation: the completion
> routine is called bi_end_io and not bi_complete.

Applied, thanks!

[1/1] blk-crypto: fix name of the bio completion callback
      commit: 4e56428ed4782e9e1356875af8e714b24c5a8783

Best regards,
-- 
Jens Axboe




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-04-02 13:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-01 13:58 [PATCH] blk-crypto: fix name of the bio completion callback Christoph Hellwig
2026-04-01 20:19 ` Eric Biggers
2026-04-02 13:09 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox