Re: [PATCH v3 02/12] block/bdev: Annotate the blk_holder_ops callback invocations

Christoph Hellwig
2026-04-09T06:42:24Z

On Thu, Apr 02, 2026 at 11:39:34AM -0700, Bart Van Assche wrote:
> The four callback functions in blk_holder_ops all release the
> bd_holder_lock. Add __release() annotations where appropriate to prepare
> for enabling thread-safety analysis. Explicit __release() annotations have
> been added since Clang does not support adding a __releases() annotation
> to a function pointer.

I have to say I still hate this with passion. If we can't propagate
the lock context over function pointers it isn't ready for prime time
unfortunately, as much as I'm looking forward to it.