From: Peter Zijlstra <peterz@infradead.org>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Michael Wu <michael@allwinnertech.com>,
Xiaosen He <xiaosen.he@oss.qualcomm.com>,
Tejun Heo <tj@kernel.org>, Thomas Gleixner <tglx@kernel.org>
Subject: Re: [PATCH] sched: flush plug in schedule_preempt_disabled() to prevent deadlock
Date: Tue, 12 May 2026 18:49:47 +0200 [thread overview]
Message-ID: <20260512164947.GA2677887@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <agNLCof3zO5-QAo9@fedora>
On Tue, May 12, 2026 at 11:45:14PM +0800, Ming Lei wrote:
> > io_schedule()
> > token = io_schedule_prepare()
> > blk_flush_plug(current->plug, true);
> > schedule()
> > if (!task_is_running(tsk))
> > sched_submit_work()
> > blk_flush_plug(tsk->plug, true);
> >
> > Why isn't the one in sched_submit_work() sufficient? This thing either
> > needs a comment justifying its existence, or get removed.
> If io_schedule_prepare() can be called in every iowait context, looks
> blk_flush_plug() from sched_submit_work() may be removed.
No, the other way around. I don't see the point of having the one in
io_schedule_prepare(), since we'll hit the one in sched_submit_work().
next prev parent reply other threads:[~2026-05-12 16:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 8:59 [PATCH] sched: flush plug in schedule_preempt_disabled() to prevent deadlock Ming Lei
2026-05-12 12:04 ` Peter Zijlstra
2026-05-12 12:40 ` Peter Zijlstra
2026-05-12 15:45 ` Ming Lei
2026-05-12 16:49 ` Peter Zijlstra [this message]
2026-05-12 16:53 ` Peter Zijlstra
2026-05-12 17:16 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260512164947.GA2677887@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=axboe@kernel.dk \
--cc=juri.lelli@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@allwinnertech.com \
--cc=mingo@redhat.com \
--cc=tglx@kernel.org \
--cc=tj@kernel.org \
--cc=tom.leiming@gmail.com \
--cc=vincent.guittot@linaro.org \
--cc=xiaosen.he@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox