From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@meta.com>
Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
axboe@kernel.dk, hch@lst.de, nilay@linux.ibm.com,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH] block, nvme: export and use passthrough stats
Date: Mon, 25 May 2026 09:32:19 +0200 [thread overview]
Message-ID: <20260525073219.GA5305@lst.de> (raw)
In-Reply-To: <20260522151537.1509784-1-kbusch@meta.com>
On Fri, May 22, 2026 at 08:15:37AM -0700, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> So stacking drivers can also report passthrough workloads through
> iostat.
Except that this patch also wires it up in nvme. So please split
it and write proper commit messages for both parts.
> +static inline bool blk_rq_passthrough_stats(struct request *req)
> +{
And maybe add a kerneldoc comment now that this is public.
next prev parent reply other threads:[~2026-05-25 7:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 15:15 [PATCH] block, nvme: export and use passthrough stats Keith Busch
2026-05-23 18:54 ` Nilay Shroff
2026-05-25 7:32 ` Christoph Hellwig [this message]
2026-05-25 7:35 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2026-05-28 0:58 Keith Busch
2026-05-28 1:00 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260525073219.GA5305@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nilay@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox