From: Christoph Hellwig <hch@lst.de>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] block: avoid potential deadlock on zone revalidation failure
Date: Thu, 25 Jun 2026 13:52:32 +0200 [thread overview]
Message-ID: <20260625115232.GC18076@lst.de> (raw)
In-Reply-To: <20260625062824.2013244-1-dlemoal@kernel.org>
On Thu, Jun 25, 2026 at 03:28:24PM +0900, Damien Le Moal wrote:
[very long lockdep trace]
> + /*
> + * We may already have a zone write plug workqueue as this function may
> + * be called after disk_free_zone_resources(), which does not destroy
> + * the workqueue (the zone write plugs workqueue is destroyed at
> + * disk_release() time).
> + */
> + if (!disk->zone_wplugs_wq) {
Can't we just allocate this at add_disk time instead of the magic NULL
check here to mirror the freeing side?
prev parent reply other threads:[~2026-06-25 11:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-25 6:28 [PATCH] block: avoid potential deadlock on zone revalidation failure Damien Le Moal
2026-06-25 11:52 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260625115232.GC18076@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox