From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20E533F39FE; Fri, 26 Jun 2026 11:55:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782474927; cv=none; b=Ip3n364Lxn7ZSvlXvzwzLAIldx/iixzmhlGcNsWd95APGDzm5QxqvXszgUDztGQTdp/u5w5FqrsVf+GkfuoylNciM8dl+Zek9OPd26upFYtCoJ20Ld4akwJCjLS24pWGOiZD44+lYqA/L3BBIPWoCgFQkNW08jH/b4bhoNT9f4g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782474927; c=relaxed/simple; bh=E7vYmMpa3Blg0v5cZJiXscL/77ngvQZ+huTeto0B0VU=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=i88HLvm8C4x+jQi3bqx9hGIhSmKdZREITAuJ38FoDSu3bNdXPyA4hcL+RsNBDJelNTQouHObLqEpyr69QQbPplIEqTRgVY2IWoZ9ytr9xuCi+ucSLLpqlR4RhWvYRUDkcGTvirosBJSNh3n6y7FiiOm7ITGMMwHKRNeiUTYjGvQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=h4Jg9M/U; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="h4Jg9M/U" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76CE51F000E9; Fri, 26 Jun 2026 11:55:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782474919; bh=0xiV+dAAxQ5vuqeqEAMc+CD5ycesoV1kpDoh9yHprIU=; h=From:Subject:Date:To:Cc; b=h4Jg9M/UKVwRNvYhWQiT1cEkAyfeFcMM5R+fe6g6gu9Mlt4cjsroQrqZ+lWRdZQAK Wzg5waEkzBWpIcm+CyRXYqcHKdfT69vzCrDLSb7bQ7Y4HcjS5H/49soinRVq/BjjEQ /+5Rxh2roL2vNQe/Uv3DLAbJ4cLpL80P6mw3JJMmdYHtoqG8GrqcqdKC28bCVCvxOD vP6w9QodCwphADRjfK1ikSkV1+kT0H790ArfIcs7Twqgep2yHcPdmnzAHJQ9nNxqHe sAS96IuIxsY091w9TGVjJ6L4IHfQhWvmkaobtj5DMMGT7RuPy5ddjdsLKcaBHz8M+f dKvm2g+k4+YpA== From: Andreas Hindborg Subject: [PATCH v19 0/8] rust: add `Ownable` trait and `Owned` type Date: Fri, 26 Jun 2026 13:53:57 +0200 Message-Id: <20260626-unique-ref-v19-0-2607ca88dfdf@kernel.org> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-B4-Tracking: v=1; b=H4sIAFVoPmoC/2XOTW7CMBAF4Ksgr+tq/G+z6j0Qi9iegEWVgFOiV ih374QNCVnOG31v5sEGrAUHtt89WMWxDKXvaBDhY8fSuelOyEumgEmQBhQYfu/K7Y68YstlaFO 2zrQBAyNwpbD8PtsOR5rPZfjp69+zfBR6juceCxL0sod2HLhwKcqAsUkxfl2wdvj92dcTm5tGY RZawlob0j4ozN5GsClttV3qt9uWdJKiaVMUwme11e6l7fvnjrSLOqksg4IYttovtDRr7UlrBBu NDzZrt9LTNP0DkTMw6KABAAA= X-Change-ID: 20250305-unique-ref-29fcd675f9e9 To: Danilo Krummrich , Lorenzo Stoakes , Vlastimil Babka , "Liam R. Howlett" , Uladzislau Rezki , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Alice Ryhl , Trevor Gross , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , =?utf-8?q?Onur_=C3=96zkan?= , Lyude Paul , Greg Kroah-Hartman , =?utf-8?q?Arve_Hj=C3=B8nnev=C3=A5g?= , Todd Kjos , Christian Brauner , Carlos Llamas , "Rafael J. Wysocki" , Dave Ertman , Ira Weiny , Leon Romanovsky , Paul Moore , Serge Hallyn , David Airlie , Simona Vetter , Alexander Viro , Jan Kara , Igor Korotin , Viresh Kumar , Nishanth Menon , Stephen Boyd , Bjorn Helgaas , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Pavel Tikhomirov , Michal Wilczynski Cc: Andreas Hindborg , Philipp Stanner , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, driver-core@lists.linux.dev, linux-block@vger.kernel.org, linux-security-module@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fsdevel@vger.kernel.org, linux-pm@vger.kernel.org, linux-pci@vger.kernel.org, linux-pwm@vger.kernel.org, Asahi Lina , Oliver Mangold , Viresh Kumar , Boqun Feng , Asahi Lina , Igor Korotin , Andreas Hindborg X-Mailer: b4 0.16-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=11869; i=a.hindborg@kernel.org; h=from:subject:message-id; bh=E7vYmMpa3Blg0v5cZJiXscL/77ngvQZ+huTeto0B0VU=; b=owEBbQKS/ZANAwAKAfpQKQiqxb3QAcsmYgBqPmha2IDTSBK23gO13hIw+A3+jNWRKjZfcQo8A 9ApbajyvQaJAjMEAAEKAB0WIQRXitnI2WZ2JirAaob6UCkIqsW90AUCaj5oWgAKCRD6UCkIqsW9 0DL6EACiTIa7BDo2kgjlDnq6fEPqSGkq8el2ce6FarJlXZVr/w5/BPyz2TaGkAMj0yWiHMUg6Nb hkOYYGHFaGsXgdUP/MErMMsyksC0aL2/K9F9I6NKfbIRNErlbqVPrk5bbza/I3gz4jb1lg7E7Gt MbyX+xDmi+ID9nxoWl3f3rV89DAAiwJVETwUdNljpudFn7pkcBwlgeYvV7NCwJnr3/5Uht5LmoW IVYDkM/MNH3Er9S55Kq6v5RcH5K+qPuEwjE9cuCorwIy78N+vcZZN2F01ITul11qlkjr87F/JdF bDCqzbPU+Tlui3RNOIS5m96pR69cunSSm0mbEhzHvAhSOLoKJkOLR9ZqVjG97pfOmN8oGTjZK/e 4f9LQlfpPtpFBRVLojzT0WaRFtCodhDT4uPZrbBH1IZfRGI5IOlXTScMvtPCVsTGRVWfAHSIDZI /m2kn739pJ39HWPa2eaS7xmgfKZbTWpmXa0fTAi9t0GN1Bs8Xq13m75SABWu/Z5jhLIGgtUv+XA UcBfLmvKYY1u0UVRVB/yv/ghelxTjPcd+ThO3CPrCNdaQWnFyB2cYHBJreM2OpSyS2hiXhQWUs0 nj7u+AmGUIWUvsNiHkwAWFBIg4EK2PsGRS/HdzHRJDJ5tIK6NYRogqqH1rvNocEroyXGQkhrxdj mow336gDKj6kSQA== X-Developer-Key: i=a.hindborg@kernel.org; a=openpgp; fpr=3108C10F46872E248D1FB221376EB100563EF7A7 Add a new trait `Ownable` and type `Owned` for types that specify their own way of performing allocation and destruction. This is useful for types from the C side. Implement `ForeignOwnable` for `Owned`. Convert `Page` to be `Ownable` and add a `from_raw` method. Add the trait `OwnableRefCounted` that allows conversion between `ARef` and `Owned`. This is analogous to conversion between `Arc` and `UniqueArc`. Patches 1-4 implement `Ownable` and applies it to `Page`. These patches can be merged on their own. Patches 5-7 add `Ownable` -> `ARef` interop and can be merged later if consensus on their shape cannot be reached. Signed-off-by: Andreas Hindborg --- Changes in v19: - Update `workqueue.rs` and the `aref` module docs to use `RefCounted` instead of `AlwaysRefCounted` (Sashiko). - Remove the default `OwnableRefCounted::into_shared` implementation to keep the trait safe (Sashiko). - Fix the `ARef` rustdoc link (Sashiko). - Reuse `Owned::into_raw`/`from_raw` in the `ForeignOwnable` implementation (Gary). - Link to v18: https://msgid.link/20260625-unique-ref-v18-0-4e06b5896d47@kernel.org Changes in v18: - Rebase on `rust-next` (2026-06-24). - Drop the `'static` bound on `ForeignOwnable for Owned` (Gary). - Make `Ownable::release` take a raw pointer instead of `&mut self` (Alice, Sashiko). - Drop `types::ARef` re-export (Alice). - Drop unneeded `#[repr(transparent)]` on `Owned` (Gary). - Fix `FOREIGN_ALIGN` for `Owned` to report the pointee alignment (Sashiko). - Remove `BorrowedPage`; use `&Page` directly (Alice). - Update Rust Binder for the `Owned` conversion (Alice). - Update `pwm.rs` for the `RefCounted`/`AlwaysRefCounted` split (Sashiko). - Fix documentation nits: missing `// INVARIANT:` comments, stale `Page` docs, and a stray `mut` (Sashiko). - Expand the `use` statements touched by the rename patch to the multi-line style (Onur). - Link to v17: https://msgid.link/20260604-unique-ref-v17-0-7b4c3d2930b9@kernel.org Changes in v17: - Rebase on v7.1-rc2. - Reorder patches so that `Ownable` can merge without `OwnableRefCounted` (Alice). - Add `#[inline]` directives to short functions added by the series (Gary). - Link to v16: https://msgid.link/20260224-unique-ref-v16-0-c21afcb118d3@kernel.org Changes in v16: - Simplify pointer to reference cast in `Page::from_raw`. - Use `NonNull` rather than `Owned` for `BorrowedPage` internals. - Use "convertible to reference" wording when converting pointers to references. - Fix formatting for `Page::from_raw` docs. - Leave imports alone when adding safety comment to aref example. - Use `KBox::into_nonnull` for examples. - Add patch for `KBox::into_nonnull`. - Change invariants and safety comments of `Ownable` and make the trait safe. - Make `Ownable::release` take a mutable reference. - Fix error handling in example for `Ownable` - Link to v15: https://msgid.link/20260220-unique-ref-v15-0-893ed86b06cc@kernel.org Changes in v15: - Update series with original SoB's. - Rename `AlwaysRefCounted` in `kernel::usb`. - Rename `Owned::get_pin_mut` to `Owned::as_pin_mut`. - Link to v14: https://msgid.link/20260204-unique-ref-v14-0-17cb29ebacbb@kernel.org Changes in v14: - Rebase on v6.19-rc7. - Rewrite cover letter. - Update documentation and safety comments based on v13 feedback. - Update commit messages. - Reorder implementation blocks in owned.rs. - Update example in owned.rs to use try operator rather than `expect`. - Reformat use statements. - Add patch: rust: page: convert to `Ownable`. - Add patch: rust: implement `ForeignOwnable` for `Owned`. - Add patch: rust: page: add `from_raw()`. - Link to v13: https://lore.kernel.org/r/20251117-unique-ref-v13-0-b5b243df1250@pm.me Changes in v13: - Rebase onto v6.18-rc1 (Andreas's work). - Documentation and style fixes contributed by Andreas - Link to v12: https://lore.kernel.org/r/20251001-unique-ref-v12-0-fa5c31f0c0c4@pm.me Changes in v12: - - Rebase onto v6.17-rc1 (Andreas's work). - moved kernel/types/ownable.rs to kernel/owned.rs - Drop OwnableMut, make DerefMut depend on Unpin instead. I understood ML discussion as that being okay, but probably needs further scrunity. - Lots of more documentation changes suggested by reviewers. - Usage example for Ownable/Owned. - Link to v11: https://lore.kernel.org/r/20250618-unique-ref-v11-0-49eadcdc0aa6@pm.me Changes in v11: - Rework of documentation. I tried to honor all requests for changes "in spirit" plus some clearifications and corrections of my own. - Dropping `SimpleOwnedRefCounted` by request from Alice, as it creates a potentially problematic blanket implementation (which a derive macro that could be created later would not have). - Dropping Miguel's "kbuild: provide `RUSTC_HAS_DO_NOT_RECOMMEND` symbol" patch, as it is not needed anymore after dropping `SimpleOwnedRefCounted`. (I can add it again, if it is considered useful anyway). - Link to v10: https://lore.kernel.org/r/20250502-unique-ref-v10-0-25de64c0307f@pm.me Changes in v10: - Moved kernel/ownable.rs to kernel/types/ownable.rs - Fixes in documentation / comments as suggested by Andreas Hindborg - Added Reviewed-by comment for Andreas Hindborg - Fix rustfmt of pid_namespace.rs - Link to v9: https://lore.kernel.org/r/20250325-unique-ref-v9-0-e91618c1de26@pm.me Changes in v9: - Rebase onto v6.14-rc7 - Move Ownable/OwnedRefCounted/Ownable, etc., into separate module - Documentation fixes to Ownable/OwnableMut/OwnableRefCounted - Add missing SAFETY documentation to ARef example - Link to v8: https://lore.kernel.org/r/20250313-unique-ref-v8-0-3082ffc67a31@pm.me Changes in v8: - Fix Co-developed-by and Suggested-by tags as suggested by Miguel and Boqun - Some small documentation fixes in Owned/Ownable patch - removing redundant trait constraint on DerefMut for Owned as suggested by Boqun Feng - make SimpleOwnedRefCounted no longer implement RefCounted as suggested by Boqun Feng - documentation for RefCounted as suggested by Boqun Feng - Link to v7: https://lore.kernel.org/r/20250310-unique-ref-v7-0-4caddb78aa05@pm.me Changes in v7: - Squash patch to make Owned::from_raw/into_raw public into parent - Added Signed-off-by to other people's commits - Link to v6: https://lore.kernel.org/r/20250310-unique-ref-v6-0-1ff53558617e@pm.me Changes in v6: - Changed comments/formatting as suggested by Miguel Ojeda - Included and used new config flag RUSTC_HAS_DO_NOT_RECOMMEND, thus no changes to types.rs will be needed when the attribute becomes available. - Fixed commit message for Owned patch. - Link to v5: https://lore.kernel.org/r/20250307-unique-ref-v5-0-bffeb633277e@pm.me Changes in v5: - Rebase the whole thing on top of the Ownable/Owned traits by Asahi Lina. - Rename AlwaysRefCounted to RefCounted and make AlwaysRefCounted a marker trait instead to allow to obtain an ARef from an &T, which (as Alice pointed out) is unsound when combined with UniqueRef/Owned. - Change the Trait design and naming to implement this feature, UniqueRef/UniqueRefCounted is dropped in favor of Ownable/Owned and OwnableRefCounted is used to provide the functions to convert between Owned and ARef. - Link to v4: https://lore.kernel.org/r/20250305-unique-ref-v4-1-a8fdef7b1c2c@pm.me Changes in v4: - Just a minor change in naming by request from Andreas Hindborg, try_shared_to_unique() -> try_from_shared(), unique_to_shared() -> into_shared(), which is more in line with standard Rust naming conventions. - Link to v3: https://lore.kernel.org/r/Z8Wuud2UQX6Yukyr@mango To: Danilo Krummrich To: Lorenzo Stoakes To: Vlastimil Babka To: "Liam R. Howlett" To: Uladzislau Rezki To: Miguel Ojeda To: Boqun Feng To: Gary Guo To: Björn Roy Baron To: Benno Lossin To: Andreas Hindborg To: Alice Ryhl To: Trevor Gross To: Daniel Almeida To: Tamir Duberstein To: Alexandre Courbot To: Onur Özkan To: Lyude Paul To: Greg Kroah-Hartman To: Arve Hjønnevåg To: Todd Kjos To: Christian Brauner To: Carlos Llamas To: "Rafael J. Wysocki" To: Dave Ertman To: Ira Weiny To: Leon Romanovsky To: Paul Moore To: Serge Hallyn To: David Airlie To: Simona Vetter To: Alexander Viro To: Jan Kara To: Igor Korotin To: Viresh Kumar To: Nishanth Menon To: Stephen Boyd To: Bjorn Helgaas To: Krzysztof Wilczyński To: Pavel Tikhomirov To: Michal Wilczynski Cc: Philipp Stanner Cc: rust-for-linux@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org Cc: driver-core@lists.linux.dev Cc: linux-block@vger.kernel.org Cc: linux-security-module@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: linux-fsdevel@vger.kernel.org Cc: linux-pm@vger.kernel.org Cc: linux-pci@vger.kernel.org Cc: linux-pwm@vger.kernel.org --- Andreas Hindborg (3): rust: alloc: add `KBox::into_non_null` rust: implement `ForeignOwnable` for `Owned` rust: page: add `from_raw()` Asahi Lina (2): rust: types: Add Ownable/Owned types rust: page: convert to `Ownable` Oliver Mangold (3): rust: rename `AlwaysRefCounted` to `RefCounted`. rust: Add missing SAFETY documentation for `ARef` example rust: Add `OwnableRefCounted` drivers/android/binder/page_range.rs | 10 +- rust/kernel/alloc/allocator.rs | 19 +- rust/kernel/alloc/allocator/iter.rs | 6 +- rust/kernel/alloc/kbox.rs | 9 + rust/kernel/auxiliary.rs | 10 +- rust/kernel/block/mq/request.rs | 19 +- rust/kernel/cred.rs | 16 +- rust/kernel/device.rs | 12 +- rust/kernel/device/property.rs | 11 +- rust/kernel/drm/device.rs | 9 +- rust/kernel/drm/gem/mod.rs | 16 +- rust/kernel/fs/file.rs | 23 ++- rust/kernel/i2c.rs | 13 +- rust/kernel/lib.rs | 1 + rust/kernel/mm.rs | 22 ++- rust/kernel/mm/mmput_async.rs | 12 +- rust/kernel/opp.rs | 16 +- rust/kernel/owned.rs | 373 +++++++++++++++++++++++++++++++++++ rust/kernel/page.rs | 136 +++++-------- rust/kernel/pci.rs | 10 +- rust/kernel/pid_namespace.rs | 15 +- rust/kernel/platform.rs | 10 +- rust/kernel/pwm.rs | 12 +- rust/kernel/sync/aref.rs | 84 +++++--- rust/kernel/task.rs | 13 +- rust/kernel/types.rs | 12 ++ rust/kernel/usb.rs | 17 +- rust/kernel/workqueue.rs | 8 +- 28 files changed, 728 insertions(+), 186 deletions(-) --- base-commit: 43a393185e33e573a374c1d4f7ddf6481484ef8d change-id: 20250305-unique-ref-29fcd675f9e9 Best regards, -- Andreas Hindborg