From: Christoph Hellwig <hch@lst.de>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
axboe@kernel.dk, linux-block@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-aio@kvack.org,
linux-kernel@vger.kernel.org, io-uring@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] block: split out a new blk_plug.h helper
Date: Mon, 6 Jul 2026 11:54:07 +0200 [thread overview]
Message-ID: <20260706095407.GA4420@lst.de> (raw)
In-Reply-To: <f389a101-2af1-4b18-a74b-031e6c1899bd@kernel.org>
On Mon, Jul 06, 2026 at 04:04:48PM +0900, Damien Le Moal wrote:
> > +#include <linux/sched.h>
>
> struct blk_plug_cb has a list_head. So maybe also add
>
> #include <linux/types.h>
>
> ?
That already gets pulled in.
> > +
> > +struct blk_plug_cb;
>
> Maybe add "struct request;" here too ?
No need for type forward declarations when the types are only used
for pointers in structs (or as pointer variables). They are needed
only when pointers to the type are used in prototypes.
next prev parent reply other threads:[~2026-07-06 9:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 4:11 [PATCH] block: split out a new blk_plug.h helper Christoph Hellwig
2026-07-06 6:38 ` Johannes Thumshirn
2026-07-06 6:45 ` Christoph Hellwig
2026-07-06 6:47 ` Johannes Thumshirn
2026-07-06 7:04 ` Damien Le Moal
2026-07-06 9:54 ` Christoph Hellwig [this message]
2026-07-06 13:09 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260706095407.GA4420@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=io-uring@vger.kernel.org \
--cc=linux-aio@kvack.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox