From: Yang Erkun <yangerkun@huawei.com>
To: josef@toxicpanda.com, axboe@kernel.dk, hch@lst.de, yukuai@kernel.org
Cc: yi.zhang@huawei.com, chengzhihao1@huawei.com,
echo.chenlin@huawei.com, leo.lilong@huaweicloud.com,
wangkefeng.wang@huawei.com, yangerkun@huawei.com,
linux-block@vger.kernel.org, nbd@other.debian.org
Subject: [PATCH v3 6/6] nbd: add nr_hw_queues module parameter for pre-created devices
Date: Mon, 13 Jul 2026 14:56:44 +0800 [thread overview]
Message-ID: <20260713065644.1637594-7-yangerkun@huawei.com> (raw)
In-Reply-To: <20260713065644.1637594-1-yangerkun@huawei.com>
Previous commit can help remove all freeze for netlink newly created nbd
device. But for the devices pre-created at module load(nbds_max default
as 16), the nr_hw_queues was setting default as 1, then ioctl/netlink
path will set the real connection count, and blk_mq_update_nr_hw_queues
in nbd_start_device will introduce freeze.
Add an nr_hw_queues module parameter so that users who know their
expected connection count can pre-created devices with the right queue
count to avoid this freeze too.
Signed-off-by: Yang Erkun <yangerkun@huawei.com>
---
drivers/block/nbd.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 2c7b09c70da2..f918c9efa9b2 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -166,6 +166,7 @@ static struct dentry *nbd_dbg_dir;
static unsigned int nbds_max = 16;
static int max_part = 16;
+static int nr_hw_queues = 1;
static int part_shift;
static int nbd_dev_dbg_init(struct nbd_device *nbd);
@@ -2752,8 +2753,10 @@ static int __init nbd_init(void)
}
nbd_dbg_init();
+ if (nr_hw_queues < 1)
+ nr_hw_queues = 1;
for (i = 0; i < nbds_max; i++)
- nbd_dev_add(i, 1, 1);
+ nbd_dev_add(i, 1, nr_hw_queues);
return 0;
}
@@ -2814,3 +2817,6 @@ module_param(nbds_max, int, 0444);
MODULE_PARM_DESC(nbds_max, "number of network block devices to initialize (default: 16)");
module_param(max_part, int, 0444);
MODULE_PARM_DESC(max_part, "number of partitions per device (default: 16)");
+module_param(nr_hw_queues, int, 0444);
+MODULE_PARM_DESC(nr_hw_queues,
+"number of hardware queues for devices pre-created at module load (default: 1). ");
--
2.52.0
next prev parent reply other threads:[~2026-07-13 7:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 6:56 [PATCH v3 0/6] nbd: eliminate queue freeze/unfreeze overhead in connection setup Yang Erkun
2026-07-13 6:56 ` [PATCH v3 1/6] nbd: simplify find_fallback() by removing redundant logic Yang Erkun
2026-07-13 6:56 ` [PATCH v3 2/6] nbd: disallow NBD_SET_SOCK on an active device Yang Erkun
2026-07-22 3:03 ` yu kuai
2026-07-22 6:12 ` yangerkun
2026-07-13 6:56 ` [PATCH v3 3/6] nbd: remove queue freeze in nbd_add_socket Yang Erkun
2026-07-22 3:17 ` yu kuai
2026-07-22 6:35 ` yu kuai
2026-07-22 8:45 ` yangerkun
2026-07-22 9:20 ` yangerkun
2026-07-13 6:56 ` [PATCH v3 4/6] nbd: set nr_hw_queues at device creation to skip queue freeze Yang Erkun
2026-07-22 3:38 ` yu kuai
2026-07-23 1:09 ` yangerkun
2026-07-13 6:56 ` [PATCH v3 5/6] nbd: skip queue freeze when setting size at device startup Yang Erkun
2026-07-22 3:49 ` yu kuai
2026-07-23 1:22 ` yangerkun
2026-07-13 6:56 ` Yang Erkun [this message]
2026-07-22 3:53 ` [PATCH v3 6/6] nbd: add nr_hw_queues module parameter for pre-created devices yu kuai
2026-07-23 1:24 ` yangerkun
2026-07-21 8:41 ` [PATCH v3 0/6] nbd: eliminate queue freeze/unfreeze overhead in connection setup yangerkun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260713065644.1637594-7-yangerkun@huawei.com \
--to=yangerkun@huawei.com \
--cc=axboe@kernel.dk \
--cc=chengzhihao1@huawei.com \
--cc=echo.chenlin@huawei.com \
--cc=hch@lst.de \
--cc=josef@toxicpanda.com \
--cc=leo.lilong@huaweicloud.com \
--cc=linux-block@vger.kernel.org \
--cc=nbd@other.debian.org \
--cc=wangkefeng.wang@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox