Linux block layer
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Aaron Tomlin <atomlin@atomlin.com>
Cc: axboe@kernel.dk, kbusch@kernel.org, hch@lst.de, sagi@grimberg.me,
	mst@redhat.com, aacraid@microsemi.com,
	James.Bottomley@hansenpartnership.com,
	martin.petersen@oracle.com, liyihang9@h-partners.com,
	kashyap.desai@broadcom.com, sumit.saxena@broadcom.com,
	shivasharan.srikanteshwara@broadcom.com,
	chandrakanth.patil@broadcom.com, sathya.prakash@broadcom.com,
	sreekanth.reddy@broadcom.com,
	suganath-prabu.subramani@broadcom.com, ranjan.kumar@broadcom.com,
	jinpu.wang@cloud.ionos.com, tglx@kernel.org, mingo@redhat.com,
	peterz@infradead.org, juri.lelli@redhat.com,
	vincent.guittot@linaro.org, akpm@linux-foundation.org,
	maz@kernel.org, ruanjinjie@huawei.com, yphbchou0911@gmail.com,
	wagi@kernel.org, frederic@kernel.org, longman@redhat.com,
	chenridong@huawei.com, hare@suse.de, kch@nvidia.com,
	ming.lei@redhat.com, tom.leiming@gmail.com, steve@abita.co,
	sean@ashe.io, chjohnst@gmail.com, neelx@suse.com,
	mproche@gmail.com, nick.lange@gmail.com,
	marco.crivellari@suse.com, rishil1999@outlook.com,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v15 8/8] docs: add io_queue flag to isolcpus
Date: Wed, 15 Jul 2026 12:25:35 +0200	[thread overview]
Message-ID: <20260715102535.STkb5tE8@linutronix.de> (raw)
In-Reply-To: <20260521232956.553287-9-atomlin@atomlin.com>

On 2026-05-21 19:29:56 [-0400], Aaron Tomlin wrote:
> From: Daniel Wagner <wagi@kernel.org>
> 
> The io_queue flag informs multiqueue device drivers where to place
> hardware queues. Document this new flag in the isolcpus
> command-line argument description.
> 
> Signed-off-by: Daniel Wagner <wagi@kernel.org>
> Reviewed-by: Hannes Reinecke <hare@suse.de>
> [atomlin:
>     - Refined io_queue kernel parameter documentation
>     - Removed an inaccurate claim in the documentation stating
>       that io_queue takes precedence over managed_irq]
> Signed-off-by: Aaron Tomlin <atomlin@atomlin.com>

From high level, this looks like managed_irq with the exception that you
can limit the number of assigned interrupts while managed_irq is best
effort. Is this true or do I oversimplify something?

If so, can this be integrated?

> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 4d0f545fb3ec..fb828bb60b9e 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -2815,6 +2814,31 @@ Kernel parameters
>  			  housekeeping CPUs has no influence on those
>  			  queues.
>  
> +			io_queue
> +			  Applicable to managed IRQs only. Restrict
> +			  multiqueue hardware queue allocation to online
> +			  housekeeping CPUs. This guarantees that all
> +			  managed hardware completion interrupts are routed
> +			  exclusively to housekeeping cores, shielding
> +			  isolated CPUs from I/O interruptions even if they
> +			  initiated the request.
> +
> +			  Note: Using io_queue restricts the number of
> +			  allocated hardware queues to match the number of
> +			  housekeeping CPUs. This prevents MSI-X vector
> +			  exhaustion and forces isolated CPUs to share
> +			  submission queues.
> +
> +			  Note: Offlining housekeeping CPUs which serve
> +			  isolated CPUs will fail. The isolated CPUs must
> +			  be offlined before offlining the housekeeping
> +			  CPUs.
> +
> +			  Note: When I/O is submitted by an application on
> +			  an isolated CPU, the hardware completion
> +			  interrupt is handled entirely by a housekeeping
> +			  CPU.

This is named io_queue but it does affect I/O in general unless the
driver uses managed_irqs. This may or may not be clear to the user.
So the io_queue might not be the perfect name given that affects alles
devices in the system. We do have just I/O devices using it right now.

I think this still deserves an explanation in
Documentation/core-api/irq/managed_irq.rst like how to use it, what is
the expected outcome and how does it interact with the managed_irq
argument. Does it make sense to use both, is it exclusive or, what would
be the use case for both arguments.

>  			The format of <cpu-list> is described above.
>  
>  	iucv=		[HW,NET]
> -- 
> 2.51.0
> 

  reply	other threads:[~2026-07-15 10:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-21 23:29 [PATCH v15 0/8] blk: honor isolcpus configuration Aaron Tomlin
2026-05-21 23:29 ` [PATCH v15 1/8] scsi: aacraid: use block layer helpers to calculate num of queues Aaron Tomlin
2026-05-21 23:29 ` [PATCH v15 2/8] lib/group_cpus: remove dead !SMP code Aaron Tomlin
2026-05-21 23:29 ` [PATCH v15 3/8] lib/group_cpus: Add group_mask_cpus_evenly() Aaron Tomlin
2026-05-21 23:29 ` [PATCH v15 4/8] isolation: Introduce io_queue isolcpus type Aaron Tomlin
2026-05-21 23:29 ` [PATCH v15 5/8] blk-mq: use hk cpus only when isolcpus=io_queue is enabled Aaron Tomlin
2026-05-21 23:29 ` [PATCH v15 6/8] blk-mq: prevent offlining hk CPUs with associated online isolated CPUs Aaron Tomlin
2026-05-21 23:29 ` [PATCH v15 7/8] genirq/affinity: Restrict managed IRQ affinity to housekeeping CPUs Aaron Tomlin
2026-05-21 23:29 ` [PATCH v15 8/8] docs: add io_queue flag to isolcpus Aaron Tomlin
2026-07-15 10:25   ` Sebastian Andrzej Siewior [this message]
2026-05-26 16:05 ` [PATCH v15 0/8] blk: honor isolcpus configuration Daniel Wagner
2026-05-26 22:02   ` Aaron Tomlin
2026-06-17 11:01 ` Aaron Tomlin
2026-07-10 15:14   ` Sebastian Andrzej Siewior
2026-07-10 15:21 ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260715102535.STkb5tE8@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=aacraid@microsemi.com \
    --cc=akpm@linux-foundation.org \
    --cc=atomlin@atomlin.com \
    --cc=axboe@kernel.dk \
    --cc=chandrakanth.patil@broadcom.com \
    --cc=chenridong@huawei.com \
    --cc=chjohnst@gmail.com \
    --cc=frederic@kernel.org \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=jinpu.wang@cloud.ionos.com \
    --cc=juri.lelli@redhat.com \
    --cc=kashyap.desai@broadcom.com \
    --cc=kbusch@kernel.org \
    --cc=kch@nvidia.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liyihang9@h-partners.com \
    --cc=longman@redhat.com \
    --cc=marco.crivellari@suse.com \
    --cc=martin.petersen@oracle.com \
    --cc=maz@kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=mingo@redhat.com \
    --cc=mproche@gmail.com \
    --cc=mst@redhat.com \
    --cc=neelx@suse.com \
    --cc=nick.lange@gmail.com \
    --cc=peterz@infradead.org \
    --cc=ranjan.kumar@broadcom.com \
    --cc=rishil1999@outlook.com \
    --cc=ruanjinjie@huawei.com \
    --cc=sagi@grimberg.me \
    --cc=sathya.prakash@broadcom.com \
    --cc=sean@ashe.io \
    --cc=shivasharan.srikanteshwara@broadcom.com \
    --cc=sreekanth.reddy@broadcom.com \
    --cc=steve@abita.co \
    --cc=suganath-prabu.subramani@broadcom.com \
    --cc=sumit.saxena@broadcom.com \
    --cc=tglx@kernel.org \
    --cc=tom.leiming@gmail.com \
    --cc=vincent.guittot@linaro.org \
    --cc=wagi@kernel.org \
    --cc=yphbchou0911@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox