Linux block layer
 help / color / mirror / Atom feed
From: Yang Xiuwei <yangxiuwei@kylinos.cn>
To: efremov@linux.com
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
	syzbot+619e27617b2abe6b9b72@syzkaller.appspotmail.com,
	Yang Xiuwei <yangxiuwei@kylinos.cn>
Subject: Re: [PATCH] floppy: avoid NULL deref in reset_interrupt when cont is cleared
Date: Sat, 25 Jul 2026 11:40:07 +0800	[thread overview]
Message-ID: <20260725034007.2829360-1-yangxiuwei@kylinos.cn> (raw)
In-Reply-To: <27146f5c-5e57-44a6-bbe9-d910d8bbdfcf@linux.com>

Hi Denis,

On 24/07/2026 17:42, Denis Efremov (Oracle) wrote:
> It looks to me that this check closes the exact reported crash, but it doesn't
> fix the root cause of the problem. I think cont can be set here with a valid
> but unrelated continuation while stale reset work is inside result(). We need
> a more generic solution to close the bug here.

Agreed, this patch only avoids the oops and does not fix the underlying
lifetime issue. I went with the simple guard first as a minimal
workaround for the crash we hit.

I will look at a more complete fix for v2. Suggestions welcome if you
have a preferred approach.

Thanks,
Yang Xiuwei


      reply	other threads:[~2026-07-25  3:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-23  7:35 [PATCH] floppy: avoid NULL deref in reset_interrupt when cont is cleared Yang Xiuwei
2026-07-24 13:42 ` Denis Efremov (Oracle)
2026-07-25  3:40   ` Yang Xiuwei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260725034007.2829360-1-yangxiuwei@kylinos.cn \
    --to=yangxiuwei@kylinos.cn \
    --cc=axboe@kernel.dk \
    --cc=efremov@linux.com \
    --cc=linux-block@vger.kernel.org \
    --cc=syzbot+619e27617b2abe6b9b72@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox