From: Yu Kuai <yukuai@kernel.org>
To: tj@kernel.org, axboe@kernel.dk
Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, zhengqixing@huawei.com, hch@lst.de,
yizhou.tang@shopee.com, yukuai@fygo.io, nilay@linux.ibm.com
Subject: [PATCH v4 0/4] blk-cgroup: fix blkg list and policy data races
Date: Sun, 2 Aug 2026 19:25:21 +0800 [thread overview]
Message-ID: <20260802112525.3933753-6-yukuai@kernel.org> (raw)
In-Reply-To: <20260802112525.3933753-1-yukuai@kernel.org>
From: Yu Kuai <yukuai@fygo.io>
This set fix some problems that are reported long time ago with minimal changes,
the blkcg_mutex refactor I'm working on can fix these problems as well, but it's
complicated and may not land in this merge window. So I think this set should land
in this merge window first.
Patch 1 protects blkg_destroy_all()'s q->blkg_list walk with
blkcg_mutex.
Patches 2-3 fix races between blkcg_activate_policy() and concurrent
blkg destruction.
Patch 4 factors the policy data teardown loop into a helper after the
race fixes.
Changes since v3:
- Rebase on the latest for-7.3/block branch.
Changes since v2:
- Rebase on the latest block-7.2 branch.
Changes since v1:
- Drop the BFQ q->blkg_list patch because the current block tree already
has a stronger fix in commit 17b2d950a3c0 ("block, bfq: protect async
queue reset with blkcg locks").
- Add Reviewed-by tags from Tang Yizhou.
Yu Kuai (1):
blk-cgroup: protect q->blkg_list iteration in blkg_destroy_all() with
blkcg_mutex
Zheng Qixing (3):
blk-cgroup: fix race between policy activation and blkg destruction
blk-cgroup: skip dying blkg in blkcg_activate_policy()
blk-cgroup: factor policy pd teardown loop into helper
block/blk-cgroup.c | 65 +++++++++++++++++++++++++---------------------
1 file changed, 35 insertions(+), 30 deletions(-)
--
2.51.0
prev parent reply other threads:[~2026-08-02 11:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-02 11:25 [PATCH v4 0/4] blk-cgroup: fix blkg list and policy data races Yu Kuai
2026-08-02 11:25 ` [PATCH v4 1/4] blk-cgroup: protect q->blkg_list iteration in blkg_destroy_all() with blkcg_mutex Yu Kuai
2026-08-02 11:45 ` Tao Cui
2026-08-02 11:25 ` [PATCH v4 2/4] blk-cgroup: fix race between policy activation and blkg destruction Yu Kuai
2026-08-02 11:46 ` Tao Cui
2026-08-02 11:25 ` [PATCH v4 3/4] blk-cgroup: skip dying blkg in blkcg_activate_policy() Yu Kuai
2026-08-02 11:47 ` Tao Cui
2026-08-02 11:25 ` [PATCH v4 4/4] blk-cgroup: factor policy pd teardown loop into helper Yu Kuai
2026-08-02 11:25 ` Yu Kuai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260802112525.3933753-6-yukuai@kernel.org \
--to=yukuai@kernel.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nilay@linux.ibm.com \
--cc=tj@kernel.org \
--cc=yizhou.tang@shopee.com \
--cc=yukuai@fygo.io \
--cc=zhengqixing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox