From: Yang Erkun <yangerkun@huawei.com>
To: josef@toxicpanda.com, axboe@kernel.dk, hch@lst.de, yukuai@kernel.org
Cc: yi.zhang@huawei.com, chengzhihao1@huawei.com,
echo.chenlin@huawei.com, leo.lilong@huaweicloud.com,
wangkefeng.wang@huawei.com, huawei.libin@huawei.com,
leijitang@huawei.com, linux-block@vger.kernel.org,
nbd@other.debian.org
Subject: [PATCH v6 5/8] nbd: skip queue freeze when setting size at device startup
Date: Tue, 4 Aug 2026 16:39:19 +0800 [thread overview]
Message-ID: <20260804083922.1927105-6-yangerkun@huawei.com> (raw)
In-Reply-To: <20260804083922.1927105-1-yangerkun@huawei.com>
Commit 242a49e5c878 ("nbd: freeze the queue for queue limits updates")
added the freeze to keep in-flight commands from seeing
torn queue_limits. But at startup the capacity is still 0
(invalidate_disk cleared it) and the write cache is off (the previous
patch cleared it on disconnect, and nbd_set_size sets it back only after
the commit), so submit_bio_noacct() rejects any bio before it reaches
the driver and no I/O is in flight. Drop the freeze by checking
capacity and write cache state in nbd_set_size.
Signed-off-by: Yang Erkun <yangerkun@huawei.com>
---
drivers/block/nbd.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 8aeffc0eaaa1..66f1b3263b94 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -375,7 +375,11 @@ static int nbd_set_size(struct nbd_device *nbd, loff_t bytesize, loff_t blksize)
nbd_apply_limits(&lim, nbd->config->flags);
lim.logical_block_size = blksize;
lim.physical_block_size = blksize;
- error = queue_limits_commit_update_frozen(nbd->disk->queue, &lim);
+ /* No need freeze with 0 capacity and write cache disabled */
+ if (!get_capacity(nbd->disk) && !blk_queue_write_cache(nbd->disk->queue))
+ error = queue_limits_commit_update(nbd->disk->queue, &lim);
+ else
+ error = queue_limits_commit_update_frozen(nbd->disk->queue, &lim);
if (error)
return error;
--
2.52.0
next prev parent reply other threads:[~2026-08-04 8:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 8:39 [PATCH v6 0/8] nbd: eliminate queue freeze/unfreeze overhead in connection setup Yang Erkun
2026-08-04 8:39 ` [PATCH v6 1/8] nbd: simplify find_fallback() by removing redundant logic Yang Erkun
2026-08-04 8:39 ` [PATCH v6 2/8] nbd: disallow NBD_SET_SOCK on an active device Yang Erkun
2026-08-04 8:39 ` [PATCH v6 3/8] nbd: clear queue limits on disconnect Yang Erkun
2026-08-05 6:27 ` yangerkun
2026-08-04 8:39 ` [PATCH v6 4/8] nbd: remove queue freeze in nbd_add_socket Yang Erkun
2026-08-04 8:39 ` Yang Erkun [this message]
2026-08-04 8:39 ` [PATCH v6 6/8] nbd: factor out a nbd_genl_foreach_sock Yang Erkun
2026-08-04 8:39 ` [PATCH v6 7/8] nbd: remove queue freeze for newly created nbd from netlink path Yang Erkun
2026-08-04 8:39 ` [PATCH v6 8/8] nbd: add pre_defined_connections module parameter for pre-created devices Yang Erkun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260804083922.1927105-6-yangerkun@huawei.com \
--to=yangerkun@huawei.com \
--cc=axboe@kernel.dk \
--cc=chengzhihao1@huawei.com \
--cc=echo.chenlin@huawei.com \
--cc=hch@lst.de \
--cc=huawei.libin@huawei.com \
--cc=josef@toxicpanda.com \
--cc=leijitang@huawei.com \
--cc=leo.lilong@huaweicloud.com \
--cc=linux-block@vger.kernel.org \
--cc=nbd@other.debian.org \
--cc=wangkefeng.wang@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox