From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F208543BDB0 for ; Tue, 11 Aug 2026 10:59:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786445947; cv=none; b=frp2Ov8eMji39f4IwlrVKxhSFcNSJAR6lMSxvay/vQwsgue++xf+B3g3u24x5le/XQPNwqrFeEB5ujuc08VgWEK8i4e/qxK29XoI6Nvq5BQFiRX5SUqMimbxKc68R8bToIi5TutOX7HTS/a4YIFvMpV3nQp83PiCvLtb9L8SM9U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786445947; c=relaxed/simple; bh=SB+j7ZfwJ3CzkWzNnNcQUSlaFOGj/Xdv139K8aPIPdc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AbkgV+P5udRPX5ZU928Vb6FGnkd6eVxFHhSmxJhoqTxSxW+RATjmHlesqiEKxrYSPqnwJIO0Qi3+c0mgwx1yzCsxQd2QQ54B89WQclTYNxJz9JmgbHN8JwYUkSkCByaXtlGrMW/ruFu7/cHe8CZt5MZuuebnxlNKpEOE3Ec2edM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PJRfXfpr; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PJRfXfpr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2120E1F00A3E; Tue, 11 Aug 2026 10:59:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786445945; bh=zfKs0beCg5AQ90DjcI1QtUaNZ460ngcqqH225AAXGSQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=PJRfXfpr8Gs1Fck1IflF52kKvfS80zJ/3bzclL6otvq1B0iJwTI4HS2cuqgrlxvHT xoI6whduVUD6yF1BJBS3QjyO56lYa6FbuzJ6dbrA0AQuyfXZ9boL4scqAIYbbwegnX MdRCSvx4akfNhSZpTVWdEuE81xUkegj/Ub40cdLjdbGD8XFf5bTLt6tfTOYVlVJ803 M3wYZlKlw1cAzDvwgqiJWKcGKC2RkDMyhHmFpV2hG3upcEVDbGKCJMifRJFW/PBtQK +GZPzul0nBrYXcQkZys2/swNvPB2QfwTStE4Dwo79CISwKeFcb/w5h90K8DH6Ndg2W lC7JNTwEzknNg== From: Damien Le Moal To: Jens Axboe , linux-block@vger.kernel.org Cc: Christoph Hellwig Subject: [PATCH v3 02/13] block: refactor disk_revalidate_zone_resources() Date: Tue, 11 Aug 2026 19:58:41 +0900 Message-ID: <20260811105852.1245357-3-dlemoal@kernel.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260811105852.1245357-1-dlemoal@kernel.org> References: <20260811105852.1245357-1-dlemoal@kernel.org> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The function disk_revalidate_zone_resources() is misnamed as it does not revalidate anything but rather allocates the revalidation arguments and then calls disk_alloc_zone_resources() to initialize the disk zone resources if they are needed and not already allocated. Make this function less confusing by renaming it disk_init_revalidate_args() and moving the call to disk_alloc_zone_resources() into blk_revalidate_disk_zones(). As before, this function is only called if the zone resources are needed and not yet allocated. The initialization of the atomic nr_zone_wplugs is also moved to the function disk_init_zone_resources() so that this is done once and not on all revalidation. Signed-off-by: Damien Le Moal Reviewed-by: Hannes Reinecke Reviewed-by: Bart Van Assche Reviewed-by: Christoph Hellwig --- block/blk-zoned.c | 69 ++++++++++++++++++++++++----------------------- 1 file changed, 36 insertions(+), 33 deletions(-) diff --git a/block/blk-zoned.c b/block/blk-zoned.c index a9eafede4036..908944b55b59 100644 --- a/block/blk-zoned.c +++ b/block/blk-zoned.c @@ -1854,12 +1854,20 @@ static int disk_zone_wplugs_worker(void *data) void disk_init_zone_resources(struct gendisk *disk) { + atomic_set(&disk->nr_zone_wplugs, 0); spin_lock_init(&disk->zone_wplugs_hash_lock); spin_lock_init(&disk->zone_wplugs_list_lock); INIT_LIST_HEAD(&disk->zone_wplugs_list); init_completion(&disk->zone_wplugs_worker_bio_done); } +static unsigned int disk_get_nr_zones(struct gendisk *disk) +{ + struct queue_limits *lim = &disk->queue->limits; + + return DIV_ROUND_UP_ULL(get_capacity(disk), lim->chunk_sectors); +} + /* * For the size of a disk zone write plug hash table, use the size of the * zone write plug mempool, which is the maximum of the disk open zones and @@ -1869,13 +1877,21 @@ void disk_init_zone_resources(struct gendisk *disk) #define BLK_ZONE_WPLUG_MAX_HASH_BITS 9 #define BLK_ZONE_WPLUG_DEFAULT_POOL_SIZE 128 -static int disk_alloc_zone_resources(struct gendisk *disk, - unsigned int pool_size) +static int disk_alloc_zone_resources(struct gendisk *disk) { - unsigned int i; + struct queue_limits *lim = &disk->queue->limits; + unsigned int nr_zones = disk_get_nr_zones(disk); + unsigned int pool_size, i; int ret = -ENOMEM; - atomic_set(&disk->nr_zone_wplugs, 0); + /* + * If the device has no limit on the maximum number of open and active + * zones, use BLK_ZONE_WPLUG_DEFAULT_POOL_SIZE. + */ + pool_size = max(lim->max_open_zones, lim->max_active_zones); + if (!pool_size) + pool_size = min(BLK_ZONE_WPLUG_DEFAULT_POOL_SIZE, nr_zones); + disk->zone_wplugs_hash_bits = min(ilog2(pool_size) + 1, BLK_ZONE_WPLUG_MAX_HASH_BITS); @@ -2001,41 +2017,18 @@ struct blk_revalidate_zone_args { sector_t sector; }; -static int disk_revalidate_zone_resources(struct gendisk *disk, +static int disk_init_revalidate_args(struct gendisk *disk, struct blk_revalidate_zone_args *args) { - struct queue_limits *lim = &disk->queue->limits; - unsigned int pool_size; - int ret = 0; - args->disk = disk; - args->nr_zones = - DIV_ROUND_UP_ULL(get_capacity(disk), lim->chunk_sectors); + args->nr_zones = disk_get_nr_zones(disk); /* Cached zone conditions: 1 byte per zone */ args->zones_cond = kzalloc(args->nr_zones, GFP_NOIO); if (!args->zones_cond) return -ENOMEM; - if (!disk_need_zone_resources(disk)) - return 0; - - /* - * If the device has no limit on the maximum number of open and active - * zones, use BLK_ZONE_WPLUG_DEFAULT_POOL_SIZE. - */ - pool_size = max(lim->max_open_zones, lim->max_active_zones); - if (!pool_size) - pool_size = - min(BLK_ZONE_WPLUG_DEFAULT_POOL_SIZE, args->nr_zones); - - if (!disk->zone_wplugs_hash) { - ret = disk_alloc_zone_resources(disk, pool_size); - if (ret) - kfree(args->zones_cond); - } - - return ret; + return 0; } /* @@ -2328,11 +2321,21 @@ int blk_revalidate_disk_zones(struct gendisk *disk) } /* - * Ensure that all memory allocations in this context are done as if - * GFP_NOIO was specified. + * Allocate zone resources if they are needed and we have not done + * so yet, and initialize the revalidation arguments passed to report + * zones. Ensure that all memory allocations in this context are done as + * if GFP_NOIO was specified. */ noio_flag = memalloc_noio_save(); - ret = disk_revalidate_zone_resources(disk, &args); + if (disk_need_zone_resources(disk) && !disk->zone_wplugs_hash) { + ret = disk_alloc_zone_resources(disk); + if (ret) { + memalloc_noio_restore(noio_flag); + return ret; + } + } + + ret = disk_init_revalidate_args(disk, &args); if (ret) { memalloc_noio_restore(noio_flag); return ret; -- 2.55.0