From: Christoph Hellwig <hch@lst.de>
To: Kanchan Joshi <joshi.k@samsung.com>
Cc: brauner@kernel.org, hch@lst.de, djwong@kernel.org,
dgc@kernel.org, jack@suse.cz, cem@kernel.org, axboe@kernel.dk,
kbusch@kernel.org, ritesh.list@gmail.com,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-block@vger.kernel.org, gost.dev@samsung.com
Subject: Re: [PATCH v4 5/6] xfs: write stream based AG placement
Date: Wed, 19 Aug 2026 09:29:02 +0200 [thread overview]
Message-ID: <20260819072902.GA2332@lst.de> (raw)
In-Reply-To: <20260717125538.508925-6-joshi.k@samsung.com>
On Fri, Jul 17, 2026 at 06:25:37PM +0530, Kanchan Joshi wrote:
> If AGs are fewer than write streams, write streams are distributed into
> available AGs in round robin fashion.
I think we should just limit the number of available write streams
to the number of AG, as otherwise we'll get into a bit of a mess.
And for the case of the hardware write streams query them in mkfs
to align the AG geometry to that.
> + uint32_t nr_streams = xfs_inode_max_write_streams(ip);
> + uint32_t stream_id = ip->i_write_stream;
> + uint32_t nr_ags = mp->m_sb.sb_agcount;
> + xfs_agnumber_t set_size;
> +
> +
> + if (!nr_streams)
Double empty line.
next prev parent reply other threads:[~2026-08-19 7:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20260717125624epcas5p3fefc5b8ff274260bf8fb2f1b225b4f9a@epcas5p3.samsung.com>
2026-07-17 12:55 ` [PATCH v4 0/6] xfs write streams Kanchan Joshi
2026-07-17 12:55 ` [PATCH v4 1/6] fs: add write-stream management ioctls Kanchan Joshi
2026-07-21 3:03 ` Darrick J. Wong
2026-07-30 14:52 ` Kanchan Joshi
2026-07-30 17:22 ` Darrick J. Wong
2026-07-31 8:15 ` Kanchan Joshi
2026-08-19 7:04 ` Christoph Hellwig
2026-08-19 7:08 ` Christoph Hellwig
2026-08-19 7:11 ` Christoph Hellwig
2026-07-17 12:55 ` [PATCH v4 2/6] iomap: introduce and propagate write_stream Kanchan Joshi
2026-08-19 7:09 ` Christoph Hellwig
2026-07-17 12:55 ` [PATCH v4 3/6] xfs: implement write-stream management support Kanchan Joshi
2026-07-21 3:08 ` Darrick J. Wong
2026-07-31 8:03 ` Kanchan Joshi
2026-08-19 7:12 ` Christoph Hellwig
2026-08-19 7:18 ` Christoph Hellwig
2026-08-19 7:24 ` Christoph Hellwig
2026-07-17 12:55 ` [PATCH v4 4/6] xfs: generic AG set based steering Kanchan Joshi
2026-07-21 3:20 ` Darrick J. Wong
2026-07-24 14:57 ` Kanchan Joshi
2026-08-19 7:21 ` Christoph Hellwig
2026-07-17 12:55 ` [PATCH v4 5/6] xfs: write stream based AG placement Kanchan Joshi
2026-08-19 7:29 ` Christoph Hellwig [this message]
2026-07-17 12:55 ` [PATCH v4 6/6] xfs: introduce software write streams Kanchan Joshi
2026-08-19 7:31 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260819072902.GA2332@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=dgc@kernel.org \
--cc=djwong@kernel.org \
--cc=gost.dev@samsung.com \
--cc=jack@suse.cz \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ritesh.list@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox