From: Tao Cui <cui.tao@linux.dev>
To: bvanassche@acm.org, axboe@kernel.dk
Cc: hch@lst.de, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, cui.tao@linux.dev,
Tao Cui <cuitao@kylinos.cn>
Subject: [PATCH v2 3/3] loop: drop the unused argument of lo_req_flush()
Date: Mon, 31 Aug 2026 18:03:05 +0800 [thread overview]
Message-ID: <20260831100305.695116-4-cui.tao@linux.dev> (raw)
In-Reply-To: <20260831100305.695116-1-cui.tao@linux.dev>
From: Tao Cui <cuitao@kylinos.cn>
lo_req_flush() never uses its request argument. Drop it.
Signed-off-by: Tao Cui <cuitao@kylinos.cn>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/block/loop.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 126f42580632..1aff40963b40 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -270,7 +270,7 @@ static int lo_fallocate(struct loop_device *lo, struct request *rq, loff_t pos,
return ret;
}
-static int lo_req_flush(struct loop_device *lo, struct request *rq)
+static int lo_req_flush(struct loop_device *lo)
{
int ret = vfs_fsync(lo->lo_backing_file, 0);
if (unlikely(ret && ret != -EINVAL))
@@ -411,7 +411,7 @@ static int do_req_filebacked(struct loop_device *lo, struct request *rq)
switch (req_op(rq)) {
case REQ_OP_FLUSH:
- return lo_req_flush(lo, rq);
+ return lo_req_flush(lo);
case REQ_OP_WRITE_ZEROES:
/*
* If the caller doesn't want deallocation, call zeroout to
--
2.43.0
next prev parent reply other threads:[~2026-08-31 10:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 10:03 [PATCH 0/3] loop: three small cleanups Tao Cui
2026-08-31 10:03 ` [PATCH v2 1/3] loop: drop a stale reference to loop_validate_size() Tao Cui
2026-09-02 13:59 ` Christoph Hellwig
2026-08-31 10:03 ` [PATCH v2 2/3] loop: replace simple_strtol() with kstrtoint() Tao Cui
2026-08-31 10:07 ` Tao Cui
2026-08-31 10:03 ` Tao Cui [this message]
2026-09-02 14:00 ` [PATCH v2 3/3] loop: drop the unused argument of lo_req_flush() Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260831100305.695116-4-cui.tao@linux.dev \
--to=cui.tao@linux.dev \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=cuitao@kylinos.cn \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox