From: Karl Mehltretter <kmehltretter@gmail.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Karl Mehltretter <kmehltretter@gmail.com>,
linux-block@vger.kernel.org, Satya Tangirala <satyat@google.com>
Subject: [PATCH v2] blk-crypto: Fix the num_prealloc_fallback_crypt_ctxs parameter description
Date: Sat, 12 Sep 2026 13:50:50 +0200 [thread overview]
Message-ID: <20260912115050.89055-1-kmehltretter@gmail.com> (raw)
The parameter is num_prealloc_fallback_crypt_ctxs, but its
MODULE_PARM_DESC() uses num_prealloc_crypt_fallback_ctxs.
BLK_INLINE_ENCRYPTION_FALLBACK is a bool, so this code is built in when
enabled. Its parameter metadata is recorded in modules.builtin.modinfo,
where the parm and parmtype entries currently refer to different names.
Use the actual parameter name in MODULE_PARM_DESC() so the description
matches the type entry.
Fixes: 488f6682c832 ("block: blk-crypto-fallback for Inline Encryption")
Assisted-by: LLM
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
Changes in v2:
- Correct the changelog to describe built-in metadata in
modules.builtin.modinfo. The patch itself is unchanged.
v1: https://lore.kernel.org/r/20260906165952.2344-1-kmehltretter@gmail.com/
block/blk-crypto-fallback.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/blk-crypto-fallback.c b/block/blk-crypto-fallback.c
index 2a8f40a65158..877934db18ef 100644
--- a/block/blk-crypto-fallback.c
+++ b/block/blk-crypto-fallback.c
@@ -34,7 +34,7 @@ MODULE_PARM_DESC(num_keyslots,
static unsigned int num_prealloc_fallback_crypt_ctxs = 128;
module_param(num_prealloc_fallback_crypt_ctxs, uint, 0);
-MODULE_PARM_DESC(num_prealloc_crypt_fallback_ctxs,
+MODULE_PARM_DESC(num_prealloc_fallback_crypt_ctxs,
"Number of preallocated bio fallback crypto contexts for blk-crypto to use during crypto API fallback");
struct bio_fallback_crypt_ctx {
base-commit: 986c24e0fe44f844b44d365b71ce831947f50298
--
2.39.5 (Apple Git-154)
reply other threads:[~2026-09-12 11:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260912115050.89055-1-kmehltretter@gmail.com \
--to=kmehltretter@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=satyat@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox