From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-00364e01.pphosted.com (mx0b-00364e01.pphosted.com [148.163.139.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B6053B2FC7 for ; Tue, 22 Sep 2026 02:54:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.139.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790045663; cv=none; b=q2UvtZReoHJhEnTq2iJg+Tqcn6hDKaR7VpYrdpDXLc4lltwET7ps0uavZiwj7usHetG+j9cfWRo/KpS+XZsSN6Scau9D5312K4a/MOW+nc9rLn9aKY9ykY0FSUEHnOT5FalY1zwFZdXO4onItGAv5f85d5OPkdU6oprRhxXqbUg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790045663; c=relaxed/simple; bh=EbC+zxM1tqI8jGM5V6h5xGabP65wDxbe+0kLZNaqFJY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Z41xZ0z3OI/dHuLeNSlVjyrIOFVx36zlrOMw1g+22G8ptGoZ48KDVPrIdH1EkCChdK7DMyFIjyiDgHWk+b7fJ05fT1uSBnTCwtfAzH0dqq4vDSufMQGNPTzQan7YKynIHOjxWHH87sGqPJOyFhw6vCCp0D6x1G1zE7I33BRyLSw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=columbia.edu; spf=pass smtp.mailfrom=columbia.edu; dkim=pass (2048-bit key) header.d=columbia.edu header.i=@columbia.edu header.b=HrNROfLZ; dkim=pass (2048-bit key) header.d=columbia.edu header.i=@columbia.edu header.b=UF0QmMpd; arc=none smtp.client-ip=148.163.139.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=columbia.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=columbia.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=columbia.edu header.i=@columbia.edu header.b="HrNROfLZ"; dkim=pass (2048-bit key) header.d=columbia.edu header.i=@columbia.edu header.b="UF0QmMpd" Received: from pps.filterd (m0167075.ppops.net [127.0.0.1]) by mx0b-00364e01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68M2XFjp939508 for ; Mon, 21 Sep 2026 22:54:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=columbia.edu; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pps01; bh=fCyo Pm82t/vQFUFDMN7TNa15BmngKFwJlt5ScMnEw8M=; b=HrNROfLZRDR9lv4nMZtz iPHcGTYii1LCajuBfX5TL14K0CBPvyjfbf+g8HthUMiBT0y8yUFFJ/OHUfvUipwJ GzYVzZG1zJ2ZbglZrz04hhC9m70a4QESexv6bCeV5OuDpakBGk83Z6778HQCCl2e vcnPXknT1CF0LatW95l5yDUu7uYD1mchGjx76P9aBN71sR4+TQeBgPgmrCmrHAsH /iYmq3Rx+YA9DYfmWu0Ee+UQeG4QanI4shyhvV89gc3NGrQF5PBmIpgoj7LyfKf2 SBPN3CfSuW+UPf2Yn1n1gclqWvpCNv3BHIhLLMfBJL9s9SPq6u8HGrne1YUXjNDS AQ== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0b-00364e01.pphosted.com (PPS) with ESMTPS id 4guavu2bmx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 21 Sep 2026 22:54:19 -0400 (EDT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-530e0cb072eso57323791cf.1 for ; Mon, 21 Sep 2026 19:54:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=columbia.edu; s=lionmail; t=1790045659; x=1790650459; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fCyoPm82t/vQFUFDMN7TNa15BmngKFwJlt5ScMnEw8M=; b=UF0QmMpdAoR7AzoZwR8ZbgJhSuPu0y3dnNs7I+KSc1sNz7OiGZT7GZAT5O+zYRY3TJ INtNbt3/+jMqZN8tXMU5ocwKaKTGlbn4af5IcZh2oBtvVW2VNSUo73hlLuIoHdjL2wTJ e43s5DtObmXvx0oQxdX2Lr4Z3rff4rEutk1B7k+3XtKWsXJ9pbwIypjvQ3bOMVkM4DQX jE4U9dbu/wtqOryHOFlNz++hz+/vwLkRepdeGrbAMGEBGNt8S+FuzdatQu0TBwLqKfcM yV5+ey1HUG9+BZfBlgHoJ4evhHPtiXCznzLT0E93BbgAkjtokJ8VaBzs3txeaYwIWBjx CD2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790045659; x=1790650459; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=fCyoPm82t/vQFUFDMN7TNa15BmngKFwJlt5ScMnEw8M=; b=Xy06tzhhcEN3eE261HcyJZtXqtZtWZRV2kkNORbAMMcSbx+iCy/UYIja/JbO84eAE8 rfroITALjphCc3u3Hft73fn6ipN1T1rCyn426BmNp03MWqVd7HWTn/QNwVR3UPSV6WnJ LroG2JZsSqo2x0/gP7dSOku1vECNfnhsMr1uU2Tp07+CW+mzXl/gkh95ydvvMluJDknG ObiqFPf5xkTkOe4e0T5xIyr0vVIZ1Qti0kuDkW05R1O7qqd88VJKeI0Uk32TogQ90DIy /QLsida2OzRSjiOgIB6gGaoI8loPucagWn6yvN872CKdJji8ToKkZUU/skL3jLnHQMFT M78w== X-Forwarded-Encrypted: i=1; AKwUvBywal+5VVAq4sHnPZ7tLe+1dLvJwrX8NrsxJI31GQUIRnYOnlG4jvQPF5gxmiKGyjLebsEr3f0ODe95BA==@vger.kernel.org X-Gm-Message-State: AFuF++kQPlv2+orCv0wU9veTk9SbmhxryTp7n8SHZU4YuTlqrOd7kbkH /WiXqsNXwoH3EfMQ5PQLaZha23RQYcg8WsHeLz1yo6H94g2JuFkJEFGUwk+jx9c7fnl+fGKbEdn krEC/Dmn1Xa1zrJnw+Il9Dxt37vihhvAPamHxEj1TT5IIJBKtNUgPGZc26MH6 X-Gm-Gg: AYBFou2HNAJjkhTOGBjTuBovfSF/1eT6dwp8GnismMibM990o1kld/8uK1Yvn4yOho0 x0OR33xgAk/sJyZXtKdHs7+j9HV52BypnwTEzRQkoes+tglbIYlkowu6j+3xkifKeiLXpLHpoUJ DOEal737Zy2iX+W9vKcS+Sj6i+ACZU4dMcja3HG3cxByXF5nz6nuLIcAvXrjs+XJ/VgQquNFy+0 H8BbmwKv+KWXFGJpeRh3ZDVJpW410k0RZFFrdP6rRCm+GL7NVdowFIE1FpJ9AMcorcaSAps3C3v nekouZaIkLPE1nUjhlI7HE+WNPujpddbTISUAIqyAu+97UJ6t4To1X9XBdegZupjqPgOJ6FGVy5 GqnoBzv+LEXhWJXlXbT7+IXMzKB2fQMhgj3Og3KvehN6C X-Received: by 2002:a05:622a:230a:b0:530:f67d:83ea with SMTP id d75a77b69052e-532d8d31f2dmr37334311cf.11.1790045659422; Mon, 21 Sep 2026 19:54:19 -0700 (PDT) X-Received: by 2002:a05:622a:230a:b0:530:f67d:83ea with SMTP id d75a77b69052e-532d8d31f2dmr37334121cf.11.1790045659047; Mon, 21 Sep 2026 19:54:19 -0700 (PDT) Received: from [127.0.1.1] (dyn-160-39-33-242.dyn.columbia.edu. [160.39.33.242]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-532e18fce9fsm2048421cf.15.2026.09.21.19.54.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Sep 2026 19:54:18 -0700 (PDT) From: Tal Zussman Date: Mon, 21 Sep 2026 22:54:05 -0400 Subject: [PATCH v4 8/8] block: remove dead metadata handling from the async direct I/O path Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260921-blkdev-fixes-v4-8-e2801f71ede9@columbia.edu> References: <20260921-blkdev-fixes-v4-0-e2801f71ede9@columbia.edu> In-Reply-To: <20260921-blkdev-fixes-v4-0-e2801f71ede9@columbia.edu> To: Jens Axboe , Christoph Hellwig , Johannes Thumshirn , Luis Chamberlain , Hannes Reinecke , "Matthew Wilcox (Oracle)" , John Garry , Christian Brauner , "Darrick J. Wong" , Keith Busch , "Martin K. Petersen" Cc: Shin'ichiro Kawasaki , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Tal Zussman X-Mailer: b4 0.17-dev-db0b7 X-Developer-Signature: v=1; a=ed25519-sha256; t=1790045650; l=1396; i=tz2294@columbia.edu; s=20250528; h=from:subject:message-id; bh=EbC+zxM1tqI8jGM5V6h5xGabP65wDxbe+0kLZNaqFJY=; b=yERiseFIyAnUCk63ZZni+vwp1NciaCnnL9jJ2tVTvoeYLsx2HpPUCDme8TFQIXwRyRoflEjN9 /H6pW6x2mioAhcEpOVrUEWzzjpeSQ8S6fovNVbXT91kBp32OLbKF0A0 X-Developer-Key: i=tz2294@columbia.edu; a=ed25519; pk=BIj5KdACscEOyAC0oIkeZqLB3L94fzBnDccEooxeM5Y= X-Authority-Analysis: v=2.4 cv=OfQNnRTY c=1 sm=1 tr=0 ts=6ab1eddc cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=GaPK54s0Se3oFqK5NkZy0g==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=x7bEGLp0ZPQA:10 a=A0y_DWxS2BwA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Da8U98TiO7q1upZEImrf:22 a=HpS3TJQ9O3Ob1ozEcmik:22 a=VwQbUJbxAAAA:8 a=IE87Obj3e0A1gCLlgTsA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTIyMDAzNyBTYWx0ZWRfX0lRoFFaiPGF1 fyTI7nWj6zIgzmwxtBxyUkfSWYzXJDB24omdIwaIlm/7Iio2XmeuakTVTMZCs6bhrifQLknS6Tb lxN4vZC6ywfKj/WGWy1ZsfMhMjwFG+igJyZLmkIkxOri43/gqphT X-Proofpoint-GUID: tbcGN7246HOIlDU1PMu5MR29ZU4hWdhD X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTIyMDAzNyBTYWx0ZWRfX5TaJDQcf/kqq xwlPOtklnOnbbCS3hSbAJWN3P2MkPebFWKp/A5EPzU1geDODqtDWJA/iC2EX9Tbz9yiQVsNJzTL Yg16T6zBp3IphVpyJv0aA36FmUQwUJsBmVpzv6i1dhrMB2JuzY8RDU9T7RiCPUp/4WefM9eqM5x RJFDGx4paK0AMyN19Etq0shRtHmtMs3ObC7I2cX9XWE36pQwHRFMQyFZ+7UQriaxsEHZKCtZ4RJ cs5NZ80eWvHoVwykZCUCU39229CT7rueH4+ndCdVOcguJ8QMJMdg8WoxjvpBcWRRSQY8y/PiXie L+uov7Vs0hG3EZyoxEXVo1Add/ArusFZ/7IIJEgr9uHpBfLYvuQJEWLWG24hb96njq2Xwz76GIQ 5GnUWcWdCl++nogyUWmrptZuxVtTrnUTl31NgkBnudW2mvJcJPl82y9tkUtS4ShuhvoMlqSfOHZ APYskinxuQyn28pghbQ== X-Proofpoint-ORIG-GUID: tbcGN7246HOIlDU1PMu5MR29ZU4hWdhD X-Proofpoint-Virus-Version: vendor=nai engine=6900 definitions=11912 signatures=596817 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=10 spamscore=0 priorityscore=1501 lowpriorityscore=10 phishscore=0 adultscore=0 malwarescore=0 bulkscore=10 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609220037 Since commit 2729a60bbfb9 ("block: don't silently ignore metadata for sync read/write"), blkdev_direct_IO() sends every IOCB_HAS_METADATA request to __blkdev_direct_IO(). Remove the now unreachable metadata mapping in __blkdev_direct_IO_async() and the unmap in its completion handler. No functional change. Assisted-by: Claude:claude-fable-5 Reviewed-by: Christoph Hellwig Reviewed-by: Hannes Reinecke Signed-off-by: Tal Zussman --- block/fops.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/block/fops.c b/block/fops.c index 7f23778f6b81..55c2e606c662 100644 --- a/block/fops.c +++ b/block/fops.c @@ -306,9 +306,6 @@ static void blkdev_bio_end_io_async(struct bio *bio) ret = blk_status_to_errno(bio->bi_status); } - if (bio_integrity(bio)) - bio_integrity_unmap_user(bio); - iocb->ki_complete(iocb, ret); if (dio->flags & DIO_SHOULD_DIRTY) { @@ -370,13 +367,6 @@ static ssize_t __blkdev_direct_IO_async(struct kiocb *iocb, task_io_account_write(bio->bi_iter.bi_size); } - if (iocb->ki_flags & IOCB_HAS_METADATA) { - ret = bio_integrity_map_iter(bio, iocb->private); - WRITE_ONCE(iocb->private, NULL); - if (unlikely(ret)) - goto out_bio_put; - } - if (iocb->ki_flags & IOCB_HIPRI) { bio->bi_opf |= REQ_POLLED; submit_bio(bio); -- 2.39.5