From: Mohamed Khalfella <mkhalfella@purestorage.com>
To: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: linux-block@vger.kernel.org, Keith Busch <kbusch@kernel.org>,
Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>, Hannes Reinecke <hare@suse.de>,
John Meneghini <jmeneghi@redhat.com>,
Jesse Taube <jtaubepe@redhat.com>,
Randy Jennings <randyj@purestorage.com>,
Dhaval Giani <dgiani@purestorage.com>
Subject: Re: [PATCH blktests 0/5] nvme: detect ABA ghost writes on multipath fabrics
Date: Wed, 23 Sep 2026 10:02:38 -0700 [thread overview]
Message-ID: <20260923170238.GH2931-mkhalfella@purestorage.com> (raw)
In-Reply-To: <arOFG9-sM_GrrbQf@shinmob>
On Wed 2026-09-23 17:18:21 +0900, Shin'ichiro Kawasaki wrote:
> On Sep 16, 2026 / 20:06, Mohamed Khalfella wrote:
>
> Mohamad, thanks for the series. Before I look in the details of the patches,
> I would like make a comment below.
>
> > Reproducing the race needs an IO that can be held at the target for
> > longer than the host's io_timeout without being failed. The first three
> > patches give miniublk that ability, since there was previously no way to
> > talk to a running ublk server at all:
> >
> > 1/5 adds a loopback UDP control channel to the daemon, served by a
> > detached thread, one reply datagram per request
> > 2/5 adds an INJECT_DELAY command which delays a given number of reads
> > or writes as an io_uring timeout on the queue's own ring
> > 3/5 exposes it as "miniublk inject", which returns only once the
> > daemon has armed the delay, so a test can start IO immediately
> > without racing it
>
> It is interesting to implement the delay feature to miniublk, and use it as the
> testing tool. But I'm not sure if this is the best approach because of two
> points. First, scsi_debug has jdelay and ndelay options. I wonder if this
> existing feature can fulfill the requirements of the new test case. Second, when
> rublk [*] is available in the PATH of the test system, blktests detect it and
> use it instead of miniublk. I guess the added delay feature is not available in
> rublk, and the test case won't work well. What do you think of these points?
>
The two points make sense to me. Let me look at scsi_debug delay
injection mechanism first and see if it can be used here. I will also
look at rublk. Thanks for the pointers.
next prev parent reply other threads:[~2026-09-23 17:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 2:06 [PATCH blktests 0/5] nvme: detect ABA ghost writes on multipath fabrics Mohamed Khalfella
2026-09-17 2:06 ` [PATCH blktests 1/5] src/miniublk: add a control channel to the daemon Mohamed Khalfella
2026-09-17 2:06 ` [PATCH blktests 2/5] src/miniublk: add IO delay injection Mohamed Khalfella
2026-09-17 2:06 ` [PATCH blktests 3/5] src/miniublk: add the inject command Mohamed Khalfella
2026-09-17 2:06 ` [PATCH blktests 4/5] src/nvme-ghost-write-detector: add an ABA ghost write detector Mohamed Khalfella
2026-09-21 18:38 ` Jesse Taube
2026-09-23 17:00 ` Mohamed Khalfella
2026-09-17 2:06 ` [PATCH blktests 5/5] nvme/070: test for ABA ghost writes on a multipath fabrics namespace Mohamed Khalfella
2026-09-22 17:07 ` Jesse Taube
2026-09-23 16:56 ` Mohamed Khalfella
2026-09-23 8:18 ` [PATCH blktests 0/5] nvme: detect ABA ghost writes on multipath fabrics Shin'ichiro Kawasaki
2026-09-23 17:02 ` Mohamed Khalfella [this message]
2026-10-02 3:03 ` Shin'ichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260923170238.GH2931-mkhalfella@purestorage.com \
--to=mkhalfella@purestorage.com \
--cc=axboe@kernel.dk \
--cc=dgiani@purestorage.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jmeneghi@redhat.com \
--cc=jtaubepe@redhat.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=randyj@purestorage.com \
--cc=sagi@grimberg.me \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox