Linux block layer
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Daniel Wagner <dwagner@suse.de>
Cc: Aaron Tomlin <atomlin@atomlin.com>,
	axboe@kernel.dk, tglx@kernel.org, aacraid@microsemi.com,
	James.Bottomley@hansenpartnership.com, mkp@kernel.org,
	frederic@kernel.org, ionut.nechita@windriver.com, corbet@lwn.net,
	vincent.guittot@linaro.org, mingo@redhat.com,
	peterz@infradead.org, radu@rendec.net, akpm@linux-foundation.org,
	steve@abita.co, sean@ashe.io, chjohnst@gmail.com, neelx@suse.com,
	mproche@gmail.com, nick.lange@gmail.com,
	marco.crivellari@suse.com, rishil1999@outlook.com,
	linux-doc@vger.kernel.org, linux-block@vger.kernel.org,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v16 0/9] blk: honor isolcpus configuration
Date: Thu, 15 Oct 2026 14:29:34 +0200	[thread overview]
Message-ID: <20261015122934.5itxaJ3l@linutronix.de> (raw)
In-Reply-To: <2f32ffb6-d889-4281-a612-d4185311ca0d@flourine.local>

On 2026-10-15 13:22:35 [+0200], Daniel Wagner wrote:
> During Plumbers we had several discussions on this series. This is what I
> remember we discussed and decided:
> 
>   - The current managed_irq behavior doesn't match the other flags of isolcpus.
> 
>   - Instead of introducing managed_irq_strict, it's better to change the
>     existing managed_irq to follow the strict interpretation.
> 
>   - The main existing user of the current managed_irq mapping is
>     RH with OpenShift. After discussing with Juri, it doesn't look like
>     it is a real blocker to change to the strict interpretation.

This is what I remember, too.

>   - If there are complaints about the managed irq behavior change, it's
>     better to introduce a different flag for this. Though there have been
>     many discussions and proposals on how to deal with isolation during the
>     conference, and the general mood was that the placement of resources
>     should be done during runtime. Thus it is likely that the old behaviour
>     is not necessary at all if runtime configuration is possible.

The main argument/ problem is that managed_irq does not work as expected
for the vast majority of users and should be fixed. This has only been
"recently" documented.

The whole isolcpus= was meant to be static and there was no argument why
it needs to vanish. A dynamic interface for dynamic workloads is what
you want especially if you have 80+ CPUs and workloads can change. But
on <16 CPUs system the partition probably do not change. It is also not
obvious if your driver(s) use managed_irqs or not.
To get a runtime interface for this you would need to be able to
reconfigure the managed_irq interrupt if "interrupts < CPUS". Otherwise
it is just enable and disable like during CPU-hotplug but without it. If
I remember it correctly, the device itself does not handle this at all
but the block layers drains and starts queues during a hotplug event.

> Hope this helps to move forward with this series,
> Daniel

Sebastian

  reply	other threads:[~2026-10-15 12:29 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-10 16:42 [PATCH v16 0/9] blk: honor isolcpus configuration Aaron Tomlin
2026-09-10 16:42 ` [PATCH v16 1/9] scsi: aacraid: use block layer helpers to calculate num of queues Aaron Tomlin
2026-09-10 16:42 ` [PATCH v16 2/9] lib/group_cpus: remove dead !SMP code Aaron Tomlin
2026-09-10 16:42 ` [PATCH v16 3/9] lib/group_cpus: Add group_mask_cpus_evenly() Aaron Tomlin
2026-09-10 16:42 ` [PATCH v16 4/9] sched/isolation: Prevent out-of-bounds read in isolcpus= boot parameter parser Aaron Tomlin
2026-09-10 16:42 ` [PATCH v16 5/9] isolation: Introduce managed_irq_strict isolcpus type Aaron Tomlin
2026-09-10 16:42 ` [PATCH v16 6/9] blk-mq: use hk cpus only when isolcpus=managed_irq_strict is enabled Aaron Tomlin
2026-09-10 16:42 ` [PATCH v16 7/9] blk-mq: prevent offlining hk CPUs with associated online isolated CPUs Aaron Tomlin
2026-09-10 16:42 ` [PATCH v16 8/9] genirq/affinity: Restrict managed IRQ affinity to housekeeping CPUs Aaron Tomlin
2026-09-10 16:42 ` [PATCH v16 9/9] docs: add managed_irq_strict flag to isolcpus Aaron Tomlin
2026-09-10 18:26 ` [PATCH v16 0/9] blk: honor isolcpus configuration Aaron Tomlin
2026-09-17 15:44 ` Ionut Nechita (Wind River)
2026-09-21 13:53   ` Ionut Nechita
2026-09-28 15:53     ` Aaron Tomlin
2026-10-05  9:34       ` [PATCH] genirq/affinity: confine reserved (pre/post) vectors to housekeeping CPUs Ionut Nechita (Wind River)
2026-10-05 15:24       ` [PATCH v16 0/9] blk: honor isolcpus configuration Ionut Nechita (Wind River)
2026-10-06 13:57         ` Ionut Nechita (Wind River)
2026-10-15 11:22 ` Daniel Wagner
2026-10-15 12:29   ` Sebastian Andrzej Siewior [this message]
2026-10-15 13:59   ` Aaron Tomlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261015122934.5itxaJ3l@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=aacraid@microsemi.com \
    --cc=akpm@linux-foundation.org \
    --cc=atomlin@atomlin.com \
    --cc=axboe@kernel.dk \
    --cc=chjohnst@gmail.com \
    --cc=corbet@lwn.net \
    --cc=dwagner@suse.de \
    --cc=frederic@kernel.org \
    --cc=ionut.nechita@windriver.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=marco.crivellari@suse.com \
    --cc=mingo@redhat.com \
    --cc=mkp@kernel.org \
    --cc=mproche@gmail.com \
    --cc=neelx@suse.com \
    --cc=nick.lange@gmail.com \
    --cc=peterz@infradead.org \
    --cc=radu@rendec.net \
    --cc=rishil1999@outlook.com \
    --cc=sean@ashe.io \
    --cc=steve@abita.co \
    --cc=tglx@kernel.org \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox