From: Christoph Hellwig <hch@lst.de>
To: dlemoal@kernel.org, axboe@kernel.dk
Cc: linux-block@vger.kernel.org
Subject: [PATCH] zloop: fix block size query
Date: Mon, 2 Nov 2026 06:55:58 +0100 [thread overview]
Message-ID: <20261102055558.3212814-1-hch@lst.de> (raw)
The block size obviously needs to be queried when it is not set, not when
it already is set.
Reported: Damien Le Moal <dlemoal@kernel.org>
Fixes: 5e9929e2f03c ("zloop: share more code for opening a zone backing file")
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/block/zloop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/zloop.c b/drivers/block/zloop.c
index 65634a39b0bf..5cfbb5a6b771 100644
--- a/drivers/block/zloop.c
+++ b/drivers/block/zloop.c
@@ -1137,7 +1137,7 @@ static int zloop_init_zone(struct zloop_device *zlo, struct zloop_options *opts,
goto out_fput;
}
- if (zlo->block_size) {
+ if (!zlo->block_size) {
ret = zloop_get_block_size(zlo, zone);
if (ret)
goto out_fput;
--
2.53.0
next reply other threads:[~2026-11-02 5:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 5:55 Christoph Hellwig [this message]
2026-11-03 4:57 ` [PATCH] zloop: fix block size query Damien Le Moal
2026-11-03 14:31 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261102055558.3212814-1-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox