Linux block layer
 help / color / mirror / Atom feed
From: Yang Erkun <yangerkun@huawei.com>
To: axboe@kernel.dk, josef@toxicpanda.com, xiubli@redhat.com,
	prasanna.kalever@redhat.com, ming.lei@redhat.com, yukuai@fygo.io,
	nilay@linux.ibm.com
Cc: linux-block@vger.kernel.org, nbd@other.debian.org,
	yangerkun@huawei.com, wangkefeng.wang@huawei.com,
	leijitang@huawei.com, yi.zhang@huawei.com,
	chengzhihao1@huawei.com, houtao1@huawei.com, wozizhi@huawei.com
Subject: [RFC PATCH 2/5] nbd: decrement nbd_total_devices when a device is removed
Date: Sat,  7 Nov 2026 14:46:26 +0800	[thread overview]
Message-ID: <20261107064629.4093489-3-yangerkun@huawei.com> (raw)
In-Reply-To: <20261107064629.4093489-1-yangerkun@huawei.com>

nbd_total_devices is incremented in nbd_dev_add() but never decremented,
so it ends up larger than the number of devices left in nbd_index_idr.
nbd_genl_status() sizes the reply from it, so status allocates for
devices that no longer exist.

Decrement it in nbd_dev_remove() under nbd_index_mutex.

Fixes: 47d902b90a32 ("nbd: add a status netlink command")
Assisted-by: LLM
Signed-off-by: Yang Erkun <yangerkun@huawei.com>
---
 drivers/block/nbd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index fbade6ae4481..1448ee63fab5 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -275,6 +275,7 @@ static void nbd_dev_remove(struct nbd_device *nbd)
 	 */
 	mutex_lock(&nbd_index_mutex);
 	idr_remove(&nbd_index_idr, nbd->index);
+	nbd_total_devices--;
 	mutex_unlock(&nbd_index_mutex);
 	destroy_workqueue(nbd->recv_workq);
 	put_disk(disk);
-- 
2.52.0


  parent reply	other threads:[~2026-11-07  6:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-07  6:46 [RFC PATCH 0/5] nbd: allow parallel genetlink operations Yang Erkun
2026-11-07  6:46 ` [RFC PATCH 1/5] nbd: validate the backend identifier under config_lock Yang Erkun
2026-11-07  6:46 ` Yang Erkun [this message]
2026-11-07  6:46 ` [RFC PATCH 3/5] nbd: publish devices atomically Yang Erkun
2026-11-07  6:46 ` [RFC PATCH 4/5] nbd: hold config_lock while updating nr_hw_queues Yang Erkun
2026-11-07  6:46 ` [RFC PATCH 5/5] nbd: allow genetlink operations to run in parallel Yang Erkun
2026-11-17  4:36 ` [RFC PATCH 0/5] nbd: allow parallel genetlink operations yangerkun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261107064629.4093489-3-yangerkun@huawei.com \
    --to=yangerkun@huawei.com \
    --cc=axboe@kernel.dk \
    --cc=chengzhihao1@huawei.com \
    --cc=houtao1@huawei.com \
    --cc=josef@toxicpanda.com \
    --cc=leijitang@huawei.com \
    --cc=linux-block@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=nbd@other.debian.org \
    --cc=nilay@linux.ibm.com \
    --cc=prasanna.kalever@redhat.com \
    --cc=wangkefeng.wang@huawei.com \
    --cc=wozizhi@huawei.com \
    --cc=xiubli@redhat.com \
    --cc=yi.zhang@huawei.com \
    --cc=yukuai@fygo.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox