From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.178 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794553640; b=Xg5qyc5gn4uecT5SMbUHMSEFEZE/3mt616NdvoekFWHr8twEFcL355cVnFAgFaBGTTjV 2c2ZO2nf3C1VvpqcC0gnVowB0xsrfdcwgDiCdSOqjOhcaxVmDS6QuXEARAMlIJ1ncwbDX GEZt/5LZysmclYeV24gfak4yLJtAyq39164SGR2IJ0Aiai9q6GZaZA4EBDwOwRFdJETaH /9CCJeaKxA4QpZgAVD2XTRjzNVrp5wztWIK51gHzb1ew6trP+aXAbrKrXd7hj7skw53Uu 89b1Sel9861zDlZSmZB4Schu/ZC1MIGU34R5ExpfdhwG+7oiQuk8gxw4Ioz7JaxommA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794553640; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:From:To:Cc:Subject:Date:Message-ID: X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=GZLtnWbFqtu8KIap5fiJtQhx6w9LpQFKds01tBdh2l0=; b=R3BBJ222bizwYpvEbK1p+i38y+fomqIKgCRutjj+mkFCUsIBK4V14xXYZKPV1f3tDEi6 jg4d8q156sQrk8CzbP5HDeU6xRU5k0JTV4AumgBqycayT3sPum7FV9q8oIMm1LtBun+G4 decFbJpA1Kz5qNKAHerx1nZvVpfBSZtJfMictZmQnAXirP3ccpPYhM8vF9bTsR8FWoO2g +2rlk42rDwiSNhPQ3xhfXAm3uQlrszUcLHJcO8sdmSuES4aQ2F12eTMvPiiDRw3jh+j+4 /Kb/7vPbuzKUuylduatA85Anhc/k+vKMXgBCz5yDRjdKmgqQ5PROQqWIC2bl1Nl58Ow== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b="V1tLvmj/"; arc=none smtp.remote-ip=95.215.58.178 Received: from mta1.migadu.com (out-178.mta1.migadu.com [95.215.58.178]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3A86606A8AC for ; Fri, 13 Nov 2026 07:07:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org A3A86606A8AC Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=V1tLvmj/ X-Envelope-To: linux-block@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=wulpxDchqVhG4T16i7jOp2tJVbBXi1laAGjfm4w5eGs=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1794553637; v=1; x=1795158437; b=V1tLvmj/k9WlXLUiFzLNeJTospkgIlOT7tkqTCzITmGu889cs/wNNBugb5bGciiz3stwvbch 1ZM6uxpsJcm7Zg3U/auVBn5XusRDgDQlzdHz15knmldboqvJN9Na7JkwYPZgLYF4DohQLs4zWt4 xNMizFMQGLezzST3kMK74iEg= X-Envelope-To: linux-block@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id d2229d58c56c6432; Fri, 13 Nov 2026 07:07:17 +0000 X-Mizu-Trace-ID: d2229d58c56c6432 X-Migadu-Flow: FLOW_OUT From: Mengmeng Zhao To: Christoph Hellwig , Anuj Gupta , Nitesh Shetty , Jens Axboe , Sumit Semwal , christian.koenig@amd.com, Philipp Stanner , Dan Williams , Matthew Wilcox , Jan Kara , Alexander Viro , Christian Brauner , tytso@mit.edu, Andreas Dilger , Baokun Li , Ojaswin Mujoo , "Ritesh Harjani (IBM)" , Zhang Yi , asml.silence@gmail.com, Jonathan Corbet , Shuah Khan , Randy Dunlap Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-doc@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, Li Wang , Mengmeng Zhao Subject: [RFC PATCH v2 2/8] iomap: add dma-buf direct I/O guards Date: Fri, 13 Nov 2026 15:06:15 +0800 Message-ID: <20261113070621.273953-3-mengmeng.zhao@linux.dev> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261113070621.273953-1-mengmeng.zhao@linux.dev> References: <20261113070621.273953-1-mengmeng.zhao@linux.dev> X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Nitesh Shetty Direct I/O copies data from the CPU in four places, zero-filling holes, inline data, bounce pages and integrity metadata. A dma-buf iterator has no pages behind it, so refuse it there. Reads that encounter a hole or unwritten extent therefore return -EOPNOTSUPP for the entire operation, even if I/O for an earlier mapped extent was already submitted. Signed-off-by: Nitesh Shetty Signed-off-by: Anuj Gupta Signed-off-by: Mengmeng Zhao Signed-off-by: Li Wang --- fs/iomap/direct-io.c | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c index ad041ac3252a..4a2b0f9df5a7 100644 --- a/fs/iomap/direct-io.c +++ b/fs/iomap/direct-io.c @@ -425,6 +425,11 @@ static int iomap_dio_bio_iter(struct iomap_iter *iter, struct iomap_dio *dio) unsigned int alignment; ssize_t ret = 0; + /* integrity metadata is generated from the data pages */ + if (iov_iter_is_dmabuf_map(dio->submit.iter) && + (iomap->flags & IOMAP_F_INTEGRITY)) + return -EOPNOTSUPP; + /* * File systems that write out of place and always allocate new blocks * need each bio to be block aligned as that's the unit of allocation. @@ -589,7 +594,13 @@ static int iomap_dio_bio_iter(struct iomap_iter *iter, struct iomap_dio *dio) static int iomap_dio_hole_iter(struct iomap_iter *iter, struct iomap_dio *dio) { - loff_t copied = iov_iter_zero(iomap_length(iter), dio->submit.iter); + loff_t copied; + + /* zero-filling walks the data pages */ + if (iov_iter_is_dmabuf_map(dio->submit.iter)) + return -EOPNOTSUPP; + + copied = iov_iter_zero(iomap_length(iter), dio->submit.iter); if (dio->flags & IOMAP_DIO_FSBLOCK_ALIGNED) { loff_t aligned_copied = round_down(copied, @@ -619,6 +630,10 @@ static int iomap_dio_inline_iter(struct iomap_iter *iomi, struct iomap_dio *dio) loff_t pos = iomi->pos; u64 copied; + /* inline data is copied from the CPU */ + if (iov_iter_is_dmabuf_map(iter)) + return -EOPNOTSUPP; + if (WARN_ON_ONCE(!inline_data)) return -EIO; @@ -717,6 +732,10 @@ __iomap_dio_rw(struct kiocb *iocb, struct iov_iter *iter, if (!iomi.len) return NULL; + /* bouncing copies the data from the CPU */ + if (iov_iter_is_dmabuf_map(iter) && (dio_flags & IOMAP_DIO_BOUNCE)) + return ERR_PTR(-EOPNOTSUPP); + dio = kmalloc_obj(*dio); if (!dio) return ERR_PTR(-ENOMEM); -- 2.43.0