From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.208.71 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795136848; b=Y7KaJuFqBA46CQAHj2Ew/FYxXSZmel2OlP9FOv4UeMzO3lFQDKw0t4tMVrdRzgZm6Dut ZZo5C+3SneU4X+joax4BWVBlgUhamFaEP4jmj+2HdGjw9OpymQvD63Rz8tsHo6/n7cjRC cjwq/thsACv7aCy8afn4H4R7rQwMtFzqNyjlwVKoRhCu+EfLC5XTPE1VmLzOI4QyxPr9j hWifFFDJJQ1Uo6mVgkVHCdyOMkg7NO78ttXqnMtAazNA7eN7b0tu9aXf7TSKN9oV+A4KI x2dDvWQcVsWdBuylwKc7oDyrETH2Bfq9MZ7o4TQYChBrsoaupctRcPc78HXZQuI7jOg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795136848; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Mailer:Message-ID:Subject:From:To:Cc: Content-Type; bh=E07+bb3FRwBQVv7TP6tKUfjd8V3oXYxVPDexh6Cqmzk=; b=Sxr7DBjqptimq03nU+dEY0nH/ea9tF4BeyDq7ModKT0Xxq8BtUSErJscMsvbTdf1/twd kNhiZ/u+Do39FVLypmAgrItqfLzS3a+Qd3QHfPbqrc0Uox7JetGA2Ld7WjeMWyVSwDJZO afvCXPfa9kuGjz+g0/35KR2XOBCAZILPFGbGkWC9zOJOysd3HzleX0hejFCiIiIN0Yibp tfMlFb6tl9mh5BzeR+/t5ze7HPMm+DPvgvlFRhwUMAgfxbX4GKRIubnusUhZ2/7+QapUJ 6FqQRkoy03Lpn0/SRy5JNFDiS82s6Jh9CtKMw+iBckeTU+1jPjA1SO3qiwWDxOrgb0w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--lrizzo.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=b93YVg4T; arc=none smtp.remote-ip=209.85.208.71 Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 822C76074AEB for ; Fri, 20 Nov 2026 01:07:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 822C76074AEB Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--lrizzo.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=b93YVg4T Received: by mail-ed1-f71.google.com with SMTP id 4fb4d7f45d1cf-6b85c9f9af9so352181a12.0 for ; Thu, 19 Nov 2026 17:07:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1795136847; x=1795741647; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=E07+bb3FRwBQVv7TP6tKUfjd8V3oXYxVPDexh6Cqmzk=; b=b93YVg4Tm3NX/spWylixOIxUhvRdvQxIAED0+riXQRtSo83NRIpTge2rBzxcszzDOC 3rugR/9IJ5658Ud+fUJT4UcFrAj82J063h9Hfj/4dN+vMPLRUBX70qcyXWzD8yndZ4r3 gvEnn939L6CAKAX2sbq66H1utJI9EEojPBLD5FlZNUJogu/LFQjD9PlVTjODPVgf4HfN Mmhes1u7rOGZpB3HfCkapqaCrgkDb1LIjXpz5iNJuBeXVa7tLbtBPXYS7tIwbEfohsZl /Ng6c6woQyveInvcT6fUrZi9u0LAgbi7XVVgHZFHCL3auVJkwOpwQMgP5SZvJhDx/pXk DgbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795136847; x=1795741647; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=E07+bb3FRwBQVv7TP6tKUfjd8V3oXYxVPDexh6Cqmzk=; b=e8pE0sCJalJsjjBQizRTSw8qQMBPRiKctxKq/GecmyjA6N2pcy2kOZmKVx71RJCZ72 qX0PuFrjf06TK4agrL9PjruVgQS/v0Eu40RslrbiP8VqIWuFag6yNp0y3lVAZzM/I9hg nm83dcEXe4cooNPAfSJpXMKT3Tds6TMWUoY+wkrhNDCOVhA+yOupxuFqYCqxpxPUEAw2 +rNl8VLF/LTttHZAJ+bcaVLx49L+r69qvGVY6+rSVNvA2oK1t/CpMQwStuGKPYRuEEBb BQZvodwA1BvDGdfuIweRWP2msmVnWL/TTf85WaxF9Lkf7CGnv25qBceCfdtZJjSo39A3 fy4g== X-Forwarded-Encrypted: i=1; AL+hErGgfh5Rlu/6yV7UyftpkoD0xLzaLMh6UClDWsRJ1AoRu3jguaH3ny1NhJKJI2hnvYew3EexM+4p3B2fBQ==@vger.kernel.org X-Gm-Message-State: APuU4Z9CQLZiyDwNvuJ3uoZ2dEr5hKGtGNbZYIW2IWINz6rKdJGrVW7j i8iMyH+iIi0GWYKUnJ0jQ7POr+4Npf3+7A2cVDzWVvltk39KlaVJ3FwH6vqihnuvHjds8fQaK4y SZ1bF3Q== X-Received: from edl2-n1.prod.google.com ([2002:a05:6402:4242:10b0:6b5:6602:7fc9]) (user=lrizzo job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6402:1e94:b0:6b5:8247:7bc7 with SMTP id 4fb4d7f45d1cf-6ba37ed4f03mr808156a12.44.1795136846496; Thu, 19 Nov 2026 17:07:26 -0800 (PST) Date: Fri, 20 Nov 2026 01:06:53 +0000 In-Reply-To: <20261120010655.467825-1-lrizzo@google.com> X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261109182533.3594984-1-lrizzo@google.com> <20261120010655.467825-1-lrizzo@google.com> X-Mailer: git-send-email 2.56.1.809.ga0b61035b5-goog Message-ID: <20261120010655.467825-24-lrizzo@google.com> Subject: [RFC PATCH v3 23/25] net/gve: Use GFP_KERNEL when pre-filling RX rings From: Luigi Rizzo To: Andrew Morton , David Hildenbrand , Johannes Weiner , Vlastimil Babka , Joerg Roedel , Will Deacon , Robin Murphy , Marek Szyprowski , Jens Axboe , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Luigi Rizzo Cc: Lorenzo Stoakes , "Liam R . Howlett" , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Zi Yan , Harry Yoo , Christoph Lameter , David Rientjes , Roman Gushchin , Hao Li , Matthew Wilcox , Jan Kara , Jann Horn , Catalin Marinas , Greg Kroah-Hartman , "Rafael J . Wysocki" , Danilo Krummrich , Jonathan Corbet , Simon Horman , Jesper Dangaard Brouer , Ilias Apalodimas , Willem de Bruijn , Kuniyuki Iwashima , Joshua Washington , Harshitha Ramamurthy , Alexander Lobakin , Christoph Hellwig , Jason Gunthorpe , Dragos Tatulea , Naman Gulati , Pranjal Shrivastava , Mostafa Saleh , Randy Dunlap , linux-mm@kvack.org, iommu@lists.linux.dev, netdev@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, driver-core@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Luigi Rizzo Content-Type: text/plain; charset="UTF-8" When pre-filling DQO and GQI RX rings in process context before NAPI is enabled (e.g. gve_open), use GFP_KERNEL instead of GFP_ATOMIC so page allocation (and CoCo page decryption) can sleep instead of dipping into atomic reserves. Signed-off-by: Luigi Rizzo --- drivers/net/ethernet/google/gve/gve_buffer_mgmt_dqo.c | 8 +++++++- drivers/net/ethernet/google/gve/gve_rx.c | 10 +++++----- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/google/gve/gve_buffer_mgmt_dqo.c b/drivers/net/ethernet/google/gve/gve_buffer_mgmt_dqo.c index 6880d1531ba5e..a3fe684ca087a 100644 --- a/drivers/net/ethernet/google/gve/gve_buffer_mgmt_dqo.c +++ b/drivers/net/ethernet/google/gve/gve_buffer_mgmt_dqo.c @@ -223,13 +223,19 @@ void gve_free_to_page_pool(struct gve_rx_ring *rx, static int gve_alloc_from_page_pool(struct gve_rx_ring *rx, struct gve_rx_buf_state_dqo *buf_state) { + /* + * Use GFP_KERNEL when pre-filling RX rings in process context (e.g. + * gve_open) so PISA metadata init and CoCo page decryption can sleep. + */ + gfp_t gfp = (gve_get_napi_enabled(rx->gve) || in_softirq()) ? + GFP_ATOMIC : GFP_KERNEL; netmem_ref netmem; buf_state->page_info.buf_size = rx->packet_buffer_truesize; netmem = page_pool_alloc_netmem(rx->dqo.page_pool, &buf_state->page_info.page_offset, &buf_state->page_info.buf_size, - GFP_ATOMIC); + gfp); if (!netmem) return -ENOMEM; diff --git a/drivers/net/ethernet/google/gve/gve_rx.c b/drivers/net/ethernet/google/gve/gve_rx.c index 81ea800e66e94..7c201fd513ee3 100644 --- a/drivers/net/ethernet/google/gve/gve_rx.c +++ b/drivers/net/ethernet/google/gve/gve_rx.c @@ -159,14 +159,13 @@ static void gve_setup_rx_buffer(struct gve_rx_ring *rx, static int gve_rx_alloc_buffer(struct gve_priv *priv, struct device *dev, struct gve_rx_slot_page_info *page_info, union gve_rx_data_slot *data_slot, - struct gve_rx_ring *rx) + struct gve_rx_ring *rx, gfp_t gfp) { struct page *page; dma_addr_t dma; int err; - err = gve_alloc_page(priv, dev, &page, &dma, DMA_FROM_DEVICE, - GFP_ATOMIC); + err = gve_alloc_page(priv, dev, &page, &dma, DMA_FROM_DEVICE, gfp); if (err) { u64_stats_update_begin(&rx->statss); rx->rx_buf_alloc_fail++; @@ -209,7 +208,7 @@ static int gve_rx_prefill_pages(struct gve_rx_ring *rx, } err = gve_rx_alloc_buffer(priv, &priv->pdev->dev, &rx->data.page_info[i], - &rx->data.data_ring[i], rx); + &rx->data.data_ring[i], rx, GFP_KERNEL); if (err) goto alloc_err_rda; } @@ -986,7 +985,8 @@ static bool gve_rx_refill_buffers(struct gve_priv *priv, struct gve_rx_ring *rx) gve_rx_free_buffer(dev, page_info, data_slot); page_info->page = NULL; if (gve_rx_alloc_buffer(priv, dev, page_info, - data_slot, rx)) { + data_slot, rx, + GFP_ATOMIC)) { break; } } -- 2.56.1.809.ga0b61035b5-goog