From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Ming Lei <ming.lei@redhat.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Sagi Grimberg <sagi@grimberg.me>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] nvme: fix handling single range discard request
Date: Wed, 8 Mar 2023 05:38:58 +0000 [thread overview]
Message-ID: <2035a3cb-7cec-e461-d36f-140ab751c04f@nvidia.com> (raw)
In-Reply-To: <20230303231345.119652-1-ming.lei@redhat.com>
On 3/3/2023 3:13 PM, Ming Lei wrote:
> When investigating one customer report on warning in nvme_setup_discard,
> we observed the controller(nvme/tcp) actually exposes
> queue_max_discard_segments(req->q) == 1.
>
> Obviously the current code can't handle this situation, since contiguity
> merge like normal RW request is taken.
>
> Fix the issue by building range from request sector/nr_sectors directly.
>
> Fixes: b35ba01ea697 ("nvme: support ranged discard requests")
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> ---
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2023-03-08 5:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 23:13 [PATCH] nvme: fix handling single range discard request Ming Lei
2023-03-04 8:00 ` Hannes Reinecke
2023-03-04 10:22 ` Ming Lei
2023-03-04 11:14 ` Hannes Reinecke
2023-03-04 12:02 ` Ming Lei
2023-03-06 14:21 ` Sagi Grimberg
2023-03-06 21:49 ` Ming Lei
2023-03-07 11:39 ` Sagi Grimberg
2023-03-07 12:14 ` Ming Lei
2023-03-07 12:31 ` Sagi Grimberg
2023-03-07 14:24 ` Ming Lei
2023-03-08 5:42 ` Chaitanya Kulkarni
2023-03-08 5:36 ` Chaitanya Kulkarni
2023-03-08 5:38 ` Chaitanya Kulkarni [this message]
2023-03-09 9:41 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2035a3cb-7cec-e461-d36f-140ab751c04f@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).