From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5008F1CCB30 for ; Thu, 22 Aug 2024 15:43:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724341426; cv=none; b=jOlbHudSNBC1g1jVVZzxwIkBOgzsmAOF6WFcoKta6W8SiGvc+W6bvQHUEmTyQQx/V4wgsj7VHbWLQull9qvkyY564HXogVINOAb5T58it19Q0/coUyttl8plTIJ6+o3w+y9VOLKdiD9jLz2BdXYXdKQb/JbviNc8atOBTGyq2OE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724341426; c=relaxed/simple; bh=s9+lhf9oVSWLun6YVWx4AibdYxDZ+HTTjkNY5OG72Xo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GH+xlR+Wp5YBhG/XaL6aVp/aURrU0ubGBVGe6hGHSzgAUswTr00cWnqNRQRMvyk6TZGDjpqoO7zBNXUBBo+UMGWKURDCoiBlbPAvx/vQMiQ4HHAZKlxfNhWM17PMX7PZQis+or0yGLTbMe2xSLadsGh0yh7hojwUFS08gJ/D99k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=Atgnesln; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="Atgnesln" Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 47M578Y0027428; Thu, 22 Aug 2024 15:43:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s=pp1; bh=e 2KeThm8c5bnYm6vH+93xF+syKa0YiHEABGNts5jRQo=; b=Atgnesln03HjEWO08 8VJ5+YGOQnMM0IqkV8NyyDwCouS6XEKQZ63nKrgsBEOT+Svjb3farvKZS4hqCy6A S7u8GfudIdahyExQdKdtz5qrgRuZGVDJPwWUPo3mnyFO8cHp569ymJEP3vC9FWXz HTV1EVvOaXxqYtsOYbseFNH2MItEMmkSs74nr4kqYN5NYaVDFVl4gtQ+ow5ajFbP LlmhfsA/YpgOot/JfTzO9fCrTDioV9Iyh5UlG48eJwfw9dedUEaoFhOSSGUg4Lh4 fWhYcsVcTwIW7DK5+Z6IKZdisPbvYHkWAWeqio6p1E3yb9mvr3J//KvpMvMIGCgL X6NFA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4141y214ws-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Aug 2024 15:43:36 +0000 (GMT) Received: from m0353729.ppops.net (m0353729.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 47MFd4FO024465; Thu, 22 Aug 2024 15:43:36 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4141y214wq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Aug 2024 15:43:36 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 47MFYuoT017663; Thu, 22 Aug 2024 15:43:35 GMT Received: from smtprelay03.dal12v.mail.ibm.com ([172.16.1.5]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 4138w3d46e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Aug 2024 15:43:35 +0000 Received: from smtpav06.wdc07v.mail.ibm.com (smtpav06.wdc07v.mail.ibm.com [10.39.53.233]) by smtprelay03.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 47MFhW6X11993608 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 22 Aug 2024 15:43:35 GMT Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C00DB58067; Thu, 22 Aug 2024 15:43:32 +0000 (GMT) Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E347858066; Thu, 22 Aug 2024 15:43:30 +0000 (GMT) Received: from [9.171.17.129] (unknown [9.171.17.129]) by smtpav06.wdc07v.mail.ibm.com (Postfix) with ESMTP; Thu, 22 Aug 2024 15:43:30 +0000 (GMT) Message-ID: <20a3f01c-0992-45e8-8970-30a2747ed8bf@linux.ibm.com> Date: Thu, 22 Aug 2024 21:13:29 +0530 Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH blktests] nvme/052: wait for namespace removal before recreating namespace To: Daniel Wagner , Shinichiro Kawasaki Cc: "linux-block@vger.kernel.org" , "linux-nvme@lists.infradead.org" , Yi Zhang References: <20240820102013.781794-1-shinichiro.kawasaki@wdc.com> <0750187c-24ad-4073-9ba1-d47b0ee95062@linux.ibm.com> <12fa9b5b-8a8b-42a6-9430-94661bfbdd21@linux.ibm.com> Content-Language: en-US From: Nilay Shroff In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: LBeUGAE66jnqjsNjtBvTRF28ZD5dvFpI X-Proofpoint-ORIG-GUID: Er2gZvnbPBC5bdS7nf3BvHySemqjvEhu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-08-22_09,2024-08-22_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 adultscore=0 suspectscore=0 spamscore=0 mlxlogscore=999 bulkscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2407110000 definitions=main-2408220117 On 8/22/24 20:19, Daniel Wagner wrote: > On Thu, Aug 22, 2024 at 11:59:35AM GMT, Shinichiro Kawasaki wrote: >> I can agree with this point: it is odd to suppress errors only for the namespace >> removal case. I did so to catch other potential errors that _find_nvme_ns() may >> return in the future for the namespace creation case. But still this way misses >> other potential errors for the namespace removal case. Maybe I was overthinking. >> Let's simplify the test with just doing >> >> ns=$(_find_nvme_ns "${uuid}" 2>/dev/null) >> >> as you suggest. Still the test case can detect the kernel regression, and I >> think it's good enough. Will reflect this to v2. > > Not sure if this is relevant, but I'd like to see that we return error > codes so that the caller can actually decide to ignore the failure or > not. The _find_nvme_ns(), when fails to find the relevant namespace, it returns "empty string" and if it could find namespace then it returns the namespace value to the caller. And then caller (in this case nvmf_wait_for_ns()) would take action depending on the return value from _find_nvme_ns(). Thanks, --Nilay