[PATCH blktests v2 11/11] nvme/{021,022,025,026,027,028}: do not hard code target blkdev type

Shin'ichiro Kawasaki
2024-04-16T10:32:20Z

From: Daniel Wagner <dwagner@suse.de>

There is no need to hardcode the target blkdev type. This allows
the user to select different blkdev types via the nvmet_blkdev_type
environment variable. Also modify set_conditions() hooks to call
_set_nvme_trtype_and_nvmet_blkdev_type() instead of _set_nvme_trtype(),
so that the test cases are run for all blkdev types set in
NVMET_BLKDEV_TYPES.

Signed-off-by: Daniel Wagner <dwagner@suse.de>
[Shin'ichiro: modify set_conditions()]
Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
---
tests/nvme/021 | 8 ++++----
tests/nvme/022 | 8 ++++----
tests/nvme/025 | 8 ++++----
tests/nvme/026 | 8 ++++----
tests/nvme/027 | 8 ++++----
tests/nvme/028 | 8 ++++----
6 files changed, 24 insertions(+), 24 deletions(-)

diff --git a/tests/nvme/021 b/tests/nvme/021
index 270d90e..d7add6f 100755
--- a/tests/nvme/021
+++ b/tests/nvme/021
@@ -2,11 +2,11 @@
# SPDX-License-Identifier: GPL-2.0+
# Copyright (c) 2017-2018 Western Digital Corporation or its affiliates.
#
-# Test NVMe list command on NVMeOF with a file-backed ns.
+# Test NVMe list command.

. tests/nvme/rc

-DESCRIPTION="test NVMe list command on NVMeOF file-backed ns"
+DESCRIPTION="test NVMe list command"
QUICK=1

requires() {
@@ -16,7 +16,7 @@ requires() {
}

set_conditions() {
- _set_nvme_trtype "$@"
+ _set_nvme_trtype_and_nvmet_blkdev_type "$@"
}

test() {
@@ -26,7 +26,7 @@ test() {

local ns

- _nvmet_target_setup --blkdev file
+ _nvmet_target_setup

_nvme_connect_subsys

diff --git a/tests/nvme/022 b/tests/nvme/022
index adaa765..0f2868c 100755
--- a/tests/nvme/022
+++ b/tests/nvme/022
@@ -2,11 +2,11 @@
# SPDX-License-Identifier: GPL-2.0+
# Copyright (c) 2017-2018 Western Digital Corporation or its affiliates.
#
-# Test NVMe reset command on NVMeOF with a file-backed ns.
+# Test NVMe reset command.

. tests/nvme/rc

-DESCRIPTION="test NVMe reset command on NVMeOF file-backed ns"
+DESCRIPTION="test NVMe reset command"
QUICK=1

requires() {
@@ -16,7 +16,7 @@ requires() {
}

set_conditions() {
- _set_nvme_trtype "$@"
+ _set_nvme_trtype_and_nvmet_blkdev_type "$@"
}

test() {
@@ -26,7 +26,7 @@ test() {

local nvmedev

- _nvmet_target_setup --blkdev file
+ _nvmet_target_setup

_nvme_connect_subsys

diff --git a/tests/nvme/025 b/tests/nvme/025
index 224492b..a171099 100755
--- a/tests/nvme/025
+++ b/tests/nvme/025
@@ -2,11 +2,11 @@
# SPDX-License-Identifier: GPL-2.0+
# Copyright (c) 2017-2018 Western Digital Corporation or its affiliates.
#
-# Test NVMe effects-log command on NVMeOF with a file-backed ns.
+# Test NVMe effects-log command.

. tests/nvme/rc

-DESCRIPTION="test NVMe effects-log command on NVMeOF file-backed ns"
+DESCRIPTION="test NVMe effects-log"
QUICK=1

requires() {
@@ -16,7 +16,7 @@ requires() {
}

set_conditions() {
- _set_nvme_trtype "$@"
+ _set_nvme_trtype_and_nvmet_blkdev_type "$@"
}

test() {
@@ -26,7 +26,7 @@ test() {

local ns

- _nvmet_target_setup --blkdev file
+ _nvmet_target_setup

_nvme_connect_subsys

diff --git a/tests/nvme/026 b/tests/nvme/026
index 6ee6a51..7196c60 100755
--- a/tests/nvme/026
+++ b/tests/nvme/026
@@ -2,11 +2,11 @@
# SPDX-License-Identifier: GPL-2.0+
# Copyright (c) 2017-2018 Western Digital Corporation or its affiliates.
#
-# Test NVMe ns-descs command on NVMeOF with a file-backed ns.
+# Test NVMe ns-descs command.

. tests/nvme/rc

-DESCRIPTION="test NVMe ns-descs command on NVMeOF file-backed ns"
+DESCRIPTION="test NVMe ns-descs"
QUICK=1

requires() {
@@ -16,7 +16,7 @@ requires() {
}

set_conditions() {
- _set_nvme_trtype "$@"
+ _set_nvme_trtype_and_nvmet_blkdev_type "$@"
}

test() {
@@ -26,7 +26,7 @@ test() {

local ns

- _nvmet_target_setup --blkdev file
+ _nvmet_target_setup

_nvme_connect_subsys

diff --git a/tests/nvme/027 b/tests/nvme/027
index a63e42b..b117cc1 100755
--- a/tests/nvme/027
+++ b/tests/nvme/027
@@ -2,11 +2,11 @@
# SPDX-License-Identifier: GPL-2.0+
# Copyright (c) 2017-2018 Western Digital Corporation or its affiliates.
#
-# Test NVMe ns-rescan command on NVMeOF with a file-backed ns.
+# Test NVMe ns-rescan command.

. tests/nvme/rc

-DESCRIPTION="test NVMe ns-rescan command on NVMeOF file-backed ns"
+DESCRIPTION="test NVMe ns-rescan command"
QUICK=1

requires() {
@@ -16,7 +16,7 @@ requires() {
}

set_conditions() {
- _set_nvme_trtype "$@"
+ _set_nvme_trtype_and_nvmet_blkdev_type "$@"
}

test() {
@@ -26,7 +26,7 @@ test() {

local nvmedev

- _nvmet_target_setup --blkdev file
+ _nvmet_target_setup

_nvme_connect_subsys

diff --git a/tests/nvme/028 b/tests/nvme/028
index 65c52a9..d6ffdd6 100755
--- a/tests/nvme/028
+++ b/tests/nvme/028
@@ -2,11 +2,11 @@
# SPDX-License-Identifier: GPL-2.0+
# Copyright (c) 2017-2018 Western Digital Corporation or its affiliates.
#
-# Test NVMe list-subsys command on NVMeOF with a file-backed ns.
+# Test NVMe list-subsys command.

. tests/nvme/rc

-DESCRIPTION="test NVMe list-subsys command on NVMeOF file-backed ns"
+DESCRIPTION="test NVMe list-subsys"
QUICK=1

requires() {
@@ -16,7 +16,7 @@ requires() {
}

set_conditions() {
- _set_nvme_trtype "$@"
+ _set_nvme_trtype_and_nvmet_blkdev_type "$@"
}

test() {
@@ -24,7 +24,7 @@ test() {

_setup_nvmet

- _nvmet_target_setup --blkdev file
+ _nvmet_target_setup

_nvme_connect_subsys

--
2.44.0