From: Jens Axboe <axboe@kernel.dk>
To: linux-block@vger.kernel.org
Subject: Re: [PATCH] blk-throttle: use queue_is_rq_based
Date: Fri, 19 Jan 2018 12:58:10 -0700 [thread overview]
Message-ID: <2197d5a1-0e93-e554-4645-2220e2a0b3ae@kernel.dk> (raw)
In-Reply-To: <20180119174053.GA967@localhost.didichuxing.com>
On 1/19/18 10:40 AM, weiping zhang wrote:
> use queue_is_rq_based instead of open code.
>
> Signed-off-by: weiping zhang <zhangweiping@didichuxing.com>
> ---
> block/blk-throttle.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-throttle.c b/block/blk-throttle.c
> index 96ad326..457e985 100644
> --- a/block/blk-throttle.c
> +++ b/block/blk-throttle.c
> @@ -2456,7 +2456,7 @@ void blk_throtl_register_queue(struct request_queue *q)
> td->throtl_slice = DFL_THROTL_SLICE_HD;
> #endif
>
> - td->track_bio_latency = !q->mq_ops && !q->request_fn;
> + td->track_bio_latency = !(queue_is_rq_based(q));
Kill the extra parenthesis here.
--
Jens Axboe
next prev parent reply other threads:[~2018-01-19 19:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-19 17:40 [PATCH] blk-throttle: use queue_is_rq_based weiping zhang
2018-01-19 19:58 ` Jens Axboe [this message]
2018-01-19 23:35 ` weiping zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2197d5a1-0e93-e554-4645-2220e2a0b3ae@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox