From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-bcache@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: simplify queue allocation
Date: Fri, 27 Mar 2020 10:18:51 -0600 [thread overview]
Message-ID: <21bb5f8e-d395-c8fe-bf08-00e4f37cbb69@kernel.dk> (raw)
In-Reply-To: <20200327161754.GA19480@lst.de>
On 3/27/20 10:17 AM, Christoph Hellwig wrote:
> On Fri, Mar 27, 2020 at 09:53:16AM -0600, Jens Axboe wrote:
>> On 3/27/20 2:30 AM, Christoph Hellwig wrote:
>>> Hi Jens,
>>>
>>> this series ensures all allocated queues have a valid ->make_request_fn
>>> and also nicely consolidates the code for allocating queues.
>>
>> This seems fine to me, but might be a good idea to shuffle 4/5 as the
>> last one, and do that one inside the merge window to avoid any potential
>> silly merge conflicts.
>
> they should be trivial to reorder if you want to skip patch 4 for now.
> But looking at current linux-next there isn't any conflict yet,
> and I don't expect one as most block drivers go through the block
> tree anyway.
Yeah I guess so, and any potential conflict would be trivial. I'll apply
it and hope for the best.
--
Jens Axboe
prev parent reply other threads:[~2020-03-27 16:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 8:30 simplify queue allocation Christoph Hellwig
2020-03-27 8:30 ` [PATCH 1/5] block: add a blk_mq_init_queue_data helper Christoph Hellwig
2020-03-27 10:05 ` Johannes Thumshirn
2020-03-27 8:30 ` [PATCH 2/5] null_blk: use blk_mq_init_queue_data Christoph Hellwig
2020-03-27 10:06 ` Johannes Thumshirn
2020-03-27 8:30 ` [PATCH 3/5] bcache: pass the make_request methods to blk_queue_make_request Christoph Hellwig
2020-03-30 11:15 ` Coly Li
2020-03-27 8:30 ` [PATCH 4/5] block: simplify queue allocation Christoph Hellwig
2020-03-27 10:11 ` Johannes Thumshirn
2020-03-27 11:21 ` Christoph Hellwig
2020-03-27 16:24 ` Johannes Thumshirn
2020-03-27 16:26 ` Jens Axboe
2020-03-27 8:30 ` [PATCH 5/5] Revert "blkdev: check for valid request queue before issuing flush" Christoph Hellwig
2020-03-27 15:53 ` simplify queue allocation Jens Axboe
2020-03-27 16:17 ` Christoph Hellwig
2020-03-27 16:18 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21bb5f8e-d395-c8fe-bf08-00e4f37cbb69@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).