public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Nilay Shroff <nilay@linux.ibm.com>
To: Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org
Subject: Re: [PATCH 1/2] block: Revert "block: Fix potential deadlock while freezing queue and acquiring sysfs_lock"
Date: Fri, 20 Dec 2024 15:53:42 +0530	[thread overview]
Message-ID: <23c3e917-9dd3-4a0f-8bf4-0a6f421aae0e@linux.ibm.com> (raw)
In-Reply-To: <20241218101617.3275704-2-ming.lei@redhat.com>

On 12/18/24 15:46, Ming Lei wrote:
> This reverts commit be26ba96421ab0a8fa2055ccf7db7832a13c44d2.
> 
> Commit be26ba96421a ("block: Fix potential deadlock while freezing queue and
> acquiring sysfs_loc") actually reverts commit 22465bbac53c ("blk-mq: move cpuhp
> callback registering out of q->sysfs_lock"), and causes the original resctrl
> lockdep warning.
> 
> So revert it and we need to fix the issue in another way.
> 
Hi Ming,

Can we wait here for some more time before we revert this as this is
currently being discussed[1] and we don't know yet how we may fix it?

[1]https://lore.kernel.org/all/20241219061514.GA19575@lst.de/

Thanks,
--Nilay



  reply	other threads:[~2024-12-20 10:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-18 10:16 [PATCH 0/2] block: fix two regressions in v6.13 dev cycle Ming Lei
2024-12-18 10:16 ` [PATCH 1/2] block: Revert "block: Fix potential deadlock while freezing queue and acquiring sysfs_lock" Ming Lei
2024-12-20 10:23   ` Nilay Shroff [this message]
2024-12-20 15:09     ` Jens Axboe
2024-12-20 15:18       ` Nilay Shroff
2024-12-20 15:24       ` Ming Lei
2024-12-21 12:31         ` Nilay Shroff
2024-12-18 10:16 ` [PATCH 2/2] block: avoid to reuse `hctx` not removed from cpuhp callback list Ming Lei
2024-12-18 14:25 ` [PATCH 0/2] block: fix two regressions in v6.13 dev cycle Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23c3e917-9dd3-4a0f-8bf4-0a6f421aae0e@linux.ibm.com \
    --to=nilay@linux.ibm.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox