From: Oleksandr Natalenko <oleksandr@natalenko.name>
To: Jens Axboe <axboe@kernel.dk>, Ming Lei <ming.lei@redhat.com>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] block: return ELEVATOR_DISCARD_MERGE if possible
Date: Mon, 09 Aug 2021 22:30:56 +0200 [thread overview]
Message-ID: <2418399.CND23VilKT@natalenko.name> (raw)
In-Reply-To: <YQtcZHgE1cTl+KVz@T590>
Hello.
On čtvrtek 5. srpna 2021 5:35:00 CEST Ming Lei wrote:
> On Thu, Jul 29, 2021 at 11:42:26AM +0800, Ming Lei wrote:
> > When merging one bio to request, if they are discard IO and the queue
> > supports multi-range discard, we need to return ELEVATOR_DISCARD_MERGE
> > because both block core and related drivers(nvme, virtio-blk) doesn't
> > handle mixed discard io merge(traditional IO merge together with
> > discard merge) well.
> >
> > Fix the issue by returning ELEVATOR_DISCARD_MERGE in this situation,
> > so both blk-mq and drivers just need to handle multi-range discard.
> >
> > Reported-by: Oleksandr Natalenko <oleksandr@natalenko.name>
> > Signed-off-by: Ming Lei <ming.lei@redhat.com>
>
> Hello Jens and Guys,
>
> Ping...
Ping v2 here… I'm still running a couple of affected systems with this patch,
and the issue doesn't pop up any more.
Thanks.
--
Oleksandr Natalenko (post-factum)
next prev parent reply other threads:[~2021-08-09 20:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 3:42 [PATCH] block: return ELEVATOR_DISCARD_MERGE if possible Ming Lei
2021-07-29 7:17 ` Oleksandr Natalenko
2021-07-29 9:18 ` Ming Lei
2021-08-05 3:35 ` Ming Lei
2021-08-09 20:30 ` Oleksandr Natalenko [this message]
2021-08-09 20:36 ` Jens Axboe
2021-08-10 2:47 ` Ming Lei
2021-08-10 2:55 ` Jens Axboe
2021-08-10 3:28 ` Ming Lei
-- strict thread matches above, loose matches on Subject: below --
2022-05-21 18:56 Gwendal Grignou
2022-05-23 15:13 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2418399.CND23VilKT@natalenko.name \
--to=oleksandr@natalenko.name \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).