From: Jens Axboe <axboe@kernel.dk>
To: "Javier González" <javier@javigon.com>, mb@lightnvm.io
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
"Javier González" <javier@cnexlabs.com>
Subject: Re: [PATCH] lightnvm: pblk: take write semaphore on metadata
Date: Thu, 2 Aug 2018 09:57:40 -0600 [thread overview]
Message-ID: <2436f855-7a87-9ecd-be3a-358939c9c750@kernel.dk> (raw)
In-Reply-To: <1533217674-9514-1-git-send-email-javier@cnexlabs.com>
On 8/2/18 7:47 AM, Javier González wrote:
> Take the write semaphore on metadata I/Os too.
I'm going to nit pick a little bit here, but this isn't a good
changelog at all. A good changelog tells you _why_ a change is
made, not how it's made. Your commit message doesn't really tell
me anything that I can't easily glean from looking at the patch.
A good commit message would tell me _why_ we are now also
grabbing the write sem for metadata.
--
Jens Axboe
next prev parent reply other threads:[~2018-08-02 15:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 13:47 [PATCH] lightnvm: pblk: take write semaphore on metadata Javier González
2018-08-02 15:57 ` Jens Axboe [this message]
2018-08-02 16:01 ` Javier Gonzalez
-- strict thread matches above, loose matches on Subject: below --
2018-08-03 12:05 Javier González
2018-08-03 12:45 ` Matias Bjørling
2018-08-03 13:28 ` Javier Gonzalez
2018-08-10 8:04 ` Hans Holmberg
2018-08-13 12:12 ` Javier González
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2436f855-7a87-9ecd-be3a-358939c9c750@kernel.dk \
--to=axboe@kernel.dk \
--cc=javier@cnexlabs.com \
--cc=javier@javigon.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mb@lightnvm.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox