From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36D1AC00140 for ; Wed, 10 Aug 2022 14:36:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230209AbiHJOgq (ORCPT ); Wed, 10 Aug 2022 10:36:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232333AbiHJOgf (ORCPT ); Wed, 10 Aug 2022 10:36:35 -0400 Received: from esa1.hgst.iphmx.com (esa1.hgst.iphmx.com [68.232.141.245]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98F7543E7B for ; Wed, 10 Aug 2022 07:36:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1660142194; x=1691678194; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Puv/2c7VmUYZ5sr10JH3gji4MxoaIPhu9aLiFvJPf8g=; b=M6kq7VlQa/GoN2jtkU8bthvok5kdSLUFFv+ycpcc6+qvRo/GriydnWt1 zf2BaC+Q9q8QQpkDSEJvz3EUdV3OBvDz1w03xJH8rgPPJ80na9SuYFdyk wV+OjMGrkrESaWxsYC8Lt6vBwKNdbovqCnf7GdU1VFQrWESWBw9SLVhpc Wq+UvBh9W1WDN4wSRTKyesxFckl1xTXIwgEf5vUas7ce325WIutSlk0v6 TL3rooYjHi9WoFa2zs5y5eCtrthIBCLLsF2oSqJ+U9FYcCRSGa5PkMX4q O0YUSLsaZsXwc4V70AdIv2OUwzD/DhHRPHooFgBaZ4Ht8WtpGLVjP32WP A==; X-IronPort-AV: E=Sophos;i="5.93,227,1654531200"; d="scan'208";a="320446689" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 10 Aug 2022 22:36:34 +0800 IronPort-SDR: gd1HlFmMr0F7yNyC6jcRscKsYeUarusM9Wb4acn83KqEMLxTBF0XtscYfxzMGen/Yn4FzTNd/l EbNMdcaVWnnxHYawg0W/GWLQ1qU0gYiVEkocrZXeKK/QVzbAvdo9a715Hq6hGd+OpD9uxZKHdV 0dx0MxD/ReCLcaTEzQuj9KSgQd1dVn4zdmf3cHLJ0wi7+MzwtKKjC79Mfax/LKKpbX3EWA510F Wj+LfLze76jN9XNBvhOsPt2MUqS8ZcGlXIb9atMQZ+xNALK7zpOBK5aYxfTF8f8VMMgpPb7UdC yKCoU3V0DBJKSVtuCiXA9uNm Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 10 Aug 2022 06:57:29 -0700 IronPort-SDR: Wj/BvdEJ36FErS1jsnTQ3qF4spJaMcrq8xk+EyF8yIb+WIoG6EfQ4soERBFoVKDqCpWopjRVxX bZ8yfC5uQB3s76TAJt7QzIoFwLDRTCnliD2AP1BzFKwpjZbDP+rDWBbempPc5QfP3QbzJk3Xeu fCItgLti14cMOO7efTyRK/ErE1XJq1ZWHIibXDFAgtWRYNsix6wAHAWKZ4HEvc+TrFKT+CDrYF pXp9A7P+ougbFxzW/lFrB/SPOCKe44atrWEGhI2l21USsLJ8T1Ho0nWoGri3vBkksgveaRZSzB QCI= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 10 Aug 2022 07:36:34 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4M2svP4f0Tz1Rw4L for ; Wed, 10 Aug 2022 07:36:33 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1660142193; x=1662734194; bh=Puv/2c7VmUYZ5sr10JH3gji4MxoaIPhu9aL iFvJPf8g=; b=UseI6l7kjPax8Ls0wp34uofl9yWM1/JwSzeDhqWaXjNnjwcn55c NwNjj/zZ/VgQB5i9xvdXBVJbaXxjARZz3Hn1H5aXbIIjuDjouDCiVJFnIAeomqnu uplDDHfWZIXOlu+r7f516F6gtmYMwVGACXarpeb6c23SEQ2btMoc44shqPD7qJpa TO/YMOrjKPD2N33hETHLVT5LpMmF1OPhvIhfLaldAzIfFHr5/asZT1/HHc2NVin6 I7zVS9tu+iOJRoI/TjG0CLbB3gaUEHziyp91vPZci5WhdUe+CqpCbvvJ/gL2fswj 19ZFXUU6FPol7stsgZGerD0USrpyqtszUFg== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 1noiMqDckceA for ; Wed, 10 Aug 2022 07:36:33 -0700 (PDT) Received: from [10.111.68.99] (c02drav6md6t.sdcorp.global.sandisk.com [10.111.68.99]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4M2svN5nJJz1RtVk; Wed, 10 Aug 2022 07:36:32 -0700 (PDT) Message-ID: <24b7e027-e098-269b-ccf7-b14deb499c33@opensource.wdc.com> Date: Wed, 10 Aug 2022 07:36:32 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: fs/zonefs/./trace.h:22:1: sparse: sparse: cast to restricted blk_opf_t Content-Language: en-US To: Bart Van Assche Cc: linux-kernel@vger.kernel.org, Jens Axboe , Johannes Thumshirn , "linux-block@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" References: <202208061533.YBqXyzHm-lkp@intel.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 2022/08/08 8:37, Bart Van Assche wrote: > On 8/8/22 07:48, Damien Le Moal wrote: >> Are you going to send a patch to fix this or do you want me to do it ? > > Hi Damien, > > Thanks for having taken a look. Please help with verifying whether the > following patch is sufficient to fix the reported warning: "[PATCH] > tracing: Suppress sparse warnings triggered by is_signed_type()" > (https://lore.kernel.org/all/20220717151047.19220-1-bvanassche@acm.org/). > > Bart. With the current Linus tree, I do not see this sparse warning. However, applying the above patch, "make M=fs/zonefs C=1" generates a lot of warnings: make -j64 M=fs/zonefs C=1 CC [M] fs/zonefs/super.o CC [M] fs/zonefs/sysfs.o CHECK fs/zonefs/sysfs.c CHECK fs/zonefs/super.c fs/zonefs/sysfs.c: note: in included file (through include/linux/bitops.h, include/linux/kernel.h, arch/x86/include/asm/percpu.h, arch/x86/include/asm/preempt.h, include/linux/preempt.h, include/linux/spinlock.h, ...): ./arch/x86/include/asm/bitops.h:66:1: warning: unreplaced symbol 'return' fs/zonefs/sysfs.c: note: in included file (through include/linux/bitops.h, include/linux/kernel.h, arch/x86/include/asm/percpu.h, arch/x86/include/asm/preempt.h, include/linux/preempt.h, include/linux/spinlock.h, ...): ./include/asm-generic/bitops/generic-non-atomic.h:29:9: warning: unreplaced symbol 'mask' ./include/asm-generic/bitops/generic-non-atomic.h:30:9: warning: unreplaced symbol 'p' ./include/asm-generic/bitops/generic-non-atomic.h:32:10: warning: unreplaced symbol 'p' ./include/asm-generic/bitops/generic-non-atomic.h:32:16: warning: unreplaced symbol 'mask' ./include/asm-generic/bitops/generic-non-atomic.h:27:1: warning: unreplaced symbol 'return' fs/zonefs/sysfs.c: note: in included file (through arch/x86/include/asm/bitops.h, include/linux/bitops.h, include/linux/kernel.h, arch/x86/include/asm/percpu.h, arch/x86/include/asm/preempt.h, include/linux/preempt.h, ...): ./include/asm-generic/bitops/instrumented-non-atomic.h:26:1: warning: unreplaced symbol 'return' fs/zonefs/sysfs.c: note: in included file (through include/linux/bitops.h, include/linux/kernel.h, arch/x86/include/asm/percpu.h, arch/x86/include/asm/preempt.h, include/linux/preempt.h, include/linux/spinlock.h, ...): ./arch/x86/include/asm/bitops.h:92:1: warning: unreplaced symbol 'return' fs/zonefs/sysfs.c: note: in included file (through include/linux/bitops.h, include/linux/kernel.h, arch/x86/include/asm/percpu.h, arch/x86/include/asm/preempt.h, include/linux/preempt.h, include/linux/spinlock.h, ...): ./include/asm-generic/bitops/generic-non-atomic.h:38:9: warning: unreplaced symbol 'mask' ./include/asm-generic/bitops/generic-non-atomic.h:39:9: warning: unreplaced symbol 'p' ./include/asm-generic/bitops/generic-non-atomic.h:41:10: warning: unreplaced symbol 'p' ./include/asm-generic/bitops/generic-non-atomic.h:41:16: warning: unreplaced symbol 'mask' ./include/asm-generic/bitops/generic-non-atomic.h:36:1: warning: unreplaced symbol 'return' ... Much more messages after that. -- Damien Le Moal Western Digital Research