From: Jens Axboe <axboe@fb.com>
To: Hannes Reinecke <hare@suse.de>, linux-block@vger.kernel.org
Cc: bart.vanassche@sandisk.com, hch@lst.de, osandov@fb.com,
paolo.valente@linaro.org, hare@suse.com
Subject: Re: [PATCH 0/5] blk-mq: various blk-mq/blk-mq-sched fixes
Date: Fri, 27 Jan 2017 07:40:26 -0700 [thread overview]
Message-ID: <25080b6c-47db-8db4-c0d4-a6f711fbd4bb@fb.com> (raw)
In-Reply-To: <1f162b4f-7aa1-d19b-53d8-2b621da36d27@suse.de>
On 01/27/2017 05:10 AM, Hannes Reinecke wrote:
> On 01/26/2017 08:48 PM, Jens Axboe wrote:
>> I've been diving into the problems that Hannes reported, both the
>> stalls related to shared tag maps and multiple hardware queues,
>> but also the cases where we get suboptimal merging.
>>
>> This series attempts to fix that.
>>
>> Hannes, this should be identical to what I sent you as a bundled up
>> patch earlier today. Would be great if you could run this through
>> your testing.
>>
>> The patches are against for-4.11/block
>>
> Yep, full success:
>
> 4k seq read : io=59850MB, bw=997.36MB/s, iops=255241, runt= 60028msec
> 4k rand read : io=399676KB, bw=6127.9KB/s, iops=1531, runt= 65231msec
> 4k seq write: io=12194MB, bw=207576KB/s, iops=51893, runt= 60155msec
> 4k rand write: io=111100KB, bw=1315.7KB/s, iops=328, runt= 84445msec
Perfect, do you want to add a tested-by or something?
And how does performance compare to !mq with deadline or similar?
> Although I'm getting a lockdep splat:
> ------------[ cut here ]------------
> WARNING: CPU: 4 PID: 3211 at kernel/locking/lockdep.c:3514 lock_release+
> DEBUG_LOCKS_WARN_ON(depth <= 0)
> Modules linked in: nfsv3 nfs_acl rpcsec_gss_krb5 auth_rpcgss nfsv4 nfs l
> uhci_hcd ahci ehci_hcd libahci ttm crc32c_intel serio_raw hpsa usbcore
> CPU: 4 PID: 3211 Comm: fio Not tainted 4.10.0-rc3+ #598
> Hardware name: HP ProLiant DL380p Gen8, BIOS P70 09/18/2013
That's a known issue in the base that I have, you're supposed to run
it with master pulled in. Annoying, sorry, but it's not my patches.
--
Jens Axboe
prev parent reply other threads:[~2017-01-27 14:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 19:48 [PATCH 0/5] blk-mq: various blk-mq/blk-mq-sched fixes Jens Axboe
2017-01-26 19:48 ` [PATCH 1/5] blk-mq: improve scheduler queue sync/async running Jens Axboe
2017-01-26 19:59 ` Omar Sandoval
2017-01-26 19:48 ` [PATCH 2/5] blk-mq: fix potential race in queue restart and driver tag allocation Jens Axboe
2017-01-26 19:52 ` Jens Axboe
2017-01-26 20:04 ` Omar Sandoval
2017-01-26 19:48 ` [PATCH 3/5] blk-mq: release driver tag on a requeue event Jens Axboe
2017-01-26 20:06 ` Omar Sandoval
2017-01-26 19:48 ` [PATCH 4/5] blk-mq-sched: fix starvation for multiple hardware queues and shared tags Jens Axboe
2017-01-26 20:25 ` Omar Sandoval
2017-01-26 20:26 ` Jens Axboe
2017-01-26 19:48 ` [PATCH 5/5] blk-mq-sched: change ->dispatch_requests() to ->dispatch_request() Jens Axboe
2017-01-26 20:54 ` Omar Sandoval
2017-01-26 20:59 ` Jens Axboe
2017-01-26 21:11 ` Omar Sandoval
2017-01-26 21:15 ` Jens Axboe
2017-01-27 12:10 ` [PATCH 0/5] blk-mq: various blk-mq/blk-mq-sched fixes Hannes Reinecke
2017-01-27 14:40 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25080b6c-47db-8db4-c0d4-a6f711fbd4bb@fb.com \
--to=axboe@fb.com \
--cc=bart.vanassche@sandisk.com \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=osandov@fb.com \
--cc=paolo.valente@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox