From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: jianchao.w.wang@oracle.com, linux-block@vger.kernel.org
Subject: Re: [PATCH] block: fix timeout changes for legacy request drivers
Date: Tue, 19 Jun 2018 11:07:07 -0600 [thread overview]
Message-ID: <2534f376-cfa9-71ea-6f7b-92105ced9178@kernel.dk> (raw)
In-Reply-To: <20180619164014.13621-1-hch@lst.de>
On 6/19/18 10:40 AM, Christoph Hellwig wrote:
> blk_mq_complete_request can only be called for blk-mq drivers, but when
> removing the BLK_EH_HANDLED return value, two legacy request timeout
> methods incorrectly got switched to call blk_mq_complete_request.
> Call __blk_complete_request instead to reinstance the previous behavior.
> For that __blk_complete_request needs to be exported.
Yikes. Looks like blktests only smoke tests blk-mq timeout handling,
we should add a test to do the same for !mq.
--
Jens Axboe
prev parent reply other threads:[~2018-06-19 17:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 16:40 [PATCH] block: fix timeout changes for legacy request drivers Christoph Hellwig
2018-06-19 17:07 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2534f376-cfa9-71ea-6f7b-92105ced9178@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=jianchao.w.wang@oracle.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox