From: Jens Axboe <axboe@kernel.dk>
To: Enze Li <lienze@kylinos.cn>, phil@philpotter.co.uk
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH] cdrom: do not print info list when there is no cdrom device
Date: Fri, 8 Apr 2022 06:34:04 -0600 [thread overview]
Message-ID: <25390602-cfa0-dba3-bfbc-a35ed6b44bcf@kernel.dk> (raw)
In-Reply-To: <20220408084221.1681592-1-lienze@kylinos.cn>
On 4/8/22 2:42 AM, Enze Li wrote:
> There is no need to print a list of cdrom entries with blank info when
> no cdrom device exists. With this patch applied, we get:
>
> ================================================
> $ cat /proc/sys/dev/cdrom/info
> CD-ROM information, Id:cdrom.c 3.20 2003/12/17
>
> No device found.
>
> ================================================
And what did we get before?
Will this potentially break applications that parse it?
--
Jens Axboe
next prev parent reply other threads:[~2022-04-08 12:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 8:42 [PATCH] cdrom: do not print info list when there is no cdrom device Enze Li
2022-04-08 12:34 ` Jens Axboe [this message]
2022-04-09 4:25 ` Enze Li
2022-04-09 8:16 ` Phillip Potter
[not found] ` <f74b6933-5357-6b2c-3127-7a3465dadbdf@kylinos.cn>
2022-04-11 16:51 ` Jens Axboe
2022-04-18 21:04 ` Phillip Potter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25390602-cfa0-dba3-bfbc-a35ed6b44bcf@kernel.dk \
--to=axboe@kernel.dk \
--cc=lienze@kylinos.cn \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox