Re: [PATCH v2 05/26] block/cgroup: Modify the blkg_conf_open_bdev_frozen() calling convention

Christoph Hellwig
2026-03-26T06:28:33Z

On Wed, Mar 25, 2026 at 02:44:46PM -0700, Bart Van Assche wrote:
> Instead of returning either a negative error number or a positive memory
> flags value, pass a memory flags pointer as an argument and return zero
> upon success. This patch prepares for adding thread-safety annotations
> by changing the calling convention into something that is supported by
> __cond_acquires().

Looking at this code it seems like a really messy API. It seems
like blkg_conf_open_bdev_frozen and blkg_conf_exit_frozen should
just be open coded in the only caller using the lower-level helpers
you just added earlier.