public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: John Garry <john.g.garry@oracle.com>
To: Hannes Reinecke <hare@suse.de>,
	lsf-pc@lists.linux-foundation.org,
	linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
	linux-scsi@vger.kernel.org
Subject: Re: [LSF/MM/BPF TOPIC] Native SCSI multipath support
Date: Mon, 16 Feb 2026 16:55:13 +0000	[thread overview]
Message-ID: <28ab3aa2-7654-4b4b-94be-bd691c1903dd@oracle.com> (raw)
In-Reply-To: <a5a0aa42-33e4-401f-ad94-8104cff9368c@suse.de>

On 16/02/2026 16:32, Hannes Reinecke wrote:
>> cheers, in the meantime, I have some comments:
>>
>> - I need to test PRs for both NVMe and SCSI, any advice on that would 
>> be good. I don't think that blktests covers it. I did see Christoph 
>> mention a testsuite at: https://urldefense.com/v3/__https:// 
>> lore.kernel.org/linux-nvme/1438672271-11309-1-__;!!ACWV5N9M2RV99hQ! 
>> NyU_EGj3duLYY2LeAfcU8f3WP67loAPsnqoz8qYMoV6CwqUgqWuoSE_VERaSDshSIbcmLG7zUhd4FfU$ git-send-email-hch@lst.de/ - I can check that.
>>
> Well, you might have seen the discussion on the device-mapper list, 
> where stefanha is implementing generic PRs for dm-multipathing.
> Or rather, trying to. We might need to revisit that and see what we
> could be doing on the SCSI side.
> Maybe we should be having a session about PRs at LSF?

maybe...

> 
>> - I am still not sure on whether we require a multipath version of sg. 
>> We can still have per-path sg. NVMe does have a multipath nvme-generic 
>> dev, but that just handles IOCTLs/uring cmd, and nothing like sg read/ 
>> write fops
>>
> 'sg' is primarily for testing 'raw' SCSI commands. (And dastardly 
> complex to boot). I really would keep it in it's current form, and not
> try to mimick something with SCSI multipathing.

I can get to scsi_ioctl() from the multipath sd device ioctl - 
sd_ioctl() - maybe that is enough.

> 
>> - I have not tried to detangle ALUA support from SCSI DH, so no ALUA 
>> support yet
>>
> Ouch. But that is the key point of the implementation; ALUA provides
> _all_ the information required for multipathing, so how can you _not_
> have support for it?

So far every path is just "optimised" and scsi_vpd_lun_id() is used to 
match scsi_devices ... ALUA support will be added, but if I were to do 
it now, it would just delay posting anything even further...

  reply	other threads:[~2026-02-16 16:55 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-13 14:19 [LSF/MM/BPF TOPIC] Native SCSI multipath support John Garry
2026-02-13 17:21 ` Hannes Reinecke
2026-02-14  9:42   ` John Garry
2026-02-16  7:26     ` Hannes Reinecke
2026-02-16 16:32     ` Hannes Reinecke
2026-02-16 16:55       ` John Garry [this message]
2026-02-17  7:05         ` Hannes Reinecke
2026-02-21 17:47       ` Mike Snitzer
2026-02-17 19:33 ` Bart Van Assche
2026-02-17 20:13   ` Keith Busch
2026-02-18  2:39     ` [Lsf-pc] " Martin K. Petersen
2026-02-18  7:35       ` Hannes Reinecke
2026-02-18  8:35         ` John Garry
2026-02-18  8:23   ` John Garry
2026-02-21 17:41 ` Mike Snitzer
2026-02-24  9:56   ` John Garry
2026-02-25  0:46   ` Benjamin Marzinski
2026-02-25  8:11     ` Hannes Reinecke
2026-02-25  9:26       ` John Garry
2026-03-10 17:12         ` Ewan Milne
2026-03-10 18:05           ` John Garry
2026-03-10 18:42             ` Benjamin Marzinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=28ab3aa2-7654-4b4b-94be-bd691c1903dd@oracle.com \
    --to=john.g.garry@oracle.com \
    --cc=hare@suse.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=lsf-pc@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox