From: Bart Van Assche <bvanassche@acm.org>
To: Andreas Hindborg <nmi@metaspace.dk>, Jens Axboe <axboe@kernel.dk>
Cc: Andreas Hindborg <a.hindborg@samsung.com>,
Keith Busch <kbusch@kernel.org>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] null_blk: fix validation of block size
Date: Mon, 3 Jun 2024 10:02:03 -0700 [thread overview]
Message-ID: <28fc5c30-ece5-4436-b066-3142147a4547@acm.org> (raw)
In-Reply-To: <20240601202351.691952-1-nmi@metaspace.dk>
On 6/1/24 13:23, Andreas Hindborg wrote:
> + ((dev->blocksize & (dev->blocksize - 1)) != 0)) {
Please use is_power_of_2() instead of open-coding it.
Bart.
prev parent reply other threads:[~2024-06-03 17:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-01 20:23 [PATCH] null_blk: fix validation of block size Andreas Hindborg
2024-06-02 10:57 ` John Garry
2024-06-02 23:59 ` Damien Le Moal
2024-06-03 13:54 ` John Garry
2024-06-03 17:03 ` Bart Van Assche
2024-06-03 12:03 ` Andreas Hindborg
2024-06-03 17:02 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28fc5c30-ece5-4436-b066-3142147a4547@acm.org \
--to=bvanassche@acm.org \
--cc=a.hindborg@samsung.com \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nmi@metaspace.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox